From: Andre Przywara <andre.przywara@arm.com> To: Ralf Schlatterbeck <rsc@runtux.com> Cc: Mark Brown <broonie@kernel.org>, Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Mirko Vogt <mirko-dev|linux@nanl.de> Subject: Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug Date: Mon, 24 May 2021 13:33:01 +0100 [thread overview] Message-ID: <20210524133301.32c74794@slackpad.fritz.box> (raw) In-Reply-To: <20210521201913.2gapcmrzynxekro7@runtux.com> On Fri, 21 May 2021 22:19:13 +0200 Ralf Schlatterbeck <rsc@runtux.com> wrote: Hi, > From: Mirko Vogt <mirko-dev|linux@nanl.de> > > The current sun6i SPI implementation initializes the transfer too early, > resulting in SCK going high before the transfer. When using an additional > (gpio) chipselect with sun6i, the chipselect is asserted at a time when > clock is high, making the SPI transfer fail. > > This is due to SUN6I_GBL_CTL_BUS_ENABLE being written into > SUN6I_GBL_CTL_REG at an early stage. Moving that to the transfer > function, hence, right before the transfer starts, mitigates that > problem. > > Signed-off-by: Mirko Vogt <mirko-dev|linux@nanl.de> > Signed-off-by: Ralf Schlatterbeck <rsc@runtux.com> Looks good to me now, thanks for the changes! Reviewed-by: Andre Przywara <andre.przywara@arm.com> Some comments for future contributions (should not hold back that patch, I think): - Single patch set series don't bother to have a "1/1" after the "PATCH". - You are expected to increase the version number when you send a new version, to show that *this* is better than the previous post and this version should be merged. Otherwise the maintainer might pick the wrong version. "git format-patch -v2" and "git send-email" will automatically take care of this. > --- > Updated patch with suggested improvements by Andre Przywara > For oscilloscope screenshots with/without the patch, see my blog post > https://blog.runtux.com/posts/2019/04/18/ > or the discussion in the armbian forum at > https://forum.armbian.com/topic/4330-spi-gpio-chip-select-support/ > (my logo there is a penguin). Please keep in mind that text after the dashes doesn't make it in it repo, so this information would be lost there. Also, in general links in commit messages are somewhat frowned upon, since they tend to 404 sooner or later. So ideally you can put a condensed version of your findings into the commit message? Don't worry if it grows long, it is not uncommon to have a 2 page commit message for a one-liner patch. Cheers, Andre > > drivers/spi/spi-sun6i.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c > index cc8401980125..23ad052528db 100644 > --- a/drivers/spi/spi-sun6i.c > +++ b/drivers/spi/spi-sun6i.c > @@ -379,6 +379,10 @@ static int sun6i_spi_transfer_one(struct spi_master *master, > } > > sun6i_spi_write(sspi, SUN6I_CLK_CTL_REG, reg); > + /* Finally enable the bus - doing so before might raise SCK to HIGH */ > + reg = sun6i_spi_read(sspi, SUN6I_GBL_CTL_REG); > + reg |= SUN6I_GBL_CTL_BUS_ENABLE; > + sun6i_spi_write(sspi, SUN6I_GBL_CTL_REG, reg); > > /* Setup the transfer now... */ > if (sspi->tx_buf) > @@ -504,7 +508,7 @@ static int sun6i_spi_runtime_resume(struct device *dev) > } > > sun6i_spi_write(sspi, SUN6I_GBL_CTL_REG, > - SUN6I_GBL_CTL_BUS_ENABLE | SUN6I_GBL_CTL_MASTER | SUN6I_GBL_CTL_TP); > + SUN6I_GBL_CTL_MASTER | SUN6I_GBL_CTL_TP); > > return 0; >
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com> To: Ralf Schlatterbeck <rsc@runtux.com> Cc: Mark Brown <broonie@kernel.org>, Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Mirko Vogt <mirko-dev|linux@nanl.de> Subject: Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug Date: Mon, 24 May 2021 13:33:01 +0100 [thread overview] Message-ID: <20210524133301.32c74794@slackpad.fritz.box> (raw) In-Reply-To: <20210521201913.2gapcmrzynxekro7@runtux.com> On Fri, 21 May 2021 22:19:13 +0200 Ralf Schlatterbeck <rsc@runtux.com> wrote: Hi, > From: Mirko Vogt <mirko-dev|linux@nanl.de> > > The current sun6i SPI implementation initializes the transfer too early, > resulting in SCK going high before the transfer. When using an additional > (gpio) chipselect with sun6i, the chipselect is asserted at a time when > clock is high, making the SPI transfer fail. > > This is due to SUN6I_GBL_CTL_BUS_ENABLE being written into > SUN6I_GBL_CTL_REG at an early stage. Moving that to the transfer > function, hence, right before the transfer starts, mitigates that > problem. > > Signed-off-by: Mirko Vogt <mirko-dev|linux@nanl.de> > Signed-off-by: Ralf Schlatterbeck <rsc@runtux.com> Looks good to me now, thanks for the changes! Reviewed-by: Andre Przywara <andre.przywara@arm.com> Some comments for future contributions (should not hold back that patch, I think): - Single patch set series don't bother to have a "1/1" after the "PATCH". - You are expected to increase the version number when you send a new version, to show that *this* is better than the previous post and this version should be merged. Otherwise the maintainer might pick the wrong version. "git format-patch -v2" and "git send-email" will automatically take care of this. > --- > Updated patch with suggested improvements by Andre Przywara > For oscilloscope screenshots with/without the patch, see my blog post > https://blog.runtux.com/posts/2019/04/18/ > or the discussion in the armbian forum at > https://forum.armbian.com/topic/4330-spi-gpio-chip-select-support/ > (my logo there is a penguin). Please keep in mind that text after the dashes doesn't make it in it repo, so this information would be lost there. Also, in general links in commit messages are somewhat frowned upon, since they tend to 404 sooner or later. So ideally you can put a condensed version of your findings into the commit message? Don't worry if it grows long, it is not uncommon to have a 2 page commit message for a one-liner patch. Cheers, Andre > > drivers/spi/spi-sun6i.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c > index cc8401980125..23ad052528db 100644 > --- a/drivers/spi/spi-sun6i.c > +++ b/drivers/spi/spi-sun6i.c > @@ -379,6 +379,10 @@ static int sun6i_spi_transfer_one(struct spi_master *master, > } > > sun6i_spi_write(sspi, SUN6I_CLK_CTL_REG, reg); > + /* Finally enable the bus - doing so before might raise SCK to HIGH */ > + reg = sun6i_spi_read(sspi, SUN6I_GBL_CTL_REG); > + reg |= SUN6I_GBL_CTL_BUS_ENABLE; > + sun6i_spi_write(sspi, SUN6I_GBL_CTL_REG, reg); > > /* Setup the transfer now... */ > if (sspi->tx_buf) > @@ -504,7 +508,7 @@ static int sun6i_spi_runtime_resume(struct device *dev) > } > > sun6i_spi_write(sspi, SUN6I_GBL_CTL_REG, > - SUN6I_GBL_CTL_BUS_ENABLE | SUN6I_GBL_CTL_MASTER | SUN6I_GBL_CTL_TP); > + SUN6I_GBL_CTL_MASTER | SUN6I_GBL_CTL_TP); > > return 0; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-24 12:33 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-20 10:06 [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug Ralf Schlatterbeck 2021-05-20 10:06 ` Ralf Schlatterbeck 2021-05-21 16:30 ` Andre Przywara 2021-05-21 16:30 ` Andre Przywara 2021-05-21 20:16 ` Ralf Schlatterbeck 2021-05-21 20:16 ` Ralf Schlatterbeck 2021-05-21 20:19 ` Ralf Schlatterbeck 2021-05-21 20:19 ` Ralf Schlatterbeck 2021-05-24 12:33 ` Andre Przywara [this message] 2021-05-24 12:33 ` Andre Przywara 2021-05-24 16:24 ` Ralf Schlatterbeck 2021-05-24 16:24 ` Ralf Schlatterbeck 2021-05-25 14:35 ` Mark Brown 2021-05-25 14:35 ` Mark Brown 2021-05-27 11:39 ` Ralf Schlatterbeck 2021-05-27 11:39 ` Ralf Schlatterbeck 2021-06-05 14:06 ` Mirko Vogt 2021-06-05 14:06 ` Mirko Vogt 2021-06-14 14:47 ` Ralf Schlatterbeck 2021-06-14 14:47 ` Ralf Schlatterbeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210524133301.32c74794@slackpad.fritz.box \ --to=andre.przywara@arm.com \ --cc=broonie@kernel.org \ --cc=jernej.skrabec@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=mirko-dev|linux@nanl.de \ --cc=mripard@kernel.org \ --cc=rsc@runtux.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.