All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lokesh Vutla <lokeshvutla@ti.com>
To: <thierry.reding@gmail.com>, <u.kleine-koenig@pengutronix.de>,
	<lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>
Cc: <tony@atomide.com>, Sekhar Nori <nsekhar@ti.com>,
	Vignesh R <vigneshr@ti.com>, Nishanth Menon <nm@ti.com>,
	<linux-pwm@vger.kernel.org>,
	Device Tree Mailing List <devicetree@vger.kernel.org>,
	Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	Lokesh Vutla <lokeshvutla@ti.com>
Subject: [PATCH 2/4] dt-bindings: pwm: tiehrpwm: Make clock and clock-names as required properties
Date: Wed, 26 May 2021 14:13:04 +0530	[thread overview]
Message-ID: <20210526084306.6534-3-lokeshvutla@ti.com> (raw)
In-Reply-To: <20210526084306.6534-1-lokeshvutla@ti.com>

Driver fails to probe when 'clock' and 'clock-names' properties are not
populated in DT. But the binding documentation says these properties are
optional. Fix this by making 'clock' and 'clock-names' properties as
required.

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
index e124e41418d8..8eae48c9c5cd 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
@@ -11,8 +11,6 @@ Required properties:
   the cells format. The only third cell flag supported by this binding is
   PWM_POLARITY_INVERTED.
 - reg: physical base address and size of the registers map.
-
-Optional properties:
 - clocks: Handle to the PWM's time-base and functional clock.
 - clock-names: Must be set to "tbclk" and "fck".
 
@@ -38,6 +36,8 @@ ehrpwm0: pwm@1f00000 { /* EHRPWM on da850 */
 	compatible = "ti,da850-ehrpwm", "ti,am3352-ehrpwm";
 	#pwm-cells = <3>;
 	reg = <0x1f00000 0x2000>;
+	clocks = <&psc1 17>, <&ehrpwm_tbclk>;
+	clock-names = "fck", "tbclk";
 };
 
 ehrpwm0: pwm@4843e200 { /* EHRPWM on dra746 */
-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: Lokesh Vutla <lokeshvutla@ti.com>
To: <thierry.reding@gmail.com>, <u.kleine-koenig@pengutronix.de>,
	<lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>
Cc: <tony@atomide.com>, Sekhar Nori <nsekhar@ti.com>,
	Vignesh R <vigneshr@ti.com>, Nishanth Menon <nm@ti.com>,
	<linux-pwm@vger.kernel.org>,
	Device Tree Mailing List <devicetree@vger.kernel.org>,
	Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	Lokesh Vutla <lokeshvutla@ti.com>
Subject: [PATCH 2/4] dt-bindings: pwm: tiehrpwm: Make clock and clock-names as required properties
Date: Wed, 26 May 2021 14:13:04 +0530	[thread overview]
Message-ID: <20210526084306.6534-3-lokeshvutla@ti.com> (raw)
In-Reply-To: <20210526084306.6534-1-lokeshvutla@ti.com>

Driver fails to probe when 'clock' and 'clock-names' properties are not
populated in DT. But the binding documentation says these properties are
optional. Fix this by making 'clock' and 'clock-names' properties as
required.

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
index e124e41418d8..8eae48c9c5cd 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
@@ -11,8 +11,6 @@ Required properties:
   the cells format. The only third cell flag supported by this binding is
   PWM_POLARITY_INVERTED.
 - reg: physical base address and size of the registers map.
-
-Optional properties:
 - clocks: Handle to the PWM's time-base and functional clock.
 - clock-names: Must be set to "tbclk" and "fck".
 
@@ -38,6 +36,8 @@ ehrpwm0: pwm@1f00000 { /* EHRPWM on da850 */
 	compatible = "ti,da850-ehrpwm", "ti,am3352-ehrpwm";
 	#pwm-cells = <3>;
 	reg = <0x1f00000 0x2000>;
+	clocks = <&psc1 17>, <&ehrpwm_tbclk>;
+	clock-names = "fck", "tbclk";
 };
 
 ehrpwm0: pwm@4843e200 { /* EHRPWM on dra746 */
-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-05-26  8:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  8:43 [PATCH 0/4] dt-bindings: pwm: pwm-tiehrpwm: Convert to json schema Lokesh Vutla
2021-05-26  8:43 ` Lokesh Vutla
2021-05-26  8:43 ` [PATCH 1/4] arm: dts: ti: drop usage of redundant compatible Lokesh Vutla
2021-05-26  8:43   ` Lokesh Vutla
2021-05-31 11:17   ` Grygorii Strashko
2021-05-31 11:17     ` Grygorii Strashko
2021-05-31 11:31     ` Grygorii Strashko
2021-05-31 11:31       ` Grygorii Strashko
2021-06-01  5:32     ` Lokesh Vutla
2021-06-01  5:32       ` Lokesh Vutla
2021-05-26  8:43 ` Lokesh Vutla [this message]
2021-05-26  8:43   ` [PATCH 2/4] dt-bindings: pwm: tiehrpwm: Make clock and clock-names as required properties Lokesh Vutla
2021-05-31 11:21   ` Grygorii Strashko
2021-05-31 11:21     ` Grygorii Strashko
2021-05-26  8:43 ` [PATCH 3/4] dt-bindings: pwm: pwm-tiehrpwm: Convert to json schema Lokesh Vutla
2021-05-26  8:43   ` Lokesh Vutla
2021-05-26  8:43 ` [PATCH 4/4] dt-bindings: pwm: pwm-tiehrpwm: Add compatible string for AM64 SoC Lokesh Vutla
2021-05-26  8:43   ` Lokesh Vutla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210526084306.6534-3-lokeshvutla@ti.com \
    --to=lokeshvutla@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=nsekhar@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=tony@atomide.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.