Re: [PATCH] mm: generalize ZONE_[DMA|DMA32]

From: kernel test robot <lkp@intel.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org
Subject: Re: [PATCH] mm: generalize ZONE_[DMA|DMA32]
Date: Fri, 28 May 2021 01:06:47 +0800	[thread overview]
Message-ID: <202105280148.8ww1LG70-lkp@intel.com> (raw)
In-Reply-To: <20210527143047.123611-1-wangkefeng.wang@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 6084 bytes --]

Hi Kefeng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on arm64/for-next/core m68k/for-next s390/features linus/master v5.13-rc3]
[cannot apply to hnaz-linux-mm/master tip/x86/core sparc-next/master sparc/master next-20210527]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kefeng-Wang/mm-generalize-ZONE_-DMA-DMA32/20210527-222334
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/de626453e50ab17adeffd9602e997b4b67b80eb2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kefeng-Wang/mm-generalize-ZONE_-DMA-DMA32/20210527-222334
        git checkout de626453e50ab17adeffd9602e997b4b67b80eb2
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/slab.h:15,
                    from include/linux/crypto.h:20,
                    from arch/x86/kernel/asm-offsets.c:9:
>> include/linux/gfp.h:433:2: error: #error GFP_ZONES_SHIFT too large to create GFP_ZONE_TABLE integer
     433 | #error GFP_ZONES_SHIFT too large to create GFP_ZONE_TABLE integer
         |  ^~~~~
   include/linux/gfp.h: In function 'gfp_zone':
>> include/linux/gfp.h:444:20: warning: left shift count >= width of type [-Wshift-count-overflow]
     444 |  | (OPT_ZONE_DMA32 << (___GFP_MOVABLE | ___GFP_DMA32) * GFP_ZONES_SHIFT)\
         |                    ^~
   include/linux/gfp.h:469:7: note: in expansion of macro 'GFP_ZONE_TABLE'
     469 |  z = (GFP_ZONE_TABLE >> (bit * GFP_ZONES_SHIFT)) &
         |       ^~~~~~~~~~~~~~
--
   In file included from include/linux/slab.h:15,
                    from include/linux/crypto.h:20,
                    from arch/x86/kernel/asm-offsets.c:9:
>> include/linux/gfp.h:433:2: error: #error GFP_ZONES_SHIFT too large to create GFP_ZONE_TABLE integer
     433 | #error GFP_ZONES_SHIFT too large to create GFP_ZONE_TABLE integer
         |  ^~~~~
   include/linux/gfp.h: In function 'gfp_zone':
>> include/linux/gfp.h:444:20: warning: left shift count >= width of type [-Wshift-count-overflow]
     444 |  | (OPT_ZONE_DMA32 << (___GFP_MOVABLE | ___GFP_DMA32) * GFP_ZONES_SHIFT)\
         |                    ^~
   include/linux/gfp.h:469:7: note: in expansion of macro 'GFP_ZONE_TABLE'
     469 |  z = (GFP_ZONE_TABLE >> (bit * GFP_ZONES_SHIFT)) &
         |       ^~~~~~~~~~~~~~
   make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1227: prepare0] Error 2
   make[1]: Target 'modules_prepare' not remade because of errors.
   make: *** [Makefile:215: __sub-make] Error 2
   make: Target 'modules_prepare' not remade because of errors.
--
   In file included from include/linux/slab.h:15,
                    from include/linux/crypto.h:20,
                    from arch/x86/kernel/asm-offsets.c:9:
>> include/linux/gfp.h:433:2: error: #error GFP_ZONES_SHIFT too large to create GFP_ZONE_TABLE integer
     433 | #error GFP_ZONES_SHIFT too large to create GFP_ZONE_TABLE integer
         |  ^~~~~
   include/linux/gfp.h: In function 'gfp_zone':
>> include/linux/gfp.h:444:20: warning: left shift count >= width of type [-Wshift-count-overflow]
     444 |  | (OPT_ZONE_DMA32 << (___GFP_MOVABLE | ___GFP_DMA32) * GFP_ZONES_SHIFT)\
         |                    ^~
   include/linux/gfp.h:469:7: note: in expansion of macro 'GFP_ZONE_TABLE'
     469 |  z = (GFP_ZONE_TABLE >> (bit * GFP_ZONES_SHIFT)) &
         |       ^~~~~~~~~~~~~~
   make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1227: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:215: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.

vim +433 include/linux/gfp.h

b11a7b94100cba Dan Williams      2016-03-17  431  
b11a7b94100cba Dan Williams      2016-03-17  432  #if 16 * GFP_ZONES_SHIFT > BITS_PER_LONG
b11a7b94100cba Dan Williams      2016-03-17 @433  #error GFP_ZONES_SHIFT too large to create GFP_ZONE_TABLE integer
b70d94ee438b3f Christoph Lameter 2009-06-16  434  #endif
b70d94ee438b3f Christoph Lameter 2009-06-16  435  
b70d94ee438b3f Christoph Lameter 2009-06-16  436  #define GFP_ZONE_TABLE ( \
b11a7b94100cba Dan Williams      2016-03-17  437  	(ZONE_NORMAL << 0 * GFP_ZONES_SHIFT)				       \
b11a7b94100cba Dan Williams      2016-03-17  438  	| (OPT_ZONE_DMA << ___GFP_DMA * GFP_ZONES_SHIFT)		       \
b11a7b94100cba Dan Williams      2016-03-17  439  	| (OPT_ZONE_HIGHMEM << ___GFP_HIGHMEM * GFP_ZONES_SHIFT)	       \
b11a7b94100cba Dan Williams      2016-03-17  440  	| (OPT_ZONE_DMA32 << ___GFP_DMA32 * GFP_ZONES_SHIFT)		       \
b11a7b94100cba Dan Williams      2016-03-17  441  	| (ZONE_NORMAL << ___GFP_MOVABLE * GFP_ZONES_SHIFT)		       \
b11a7b94100cba Dan Williams      2016-03-17  442  	| (OPT_ZONE_DMA << (___GFP_MOVABLE | ___GFP_DMA) * GFP_ZONES_SHIFT)    \
b11a7b94100cba Dan Williams      2016-03-17  443  	| (ZONE_MOVABLE << (___GFP_MOVABLE | ___GFP_HIGHMEM) * GFP_ZONES_SHIFT)\
b11a7b94100cba Dan Williams      2016-03-17 @444  	| (OPT_ZONE_DMA32 << (___GFP_MOVABLE | ___GFP_DMA32) * GFP_ZONES_SHIFT)\
b70d94ee438b3f Christoph Lameter 2009-06-16  445  )
b70d94ee438b3f Christoph Lameter 2009-06-16  446  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65250 bytes --]