From: kernel test robot <lkp@intel.com>
To: David Gow <davidgow@google.com>,
Brendan Higgins <brendanhiggins@google.com>,
Alan Maguire <alan.maguire@oracle.com>
Cc: kbuild-all@lists.01.org, David Gow <davidgow@google.com>,
Daniel Latypov <dlatypov@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Marco Elver <elver@google.com>,
kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] kunit: Support skipped tests
Date: Fri, 28 May 2021 17:46:53 +0800 [thread overview]
Message-ID: <202105281723.w4PnpGWW-lkp@intel.com> (raw)
In-Reply-To: <20210528075932.347154-1-davidgow@google.com>
[-- Attachment #1: Type: text/plain, Size: 4865 bytes --]
Hi David,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.13-rc3 next-20210527]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/David-Gow/kunit-Support-skipped-tests/20210528-160224
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 97e5bf604b7a0d6e1b3e00fe31d5fd4b9bffeaae
config: i386-randconfig-s001-20210528 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/a464519206cd4484f64540020093cb45ef8e272e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review David-Gow/kunit-Support-skipped-tests/20210528-160224
git checkout a464519206cd4484f64540020093cb45ef8e272e
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
lib/kunit/debugfs.c:28:6: warning: no previous prototype for 'kunit_debugfs_cleanup' [-Wmissing-prototypes]
28 | void kunit_debugfs_cleanup(void)
| ^~~~~~~~~~~~~~~~~~~~~
lib/kunit/debugfs.c:33:6: warning: no previous prototype for 'kunit_debugfs_init' [-Wmissing-prototypes]
33 | void kunit_debugfs_init(void)
| ^~~~~~~~~~~~~~~~~~
lib/kunit/debugfs.c: In function 'debugfs_print_results':
lib/kunit/debugfs.c:67:6: error: implicit declaration of function 'kunit_status_to_string'; did you mean 'kunit_status_to_ok_not_ok'? [-Werror=implicit-function-declaration]
67 | kunit_status_to_string(success), 1, suite->name);
| ^~~~~~~~~~~~~~~~~~~~~~
| kunit_status_to_ok_not_ok
>> lib/kunit/debugfs.c:66:20: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat=]
66 | seq_printf(seq, "%s %d - %s\n",
| ~^
| |
| char *
| %d
67 | kunit_status_to_string(success), 1, suite->name);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
lib/kunit/debugfs.c: At top level:
lib/kunit/debugfs.c:92:6: warning: no previous prototype for 'kunit_debugfs_create_suite' [-Wmissing-prototypes]
92 | void kunit_debugfs_create_suite(struct kunit_suite *suite)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
lib/kunit/debugfs.c:108:6: warning: no previous prototype for 'kunit_debugfs_destroy_suite' [-Wmissing-prototypes]
108 | void kunit_debugfs_destroy_suite(struct kunit_suite *suite)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +66 lib/kunit/debugfs.c
e2219db280e3fe Alan Maguire 2020-03-26 48
e2219db280e3fe Alan Maguire 2020-03-26 49 /*
e2219db280e3fe Alan Maguire 2020-03-26 50 * /sys/kernel/debug/kunit/<testsuite>/results shows all results for testsuite.
e2219db280e3fe Alan Maguire 2020-03-26 51 */
e2219db280e3fe Alan Maguire 2020-03-26 52 static int debugfs_print_results(struct seq_file *seq, void *v)
e2219db280e3fe Alan Maguire 2020-03-26 53 {
e2219db280e3fe Alan Maguire 2020-03-26 54 struct kunit_suite *suite = (struct kunit_suite *)seq->private;
e2219db280e3fe Alan Maguire 2020-03-26 55 bool success = kunit_suite_has_succeeded(suite);
e2219db280e3fe Alan Maguire 2020-03-26 56 struct kunit_case *test_case;
e2219db280e3fe Alan Maguire 2020-03-26 57
e2219db280e3fe Alan Maguire 2020-03-26 58 if (!suite || !suite->log)
e2219db280e3fe Alan Maguire 2020-03-26 59 return 0;
e2219db280e3fe Alan Maguire 2020-03-26 60
e2219db280e3fe Alan Maguire 2020-03-26 61 seq_printf(seq, "%s", suite->log);
e2219db280e3fe Alan Maguire 2020-03-26 62
e2219db280e3fe Alan Maguire 2020-03-26 63 kunit_suite_for_each_test_case(suite, test_case)
e2219db280e3fe Alan Maguire 2020-03-26 64 debugfs_print_result(seq, suite, test_case);
e2219db280e3fe Alan Maguire 2020-03-26 65
e2219db280e3fe Alan Maguire 2020-03-26 @66 seq_printf(seq, "%s %d - %s\n",
e2219db280e3fe Alan Maguire 2020-03-26 67 kunit_status_to_string(success), 1, suite->name);
e2219db280e3fe Alan Maguire 2020-03-26 68 return 0;
e2219db280e3fe Alan Maguire 2020-03-26 69 }
e2219db280e3fe Alan Maguire 2020-03-26 70
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33379 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 1/4] kunit: Support skipped tests
Date: Fri, 28 May 2021 17:46:53 +0800 [thread overview]
Message-ID: <202105281723.w4PnpGWW-lkp@intel.com> (raw)
In-Reply-To: <20210528075932.347154-1-davidgow@google.com>
[-- Attachment #1: Type: text/plain, Size: 4956 bytes --]
Hi David,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.13-rc3 next-20210527]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/David-Gow/kunit-Support-skipped-tests/20210528-160224
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 97e5bf604b7a0d6e1b3e00fe31d5fd4b9bffeaae
config: i386-randconfig-s001-20210528 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/a464519206cd4484f64540020093cb45ef8e272e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review David-Gow/kunit-Support-skipped-tests/20210528-160224
git checkout a464519206cd4484f64540020093cb45ef8e272e
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
lib/kunit/debugfs.c:28:6: warning: no previous prototype for 'kunit_debugfs_cleanup' [-Wmissing-prototypes]
28 | void kunit_debugfs_cleanup(void)
| ^~~~~~~~~~~~~~~~~~~~~
lib/kunit/debugfs.c:33:6: warning: no previous prototype for 'kunit_debugfs_init' [-Wmissing-prototypes]
33 | void kunit_debugfs_init(void)
| ^~~~~~~~~~~~~~~~~~
lib/kunit/debugfs.c: In function 'debugfs_print_results':
lib/kunit/debugfs.c:67:6: error: implicit declaration of function 'kunit_status_to_string'; did you mean 'kunit_status_to_ok_not_ok'? [-Werror=implicit-function-declaration]
67 | kunit_status_to_string(success), 1, suite->name);
| ^~~~~~~~~~~~~~~~~~~~~~
| kunit_status_to_ok_not_ok
>> lib/kunit/debugfs.c:66:20: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat=]
66 | seq_printf(seq, "%s %d - %s\n",
| ~^
| |
| char *
| %d
67 | kunit_status_to_string(success), 1, suite->name);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
lib/kunit/debugfs.c: At top level:
lib/kunit/debugfs.c:92:6: warning: no previous prototype for 'kunit_debugfs_create_suite' [-Wmissing-prototypes]
92 | void kunit_debugfs_create_suite(struct kunit_suite *suite)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
lib/kunit/debugfs.c:108:6: warning: no previous prototype for 'kunit_debugfs_destroy_suite' [-Wmissing-prototypes]
108 | void kunit_debugfs_destroy_suite(struct kunit_suite *suite)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +66 lib/kunit/debugfs.c
e2219db280e3fe Alan Maguire 2020-03-26 48
e2219db280e3fe Alan Maguire 2020-03-26 49 /*
e2219db280e3fe Alan Maguire 2020-03-26 50 * /sys/kernel/debug/kunit/<testsuite>/results shows all results for testsuite.
e2219db280e3fe Alan Maguire 2020-03-26 51 */
e2219db280e3fe Alan Maguire 2020-03-26 52 static int debugfs_print_results(struct seq_file *seq, void *v)
e2219db280e3fe Alan Maguire 2020-03-26 53 {
e2219db280e3fe Alan Maguire 2020-03-26 54 struct kunit_suite *suite = (struct kunit_suite *)seq->private;
e2219db280e3fe Alan Maguire 2020-03-26 55 bool success = kunit_suite_has_succeeded(suite);
e2219db280e3fe Alan Maguire 2020-03-26 56 struct kunit_case *test_case;
e2219db280e3fe Alan Maguire 2020-03-26 57
e2219db280e3fe Alan Maguire 2020-03-26 58 if (!suite || !suite->log)
e2219db280e3fe Alan Maguire 2020-03-26 59 return 0;
e2219db280e3fe Alan Maguire 2020-03-26 60
e2219db280e3fe Alan Maguire 2020-03-26 61 seq_printf(seq, "%s", suite->log);
e2219db280e3fe Alan Maguire 2020-03-26 62
e2219db280e3fe Alan Maguire 2020-03-26 63 kunit_suite_for_each_test_case(suite, test_case)
e2219db280e3fe Alan Maguire 2020-03-26 64 debugfs_print_result(seq, suite, test_case);
e2219db280e3fe Alan Maguire 2020-03-26 65
e2219db280e3fe Alan Maguire 2020-03-26 @66 seq_printf(seq, "%s %d - %s\n",
e2219db280e3fe Alan Maguire 2020-03-26 67 kunit_status_to_string(success), 1, suite->name);
e2219db280e3fe Alan Maguire 2020-03-26 68 return 0;
e2219db280e3fe Alan Maguire 2020-03-26 69 }
e2219db280e3fe Alan Maguire 2020-03-26 70
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33379 bytes --]
next prev parent reply other threads:[~2021-05-28 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 7:59 [PATCH v2 1/4] kunit: Support skipped tests David Gow
2021-05-28 7:59 ` [PATCH v2 2/4] kunit: tool: Support skipped tests in kunit_tool David Gow
2021-06-01 15:46 ` Daniel Latypov
2021-06-04 21:30 ` Brendan Higgins
2021-06-04 21:44 ` Daniel Latypov
2021-05-28 7:59 ` [PATCH v2 3/4] kunit: test: Add example tests which are always skipped David Gow
2021-05-28 7:59 ` [PATCH v2 4/4] kasan: test: make use of kunit_skip() David Gow
2021-06-01 15:44 ` Daniel Latypov
2021-06-02 12:29 ` Andrey Konovalov
2021-05-28 9:46 ` kernel test robot [this message]
2021-05-28 9:46 ` [PATCH v2 1/4] kunit: Support skipped tests kernel test robot
2021-05-28 9:59 ` kernel test robot
2021-05-28 9:59 ` kernel test robot
2021-06-04 21:04 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202105281723.w4PnpGWW-lkp@intel.com \
--to=lkp@intel.com \
--cc=alan.maguire@oracle.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=elver@google.com \
--cc=kbuild-all@lists.01.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.