From: Roman Beranek <roman.beranek@prusa3d.cz>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Emil Lenngren <emil.lenngren@gmail.com>,
Pascal Roeleven <dev@pascalroeleven.nl>,
Lee Jones <lee.jones@linaro.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-sunxi@googlegroups.com
Subject: [PATCH 6/6] pwm: sun4i: don't delay if the PWM is already off
Date: Mon, 31 May 2021 06:46:08 +0200 [thread overview]
Message-ID: <20210531044608.1006024-7-roman.beranek@prusa3d.com> (raw)
In-Reply-To: <20210531044608.1006024-1-roman.beranek@prusa3d.com>
Signed-off-by: Roman Beranek <roman.beranek@prusa3d.com>
---
drivers/pwm/pwm-sun4i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
index 6ab06b9749d0..88bd90498d1f 100644
--- a/drivers/pwm/pwm-sun4i.c
+++ b/drivers/pwm/pwm-sun4i.c
@@ -304,7 +304,7 @@ static int sun4i_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
sun4i_pwm_writel(sun4i_pwm, ctrl, PWM_CTRL_REG);
- if (state->enabled) {
+ if (state->enabled || !cstate.enabled) {
mutex_unlock(&sun4i_pwm->ctrl_lock);
return 0;
}
--
2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Roman Beranek <roman.beranek@prusa3d.cz>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Emil Lenngren <emil.lenngren@gmail.com>,
Pascal Roeleven <dev@pascalroeleven.nl>,
Lee Jones <lee.jones@linaro.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-sunxi@googlegroups.com
Subject: [PATCH 6/6] pwm: sun4i: don't delay if the PWM is already off
Date: Mon, 31 May 2021 06:46:08 +0200 [thread overview]
Message-ID: <20210531044608.1006024-7-roman.beranek@prusa3d.com> (raw)
In-Reply-To: <20210531044608.1006024-1-roman.beranek@prusa3d.com>
Signed-off-by: Roman Beranek <roman.beranek@prusa3d.com>
---
drivers/pwm/pwm-sun4i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
index 6ab06b9749d0..88bd90498d1f 100644
--- a/drivers/pwm/pwm-sun4i.c
+++ b/drivers/pwm/pwm-sun4i.c
@@ -304,7 +304,7 @@ static int sun4i_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
sun4i_pwm_writel(sun4i_pwm, ctrl, PWM_CTRL_REG);
- if (state->enabled) {
+ if (state->enabled || !cstate.enabled) {
mutex_unlock(&sun4i_pwm->ctrl_lock);
return 0;
}
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-31 4:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 4:46 [PATCH 0/6] pwm: sun4i: only wait 2 cycles prior to disabling Roman Beranek
2021-05-31 4:46 ` Roman Beranek
2021-05-31 4:46 ` [PATCH 1/6] pwm: sun4i: enable clk prior to getting its rate Roman Beranek
2021-05-31 4:46 ` Roman Beranek
2021-06-07 8:00 ` Uwe Kleine-König
2021-06-07 8:00 ` Uwe Kleine-König
2021-05-31 4:46 ` [PATCH 2/6] pwm: sun4i: disable EN bit prior to the delay Roman Beranek
2021-05-31 4:46 ` Roman Beranek
2021-06-07 8:07 ` Uwe Kleine-König
2021-06-07 8:07 ` Uwe Kleine-König
2021-05-31 4:46 ` [PATCH 3/6] pwm: sun4i: replace spinlock with a mutex Roman Beranek
2021-05-31 4:46 ` Roman Beranek
2021-05-31 4:46 ` [PATCH 4/6] pwm: sun4i: simplify calculation of the delay time Roman Beranek
2021-05-31 4:46 ` Roman Beranek
2021-05-31 4:46 ` [PATCH 5/6] pwm: sun4i: shorten the delay to 2 cycles Roman Beranek
2021-05-31 4:46 ` Roman Beranek
2021-05-31 4:46 ` Roman Beranek [this message]
2021-05-31 4:46 ` [PATCH 6/6] pwm: sun4i: don't delay if the PWM is already off Roman Beranek
2021-06-10 13:41 ` Pascal Roeleven
2021-06-10 13:41 ` Pascal Roeleven
2021-05-31 19:07 ` [PATCH 0/6] pwm: sun4i: only wait 2 cycles prior to disabling Pascal Roeleven
2021-05-31 19:07 ` Pascal Roeleven
2021-05-31 20:01 ` Emil Lenngren
2021-05-31 20:01 ` Emil Lenngren
2021-05-31 20:20 ` Pascal Roeleven
2021-05-31 20:20 ` Pascal Roeleven
2021-06-08 12:28 ` Pascal Roeleven
2021-06-08 12:28 ` Pascal Roeleven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531044608.1006024-7-roman.beranek@prusa3d.com \
--to=roman.beranek@prusa3d.cz \
--cc=dev@pascalroeleven.nl \
--cc=emil.lenngren@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.