From: Lee Jones <lee.jones@linaro.org> To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Benjamin Gaignard <benjamin.gaignard@linaro.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Fabien Dessenne <fabien.dessenne@st.com>, dri-devel@lists.freedesktop.org Subject: [RESEND 06/26] drm/sti/sti_hda: Provide missing function names Date: Wed, 2 Jun 2021 15:32:40 +0100 [thread overview] Message-ID: <20210602143300.2330146-7-lee.jones@linaro.org> (raw) In-Reply-To: <20210602143300.2330146-1-lee.jones@linaro.org> Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/sti/sti_hda.c:283: warning: expecting prototype for Search for a video mode in the supported modes table(). Prototype was for hda_get_mode_idx() instead drivers/gpu/drm/sti/sti_hda.c:301: warning: expecting prototype for Enable the HD DACS(). Prototype was for hda_enable_hd_dacs() instead drivers/gpu/drm/sti/sti_hda.c:383: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Fabien Dessenne <fabien.dessenne@st.com> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/gpu/drm/sti/sti_hda.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c index 5c2b650b561d5..03f3377f918c0 100644 --- a/drivers/gpu/drm/sti/sti_hda.c +++ b/drivers/gpu/drm/sti/sti_hda.c @@ -272,7 +272,7 @@ static void hda_write(struct sti_hda *hda, u32 val, int offset) } /** - * Search for a video mode in the supported modes table + * hda_get_mode_idx - Search for a video mode in the supported modes table * * @mode: mode being searched * @idx: index of the found mode @@ -292,7 +292,7 @@ static bool hda_get_mode_idx(struct drm_display_mode mode, int *idx) } /** - * Enable the HD DACS + * hda_enable_hd_dacs - Enable the HD DACS * * @hda: pointer to HD analog structure * @enable: true if HD DACS need to be enabled, else false @@ -380,7 +380,7 @@ static void hda_debugfs_init(struct sti_hda *hda, struct drm_minor *minor) } /** - * Configure AWG, writing instructions + * sti_hda_configure_awg - Configure AWG, writing instructions * * @hda: pointer to HD analog structure * @awg_instr: pointer to AWG instructions table -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: lee.jones@linaro.org Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>, David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Fabien Dessenne <fabien.dessenne@st.com> Subject: [RESEND 06/26] drm/sti/sti_hda: Provide missing function names Date: Wed, 2 Jun 2021 15:32:40 +0100 [thread overview] Message-ID: <20210602143300.2330146-7-lee.jones@linaro.org> (raw) In-Reply-To: <20210602143300.2330146-1-lee.jones@linaro.org> Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/sti/sti_hda.c:283: warning: expecting prototype for Search for a video mode in the supported modes table(). Prototype was for hda_get_mode_idx() instead drivers/gpu/drm/sti/sti_hda.c:301: warning: expecting prototype for Enable the HD DACS(). Prototype was for hda_enable_hd_dacs() instead drivers/gpu/drm/sti/sti_hda.c:383: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Fabien Dessenne <fabien.dessenne@st.com> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/gpu/drm/sti/sti_hda.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c index 5c2b650b561d5..03f3377f918c0 100644 --- a/drivers/gpu/drm/sti/sti_hda.c +++ b/drivers/gpu/drm/sti/sti_hda.c @@ -272,7 +272,7 @@ static void hda_write(struct sti_hda *hda, u32 val, int offset) } /** - * Search for a video mode in the supported modes table + * hda_get_mode_idx - Search for a video mode in the supported modes table * * @mode: mode being searched * @idx: index of the found mode @@ -292,7 +292,7 @@ static bool hda_get_mode_idx(struct drm_display_mode mode, int *idx) } /** - * Enable the HD DACS + * hda_enable_hd_dacs - Enable the HD DACS * * @hda: pointer to HD analog structure * @enable: true if HD DACS need to be enabled, else false @@ -380,7 +380,7 @@ static void hda_debugfs_init(struct sti_hda *hda, struct drm_minor *minor) } /** - * Configure AWG, writing instructions + * sti_hda_configure_awg - Configure AWG, writing instructions * * @hda: pointer to HD analog structure * @awg_instr: pointer to AWG instructions table -- 2.31.1
next prev parent reply other threads:[~2021-06-02 14:33 UTC|newest] Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` [Nouveau] " Lee Jones 2021-06-02 14:32 ` [RESEND 01/26] drm/mediatek/mtk_disp_color: Strip incorrect doc and demote header Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` [RESEND 02/26] drm/mediatek/mtk_disp_gamma: Strip and demote non-conformant kernel-doc header Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` [RESEND 03/26] drm/mediatek/mtk_disp_ovl: Strip and demote non-conformant header Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` [RESEND 04/26] drm/mediatek/mtk_disp_rdma: Strip and demote non-conformant kernel-doc header Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` [RESEND 05/26] drm/sti/sti_hdmi_tx3g4c28phy: Provide function names for kernel-doc headers Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones [this message] 2021-06-02 14:32 ` [RESEND 06/26] drm/sti/sti_hda: Provide missing function names Lee Jones 2021-06-02 14:32 ` [RESEND 07/26] drm/sti/sti_tvout: Provide a bunch of " Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` [RESEND 08/26] drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()' Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` [RESEND 09/26] drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable 'cmd_enc' Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 17:26 ` [Freedreno] " abhinavk 2021-06-02 17:26 ` abhinavk 2021-06-02 14:32 ` [RESEND 10/26] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 17:33 ` [Freedreno] " abhinavk 2021-06-02 17:33 ` abhinavk 2021-06-04 8:32 ` Dmitry Baryshkov 2021-06-04 8:32 ` Dmitry Baryshkov 2021-06-04 8:57 ` Lee Jones 2021-06-04 8:57 ` Lee Jones 2021-06-02 14:32 ` [RESEND 11/26] drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 17:29 ` [Freedreno] " abhinavk 2021-06-02 17:29 ` abhinavk 2021-06-02 14:32 ` [RESEND 12/26] drm/msm/msm_gem: Demote kernel-doc abuses Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-04 0:49 ` Dmitry Baryshkov 2021-06-04 0:49 ` Dmitry Baryshkov 2021-06-02 14:32 ` [RESEND 13/26] drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog' Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 17:32 ` [Freedreno] " abhinavk 2021-06-02 17:32 ` abhinavk 2021-06-02 23:52 ` Stephen Boyd 2021-06-02 23:52 ` Stephen Boyd 2021-06-02 14:32 ` [RESEND 14/26] drm/msm/dp/dp_link: Fix some potential doc-rot Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-04 0:51 ` Dmitry Baryshkov 2021-06-04 0:51 ` Dmitry Baryshkov 2021-06-02 14:32 ` [RESEND 15/26] drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference static Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` [Nouveau] " Lee Jones 2021-06-02 14:32 ` [RESEND 16/26] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL, Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:46 ` Harry Wentland 2021-06-02 14:46 ` Harry Wentland 2021-06-02 14:46 ` Harry Wentland 2021-06-02 16:23 ` Alex Deucher 2021-06-02 16:23 ` Alex Deucher 2021-06-02 16:23 ` Alex Deucher 2021-06-02 17:37 ` Lee Jones 2021-06-02 17:37 ` Lee Jones 2021-06-02 17:37 ` Lee Jones 2021-06-02 14:32 ` [RESEND 17/26] drm/xlnx/zynqmp_disp: Fix incorrectly named enum 'zynqmp_disp_layer_id' Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 16:20 ` Laurent Pinchart 2021-06-02 16:20 ` Laurent Pinchart 2021-06-02 16:20 ` Laurent Pinchart 2021-06-03 11:30 ` Daniel Vetter 2021-06-03 11:30 ` Daniel Vetter 2021-06-03 11:30 ` Daniel Vetter 2021-06-02 14:32 ` [RESEND 18/26] drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()' Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 16:23 ` Laurent Pinchart 2021-06-02 16:23 ` Laurent Pinchart 2021-06-02 16:23 ` Laurent Pinchart 2021-06-02 17:38 ` Lee Jones 2021-06-02 17:38 ` Lee Jones 2021-06-02 17:38 ` Lee Jones 2021-06-02 14:32 ` [RESEND 19/26] drm/ttm/ttm_tt: Demote non-conformant kernel-doc header Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` [RESEND 20/26] drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` [RESEND 21/26] drm/panel/panel-sitronix-st7701: " Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` [RESEND 22/26] drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc format Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` [RESEND 23/26] drm/exynos/exynos7_drm_decon: Fix incorrect naming of 'decon_shadow_protect_win()' Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` [RESEND 24/26] drm/exynos/exynos_drm_ipp: Fix documentation for 'exynos_drm_ipp_get_{caps,res}_ioctl()' Lee Jones 2021-06-02 14:32 ` [RESEND 24/26] drm/exynos/exynos_drm_ipp: Fix documentation for 'exynos_drm_ipp_get_{caps, res}_ioctl()' Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:32 ` [RESEND 25/26] drm/vboxvideo/hgsmi_base: Place function names into headers Lee Jones 2021-06-02 14:32 ` Lee Jones 2021-06-02 14:33 ` [RESEND 26/26] drm/vboxvideo/modesetting: Provide function names for prototype headers Lee Jones 2021-06-02 14:33 ` Lee Jones 2021-06-03 11:34 ` [RESEND 00/26] Rid W=1 warnings from GPU Daniel Vetter 2021-06-03 11:34 ` Daniel Vetter 2021-06-03 11:34 ` Daniel Vetter 2021-06-03 11:34 ` Daniel Vetter 2021-06-03 11:34 ` [Nouveau] " Daniel Vetter 2021-06-03 11:52 ` Lee Jones 2021-06-03 11:52 ` Lee Jones 2021-06-03 11:52 ` Lee Jones 2021-06-03 11:52 ` Lee Jones 2021-06-03 11:52 ` [Nouveau] " Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210602143300.2330146-7-lee.jones@linaro.org \ --to=lee.jones@linaro.org \ --cc=airlied@linux.ie \ --cc=benjamin.gaignard@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=fabien.dessenne@st.com \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.