From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-i3c@lists.infradead.org>,
<alexandre.belloni@bootlin.com>
Subject: Re: [PATCH -next v2] i3c: master: svc: drop free_irq of devm_request_irq allocated irq
Date: Mon, 7 Jun 2021 08:22:55 +0200 [thread overview]
Message-ID: <20210607082255.5ab761b9@xps13> (raw)
In-Reply-To: <20210602084935.3977636-1-yangyingliang@huawei.com>
Hello,
Yang Yingliang <yangyingliang@huawei.com> wrote on Wed, 2 Jun 2021
16:49:35 +0800:
> irq allocated with devm_request_irq() will be freed in devm_irq_release(),
> using free_irq() in ->remove() will causes a dangling pointer, and a
> subsequent double free. So remove the free_irq() in svc_i3c_master_remove().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-i3c@lists.infradead.org>,
<alexandre.belloni@bootlin.com>
Subject: Re: [PATCH -next v2] i3c: master: svc: drop free_irq of devm_request_irq allocated irq
Date: Mon, 7 Jun 2021 08:22:55 +0200 [thread overview]
Message-ID: <20210607082255.5ab761b9@xps13> (raw)
In-Reply-To: <20210602084935.3977636-1-yangyingliang@huawei.com>
Hello,
Yang Yingliang <yangyingliang@huawei.com> wrote on Wed, 2 Jun 2021
16:49:35 +0800:
> irq allocated with devm_request_irq() will be freed in devm_irq_release(),
> using free_irq() in ->remove() will causes a dangling pointer, and a
> subsequent double free. So remove the free_irq() in svc_i3c_master_remove().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2021-06-07 6:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 8:49 [PATCH -next v2] i3c: master: svc: drop free_irq of devm_request_irq allocated irq Yang Yingliang
2021-06-02 8:49 ` Yang Yingliang
2021-06-07 6:22 ` Miquel Raynal [this message]
2021-06-07 6:22 ` Miquel Raynal
2021-06-09 0:03 ` Alexandre Belloni
2021-06-09 0:03 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210607082255.5ab761b9@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.