From: Maxime Ripard <maxime@cerno.tech>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: harry.wentland@amd.com, sunpeng.li@amd.com,
alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@linux.ie, daniel@ffwll.ch,
maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 4/7] drm/i915/display: Add handling for new "active bpc" property
Date: Thu, 10 Jun 2021 14:50:36 +0200 [thread overview]
Message-ID: <20210610125036.33fpnaoz4xpiqslw@gilmour> (raw)
In-Reply-To: <20210608174320.37429-5-wse@tuxedocomputers.com>
[-- Attachment #1: Type: text/plain, Size: 2539 bytes --]
Hi
On Tue, Jun 08, 2021 at 07:43:17PM +0200, Werner Sembach wrote:
> This commits implements the "active bpc" drm property for the Intel GPU driver.
>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++++++++++
> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++++++--
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 +++-
> drivers/gpu/drm/i915/display/intel_hdmi.c | 4 +++-
> 4 files changed, 26 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 64e9107d70f7..50c11b8770a7 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -10388,6 +10388,9 @@ static int intel_atomic_commit(struct drm_device *dev,
> {
> struct intel_atomic_state *state = to_intel_atomic_state(_state);
> struct drm_i915_private *dev_priv = to_i915(dev);
> + struct drm_connector *connector;
> + struct drm_connector_state *new_conn_state;
> + int i;
> int ret = 0;
>
> state->wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
> @@ -10456,6 +10459,17 @@ static int intel_atomic_commit(struct drm_device *dev,
> intel_shared_dpll_swap_state(state);
> intel_atomic_track_fbs(state);
>
> + /* Extract information from crtc to communicate it to userspace as connector properties */
> + for_each_new_connector_in_state(&state->base, connector, new_conn_state, i) {
> + struct intel_crtc *crtc = to_intel_crtc(new_conn_state->crtc);
> + if (crtc) {
> + struct intel_crtc_state *new_crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
> + new_conn_state->active_bpc = new_crtc_state->pipe_bpp / 3;
> + }
> + else
> + new_conn_state->active_bpc = 0;
> + }
> +
This seems fairly intrusive, but also commit / commit_tail might not be
the best place to put this, we want to support it at the connector
level.
Indeed, this will cause some issue if your HDMI output is a bridge for
example, where the commit will be in an entirely different driver that
has no dependency on the HDMI controller one.
I think it would be best to do that assignment in atomic_check. That
way, if the userspace does a commit with DRM_MODE_ATOMIC_TEST_ONLY it
would know what the output state would have been like.
Also, all of your patches don't follow the kernel coding style. Make
sure you fix the issues reported by checkpatch --strict
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: tzimmermann@suse.de, intel-gfx@lists.freedesktop.org,
sunpeng.li@amd.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, airlied@linux.ie,
amd-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com,
alexander.deucher@amd.com, christian.koenig@amd.com
Subject: Re: [PATCH v2 4/7] drm/i915/display: Add handling for new "active bpc" property
Date: Thu, 10 Jun 2021 14:50:36 +0200 [thread overview]
Message-ID: <20210610125036.33fpnaoz4xpiqslw@gilmour> (raw)
In-Reply-To: <20210608174320.37429-5-wse@tuxedocomputers.com>
[-- Attachment #1: Type: text/plain, Size: 2539 bytes --]
Hi
On Tue, Jun 08, 2021 at 07:43:17PM +0200, Werner Sembach wrote:
> This commits implements the "active bpc" drm property for the Intel GPU driver.
>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++++++++++
> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++++++--
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 +++-
> drivers/gpu/drm/i915/display/intel_hdmi.c | 4 +++-
> 4 files changed, 26 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 64e9107d70f7..50c11b8770a7 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -10388,6 +10388,9 @@ static int intel_atomic_commit(struct drm_device *dev,
> {
> struct intel_atomic_state *state = to_intel_atomic_state(_state);
> struct drm_i915_private *dev_priv = to_i915(dev);
> + struct drm_connector *connector;
> + struct drm_connector_state *new_conn_state;
> + int i;
> int ret = 0;
>
> state->wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
> @@ -10456,6 +10459,17 @@ static int intel_atomic_commit(struct drm_device *dev,
> intel_shared_dpll_swap_state(state);
> intel_atomic_track_fbs(state);
>
> + /* Extract information from crtc to communicate it to userspace as connector properties */
> + for_each_new_connector_in_state(&state->base, connector, new_conn_state, i) {
> + struct intel_crtc *crtc = to_intel_crtc(new_conn_state->crtc);
> + if (crtc) {
> + struct intel_crtc_state *new_crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
> + new_conn_state->active_bpc = new_crtc_state->pipe_bpp / 3;
> + }
> + else
> + new_conn_state->active_bpc = 0;
> + }
> +
This seems fairly intrusive, but also commit / commit_tail might not be
the best place to put this, we want to support it at the connector
level.
Indeed, this will cause some issue if your HDMI output is a bridge for
example, where the commit will be in an entirely different driver that
has no dependency on the HDMI controller one.
I think it would be best to do that assignment in atomic_check. That
way, if the userspace does a commit with DRM_MODE_ATOMIC_TEST_ONLY it
would know what the output state would have been like.
Also, all of your patches don't follow the kernel coding style. Make
sure you fix the issues reported by checkpatch --strict
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: tzimmermann@suse.de, intel-gfx@lists.freedesktop.org,
sunpeng.li@amd.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, airlied@linux.ie,
amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com,
harry.wentland@amd.com, christian.koenig@amd.com
Subject: Re: [Intel-gfx] [PATCH v2 4/7] drm/i915/display: Add handling for new "active bpc" property
Date: Thu, 10 Jun 2021 14:50:36 +0200 [thread overview]
Message-ID: <20210610125036.33fpnaoz4xpiqslw@gilmour> (raw)
In-Reply-To: <20210608174320.37429-5-wse@tuxedocomputers.com>
[-- Attachment #1.1: Type: text/plain, Size: 2539 bytes --]
Hi
On Tue, Jun 08, 2021 at 07:43:17PM +0200, Werner Sembach wrote:
> This commits implements the "active bpc" drm property for the Intel GPU driver.
>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++++++++++
> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++++++--
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 +++-
> drivers/gpu/drm/i915/display/intel_hdmi.c | 4 +++-
> 4 files changed, 26 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 64e9107d70f7..50c11b8770a7 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -10388,6 +10388,9 @@ static int intel_atomic_commit(struct drm_device *dev,
> {
> struct intel_atomic_state *state = to_intel_atomic_state(_state);
> struct drm_i915_private *dev_priv = to_i915(dev);
> + struct drm_connector *connector;
> + struct drm_connector_state *new_conn_state;
> + int i;
> int ret = 0;
>
> state->wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
> @@ -10456,6 +10459,17 @@ static int intel_atomic_commit(struct drm_device *dev,
> intel_shared_dpll_swap_state(state);
> intel_atomic_track_fbs(state);
>
> + /* Extract information from crtc to communicate it to userspace as connector properties */
> + for_each_new_connector_in_state(&state->base, connector, new_conn_state, i) {
> + struct intel_crtc *crtc = to_intel_crtc(new_conn_state->crtc);
> + if (crtc) {
> + struct intel_crtc_state *new_crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
> + new_conn_state->active_bpc = new_crtc_state->pipe_bpp / 3;
> + }
> + else
> + new_conn_state->active_bpc = 0;
> + }
> +
This seems fairly intrusive, but also commit / commit_tail might not be
the best place to put this, we want to support it at the connector
level.
Indeed, this will cause some issue if your HDMI output is a bridge for
example, where the commit will be in an entirely different driver that
has no dependency on the HDMI controller one.
I think it would be best to do that assignment in atomic_check. That
way, if the userspace does a commit with DRM_MODE_ATOMIC_TEST_ONLY it
would know what the output state would have been like.
Also, all of your patches don't follow the kernel coding style. Make
sure you fix the issues reported by checkpatch --strict
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: tzimmermann@suse.de, intel-gfx@lists.freedesktop.org,
sunpeng.li@amd.com, dri-devel@lists.freedesktop.org,
joonas.lahtinen@linux.intel.com,
maarten.lankhorst@linux.intel.com, linux-kernel@vger.kernel.org,
jani.nikula@linux.intel.com, airlied@linux.ie,
amd-gfx@lists.freedesktop.org, daniel@ffwll.ch,
rodrigo.vivi@intel.com, alexander.deucher@amd.com,
harry.wentland@amd.com, christian.koenig@amd.com
Subject: Re: [PATCH v2 4/7] drm/i915/display: Add handling for new "active bpc" property
Date: Thu, 10 Jun 2021 14:50:36 +0200 [thread overview]
Message-ID: <20210610125036.33fpnaoz4xpiqslw@gilmour> (raw)
In-Reply-To: <20210608174320.37429-5-wse@tuxedocomputers.com>
[-- Attachment #1.1: Type: text/plain, Size: 2539 bytes --]
Hi
On Tue, Jun 08, 2021 at 07:43:17PM +0200, Werner Sembach wrote:
> This commits implements the "active bpc" drm property for the Intel GPU driver.
>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++++++++++
> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++++++--
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 +++-
> drivers/gpu/drm/i915/display/intel_hdmi.c | 4 +++-
> 4 files changed, 26 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 64e9107d70f7..50c11b8770a7 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -10388,6 +10388,9 @@ static int intel_atomic_commit(struct drm_device *dev,
> {
> struct intel_atomic_state *state = to_intel_atomic_state(_state);
> struct drm_i915_private *dev_priv = to_i915(dev);
> + struct drm_connector *connector;
> + struct drm_connector_state *new_conn_state;
> + int i;
> int ret = 0;
>
> state->wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
> @@ -10456,6 +10459,17 @@ static int intel_atomic_commit(struct drm_device *dev,
> intel_shared_dpll_swap_state(state);
> intel_atomic_track_fbs(state);
>
> + /* Extract information from crtc to communicate it to userspace as connector properties */
> + for_each_new_connector_in_state(&state->base, connector, new_conn_state, i) {
> + struct intel_crtc *crtc = to_intel_crtc(new_conn_state->crtc);
> + if (crtc) {
> + struct intel_crtc_state *new_crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
> + new_conn_state->active_bpc = new_crtc_state->pipe_bpp / 3;
> + }
> + else
> + new_conn_state->active_bpc = 0;
> + }
> +
This seems fairly intrusive, but also commit / commit_tail might not be
the best place to put this, we want to support it at the connector
level.
Indeed, this will cause some issue if your HDMI output is a bridge for
example, where the commit will be in an entirely different driver that
has no dependency on the HDMI controller one.
I think it would be best to do that assignment in atomic_check. That
way, if the userspace does a commit with DRM_MODE_ATOMIC_TEST_ONLY it
would know what the output state would have been like.
Also, all of your patches don't follow the kernel coding style. Make
sure you fix the issues reported by checkpatch --strict
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-06-10 12:50 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 17:43 [PATCH 0/7] Add "activ bpc" and "active color format" drm property Werner Sembach
2021-06-08 17:43 ` Werner Sembach
2021-06-08 17:43 ` [Intel-gfx] " Werner Sembach
2021-06-08 17:43 ` [PATCH v2 1/7] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc Werner Sembach
2021-06-08 17:43 ` Werner Sembach
2021-06-08 17:43 ` [Intel-gfx] " Werner Sembach
2021-06-08 17:43 ` [PATCH v2 2/7] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property Werner Sembach
2021-06-08 17:43 ` Werner Sembach
2021-06-08 17:43 ` [Intel-gfx] " Werner Sembach
2021-06-10 7:55 ` Pekka Paalanen
2021-06-10 7:55 ` Pekka Paalanen
2021-06-10 7:55 ` [Intel-gfx] " Pekka Paalanen
2021-06-10 7:55 ` Pekka Paalanen
2021-06-14 15:59 ` Mario Kleiner
2021-06-14 15:59 ` Mario Kleiner
2021-06-14 15:59 ` [Intel-gfx] " Mario Kleiner
2021-06-14 15:59 ` Mario Kleiner
2021-06-08 17:43 ` [PATCH v2 3/7] drm/amd/display: Add handling for new "active bpc" property Werner Sembach
2021-06-08 17:43 ` Werner Sembach
2021-06-08 17:43 ` [Intel-gfx] " Werner Sembach
2021-06-08 17:43 ` [PATCH v2 4/7] drm/i915/display: " Werner Sembach
2021-06-08 17:43 ` Werner Sembach
2021-06-08 17:43 ` [Intel-gfx] " Werner Sembach
2021-06-10 12:50 ` Maxime Ripard [this message]
2021-06-10 12:50 ` Maxime Ripard
2021-06-10 12:50 ` [Intel-gfx] " Maxime Ripard
2021-06-10 12:50 ` Maxime Ripard
2021-06-10 13:59 ` Ville Syrjälä
2021-06-10 13:59 ` Ville Syrjälä
2021-06-10 13:59 ` [Intel-gfx] " Ville Syrjälä
2021-06-10 13:59 ` Ville Syrjälä
2021-06-08 17:43 ` [PATCH v2 5/7] drm/uAPI: Add "active color format" drm property as feedback for userspace Werner Sembach
2021-06-08 17:43 ` Werner Sembach
2021-06-08 17:43 ` [Intel-gfx] " Werner Sembach
2021-06-10 8:11 ` Pekka Paalanen
2021-06-10 8:11 ` Pekka Paalanen
2021-06-10 8:11 ` [Intel-gfx] " Pekka Paalanen
2021-06-10 8:11 ` Pekka Paalanen
2021-06-08 17:43 ` [PATCH v2 6/7] drm/amd/display: Add handling for new "active color format" property Werner Sembach
2021-06-08 17:43 ` Werner Sembach
2021-06-08 17:43 ` [Intel-gfx] " Werner Sembach
2021-06-08 17:43 ` [PATCH v2 7/7] drm/i915/display: " Werner Sembach
2021-06-08 17:43 ` Werner Sembach
2021-06-08 17:43 ` [Intel-gfx] " Werner Sembach
2021-06-08 19:01 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Add "activ bpc" and "active color format" drm property Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610125036.33fpnaoz4xpiqslw@gilmour \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=sunpeng.li@amd.com \
--cc=tzimmermann@suse.de \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.