From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Michal Simek <monstr@monstr.eu>,
Naga Sureshkumar Relli <nagasure@xilinx.com>,
Amit Kumar Mahapatra <akumarma@xilinx.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, helmut.grohne@intenta.de,
Srinivas Goud <sgoud@xilinx.com>,
Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Subject: Re: [PATCH v23 08/18] dt-binding: memory: pl353-smc: Enhance the description of the reg property
Date: Thu, 10 Jun 2021 10:53:45 -0500 [thread overview]
Message-ID: <20210610155345.GA1873816@robh.at.kernel.org> (raw)
In-Reply-To: <20210610082040.2075611-9-miquel.raynal@bootlin.com>
On Thu, Jun 10, 2021 at 10:20:30AM +0200, Miquel Raynal wrote:
> The SMC bus controller features several register sets. The one pointed
> by the reg property is for the SMC configuration (impacts the
> sub-controllers configuration), while the others are meant to be used to
> send regular cycles on the memory bus (eg. CMD, ADDR, DATA for a NAND
> device). Detail this a little bit for the sake of clarity.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> .../devicetree/bindings/memory-controllers/pl353-smc.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> index ecd46856f139..ba6a5426f62b 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> +++ b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> @@ -5,7 +5,8 @@ of memory interfaces: NAND and memory mapped interfaces (such as SRAM or NOR).
>
> Required properties:
> - compatible : Should be "arm,pl353-smc-r2p1", "arm,primecell".
> -- reg : Controller registers map and length.
> +- reg : SMC controller and sub-controllers configuration
> + registers.
I think you could just drop this patch. Otherwise, this doesn't match
what's now in the yaml file.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Michal Simek <monstr@monstr.eu>,
Naga Sureshkumar Relli <nagasure@xilinx.com>,
Amit Kumar Mahapatra <akumarma@xilinx.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, helmut.grohne@intenta.de,
Srinivas Goud <sgoud@xilinx.com>,
Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Subject: Re: [PATCH v23 08/18] dt-binding: memory: pl353-smc: Enhance the description of the reg property
Date: Thu, 10 Jun 2021 10:53:45 -0500 [thread overview]
Message-ID: <20210610155345.GA1873816@robh.at.kernel.org> (raw)
In-Reply-To: <20210610082040.2075611-9-miquel.raynal@bootlin.com>
On Thu, Jun 10, 2021 at 10:20:30AM +0200, Miquel Raynal wrote:
> The SMC bus controller features several register sets. The one pointed
> by the reg property is for the SMC configuration (impacts the
> sub-controllers configuration), while the others are meant to be used to
> send regular cycles on the memory bus (eg. CMD, ADDR, DATA for a NAND
> device). Detail this a little bit for the sake of clarity.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> .../devicetree/bindings/memory-controllers/pl353-smc.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> index ecd46856f139..ba6a5426f62b 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> +++ b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> @@ -5,7 +5,8 @@ of memory interfaces: NAND and memory mapped interfaces (such as SRAM or NOR).
>
> Required properties:
> - compatible : Should be "arm,pl353-smc-r2p1", "arm,primecell".
> -- reg : Controller registers map and length.
> +- reg : SMC controller and sub-controllers configuration
> + registers.
I think you could just drop this patch. Otherwise, this doesn't match
what's now in the yaml file.
Rob
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Michal Simek <monstr@monstr.eu>,
Naga Sureshkumar Relli <nagasure@xilinx.com>,
Amit Kumar Mahapatra <akumarma@xilinx.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, helmut.grohne@intenta.de,
Srinivas Goud <sgoud@xilinx.com>,
Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Subject: Re: [PATCH v23 08/18] dt-binding: memory: pl353-smc: Enhance the description of the reg property
Date: Thu, 10 Jun 2021 10:53:45 -0500 [thread overview]
Message-ID: <20210610155345.GA1873816@robh.at.kernel.org> (raw)
In-Reply-To: <20210610082040.2075611-9-miquel.raynal@bootlin.com>
On Thu, Jun 10, 2021 at 10:20:30AM +0200, Miquel Raynal wrote:
> The SMC bus controller features several register sets. The one pointed
> by the reg property is for the SMC configuration (impacts the
> sub-controllers configuration), while the others are meant to be used to
> send regular cycles on the memory bus (eg. CMD, ADDR, DATA for a NAND
> device). Detail this a little bit for the sake of clarity.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> .../devicetree/bindings/memory-controllers/pl353-smc.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> index ecd46856f139..ba6a5426f62b 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> +++ b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> @@ -5,7 +5,8 @@ of memory interfaces: NAND and memory mapped interfaces (such as SRAM or NOR).
>
> Required properties:
> - compatible : Should be "arm,pl353-smc-r2p1", "arm,primecell".
> -- reg : Controller registers map and length.
> +- reg : SMC controller and sub-controllers configuration
> + registers.
I think you could just drop this patch. Otherwise, this doesn't match
what's now in the yaml file.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-10 15:54 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 8:20 [PATCH v23 00/18] ARM Primecell PL35x support Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 01/18] dt-binding: memory: pl353-smc: Rephrase the binding Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 02/18] dt-binding: memory: pl353-smc: Document the range property Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 03/18] dt-binding: memory: pl353-smc: Drop the partitioning section Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 04/18] dt-binding: memory: pl353-smc: Describe the child reg property Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 05/18] dt-binding: memory: pl353-smc: Fix the example syntax and style Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 06/18] dt-binding: memory: pl353-smc: Drop unsupported nodes from the example Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 07/18] dt-binding: memory: pl353-smc: Fix the NAND controller node in " Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 08/18] dt-binding: memory: pl353-smc: Enhance the description of the reg property Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 15:53 ` Rob Herring [this message]
2021-06-10 15:53 ` Rob Herring
2021-06-10 15:53 ` Rob Herring
2021-06-10 16:01 ` Miquel Raynal
2021-06-10 16:01 ` Miquel Raynal
2021-06-10 16:01 ` Miquel Raynal
2021-06-10 21:12 ` Krzysztof Kozlowski
2021-06-10 21:12 ` Krzysztof Kozlowski
2021-06-10 21:12 ` Krzysztof Kozlowski
2021-06-10 8:20 ` [PATCH v23 09/18] dt-binding: memory: pl353-smc: Convert to yaml Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 15:44 ` Rob Herring
2021-06-10 15:44 ` Rob Herring
2021-06-10 15:44 ` Rob Herring
2021-06-10 8:20 ` [PATCH v23 10/18] memory: pl353-smc: Fix style Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 11/18] memory: pl353-smc: Rename goto labels Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 12/18] memory: pl353-smc: Let lower level controller drivers handle inits Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 13/18] memory: pl353-smc: Avoid useless acronyms in descriptions Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 14/18] memory: pl353-smc: Declare variables following a reverse christmas tree order Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 15/18] MAINTAINERS: Add PL353 SMC entry Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 16/18] MAINTAINERS: Add PL353 NAND controller entry Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-11 19:02 ` Miquel Raynal
2021-06-11 19:02 ` Miquel Raynal
2021-06-11 19:02 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 17/18] dt-bindings: mtd: pl353-nand: Describe this hardware controller Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:48 ` Krzysztof Kozlowski
2021-06-10 8:48 ` Krzysztof Kozlowski
2021-06-10 8:48 ` Krzysztof Kozlowski
2021-06-10 8:56 ` Miquel Raynal
2021-06-10 8:56 ` Miquel Raynal
2021-06-10 8:56 ` Miquel Raynal
2021-06-10 15:48 ` Rob Herring
2021-06-10 15:48 ` Rob Herring
2021-06-10 15:48 ` Rob Herring
2021-06-10 15:49 ` Rob Herring
2021-06-10 15:49 ` Rob Herring
2021-06-10 15:49 ` Rob Herring
2021-06-11 19:01 ` Miquel Raynal
2021-06-11 19:01 ` Miquel Raynal
2021-06-11 19:01 ` Miquel Raynal
2021-06-10 8:20 ` [PATCH v23 18/18] mtd: rawnand: pl353: Add support for the ARM PL353 SMC NAND controller Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-10 8:20 ` Miquel Raynal
2021-06-11 19:01 ` Miquel Raynal
2021-06-11 19:01 ` Miquel Raynal
2021-06-11 19:01 ` Miquel Raynal
2021-06-10 15:21 ` [PATCH v23 00/18] ARM Primecell PL35x support Krzysztof Kozlowski
2021-06-10 15:21 ` Krzysztof Kozlowski
2021-06-10 15:21 ` Krzysztof Kozlowski
2021-06-10 15:24 ` Krzysztof Kozlowski
2021-06-10 15:24 ` Krzysztof Kozlowski
2021-06-10 15:24 ` Krzysztof Kozlowski
2021-06-10 21:09 ` (subset) " Krzysztof Kozlowski
2021-06-10 21:09 ` Krzysztof Kozlowski
2021-06-10 21:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610155345.GA1873816@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Tudor.Ambarus@microchip.com \
--cc=akumarma@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=helmut.grohne@intenta.de \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=monstr@monstr.eu \
--cc=nagasure@xilinx.com \
--cc=richard@nod.at \
--cc=sgoud@xilinx.com \
--cc=sivadur@xilinx.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.