Re: [PATCH 1/3] drm/i915/guc: Add fetch of hwconfig table

From: kernel test robot <lkp@intel.com>
To: John.C.Harrison@Intel.com, Intel-GFX@Lists.FreeDesktop.Org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	kbuild-all@lists.01.org, DRI-Devel@Lists.FreeDesktop.Org,
	John Harrison <John.C.Harrison@Intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 1/3] drm/i915/guc: Add fetch of hwconfig table
Date: Wed, 16 Jun 2021 17:29:20 +0800	[thread overview]
Message-ID: <202106161748.SXUCsQ50-lkp@intel.com> (raw)
In-Reply-To: <20210610204626.2995262-2-John.C.Harrison@Intel.com>

[-- Attachment #1: Type: text/plain, Size: 2840 bytes --]

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20210615]
[cannot apply to v5.13-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/John-C-Harrison-Intel-com/Add-support-for-querying-hw-info-that-UMDs-need/20210616-141805
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/0006532f8f4a6f0ff36af11df58e8705af452e3c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review John-C-Harrison-Intel-com/Add-support-for-querying-hw-info-that-UMDs-need/20210616-141805
        git checkout 0006532f8f4a6f0ff36af11df58e8705af452e3c
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:19: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * GuC has a blob containing hardware configuration information (hwconfig).
   drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:125: warning: Function parameter or member 'hwconfig' not described in 'intel_guc_hwconfig_init'
   drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:160: warning: Function parameter or member 'hwconfig' not described in 'intel_guc_hwconfig_fini'

vim +19 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c

    17	
    18	/**
  > 19	 * GuC has a blob containing hardware configuration information (hwconfig).
    20	 * This is formatted as a simple and flexible KLV (Key/Length/Value) table.
    21	 *
    22	 * For example, a minimal version could be:
    23	 *   enum device_attr {
    24	 *     ATTR_SOME_VALUE = 0,
    25	 *     ATTR_SOME_MASK  = 1,
    26	 *   };
    27	 *
    28	 *   static const u32 hwconfig[] = {
    29	 *     ATTR_SOME_VALUE,
    30	 *     1,		// Value Length in DWords
    31	 *     8,		// Value
    32	 *
    33	 *     ATTR_SOME_MASK,
    34	 *     3,
    35	 *     0x00FFFFFFFF, 0xFFFFFFFF, 0xFF000000,
    36	 *   };
    37	 *
    38	 * The attribute ids are defined in a hardware spec. The current list as
    39	 * known to the i915 driver can be found in i915/gt/intel_guc_hwconfig_types.h
    40	 */
    41	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29242 bytes --]