From: Christoph Hellwig <hch@lst.de>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Al Viro <viro@zeniv.linux.org.uk>,
gmpy.liaowx@gmail.com, Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-doc@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] pstore/blk: Include zone in pstore_device_info
Date: Thu, 17 Jun 2021 09:57:45 +0200 [thread overview]
Message-ID: <20210617075745.GC899@lst.de> (raw)
In-Reply-To: <20210616164043.1221861-6-keescook@chromium.org>
On Wed, Jun 16, 2021 at 09:40:43AM -0700, Kees Cook wrote:
> Information was redundant between struct pstore_zone_info and struct
> pstore_device_info. Use struct pstore_zone_info, with member name "zone".
>
> Additionally untangle the logic for the "best effort" block device
> instance.
I'd still prefer to kill off struct pstore_device_info, but this is
already a huge improvement:
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Al Viro <viro@zeniv.linux.org.uk>,
gmpy.liaowx@gmail.com, Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-doc@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] pstore/blk: Include zone in pstore_device_info
Date: Thu, 17 Jun 2021 09:57:45 +0200 [thread overview]
Message-ID: <20210617075745.GC899@lst.de> (raw)
In-Reply-To: <20210616164043.1221861-6-keescook@chromium.org>
On Wed, Jun 16, 2021 at 09:40:43AM -0700, Kees Cook wrote:
> Information was redundant between struct pstore_zone_info and struct
> pstore_device_info. Use struct pstore_zone_info, with member name "zone".
>
> Additionally untangle the logic for the "best effort" block device
> instance.
I'd still prefer to kill off struct pstore_device_info, but this is
already a huge improvement:
Reviewed-by: Christoph Hellwig <hch@lst.de>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-06-17 7:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 16:40 [PATCH v3 0/5] Use the normal block device I/O path Kees Cook
2021-06-16 16:40 ` Kees Cook
2021-06-16 16:40 ` [PATCH v3 1/5] pstore/blk: Improve failure reporting Kees Cook
2021-06-16 16:40 ` Kees Cook
2021-06-17 7:55 ` Christoph Hellwig
2021-06-17 7:55 ` Christoph Hellwig
2021-06-16 16:40 ` [PATCH v3 2/5] pstore/blk: Move verify_size() macro out of function Kees Cook
2021-06-16 16:40 ` Kees Cook
2021-06-17 7:56 ` Christoph Hellwig
2021-06-17 7:56 ` Christoph Hellwig
2021-06-16 16:40 ` [PATCH v3 3/5] pstore/blk: Use the normal block device I/O path Kees Cook
2021-06-16 16:40 ` Kees Cook
2021-06-16 16:40 ` [PATCH v3 4/5] pstore/blk: Fix kerndoc and redundancy on blkdev param Kees Cook
2021-06-16 16:40 ` Kees Cook
2021-06-16 16:40 ` [PATCH v3 5/5] pstore/blk: Include zone in pstore_device_info Kees Cook
2021-06-16 16:40 ` Kees Cook
2021-06-17 7:57 ` Christoph Hellwig [this message]
2021-06-17 7:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617075745.GC899@lst.de \
--to=hch@lst.de \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=corbet@lwn.net \
--cc=gmpy.liaowx@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tony.luck@intel.com \
--cc=vigneshr@ti.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.