From: Nitesh Narayan Lal <nitesh@redhat.com>
To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-api@vger.kernel.org, linux-pci@vger.kernel.org,
tglx@linutronix.de, jesse.brandeburg@intel.com,
robin.murphy@arm.com, mtosatti@redhat.com, mingo@kernel.org,
jbrandeb@kernel.org, frederic@kernel.org, juri.lelli@redhat.com,
abelits@marvell.com, bhelgaas@google.com, rostedt@goodmis.org,
peterz@infradead.org, davem@davemloft.net,
akpm@linux-foundation.org, sfr@canb.auug.org.au,
stephen@networkplumber.org, rppt@linux.vnet.ibm.com,
chris.friesen@windriver.com, maz@kernel.org,
nhorman@tuxdriver.com, pjwaskiewicz@gmail.com,
sassmann@redhat.com, thenzl@redhat.com,
kashyap.desai@broadcom.com, sumit.saxena@broadcom.com,
shivasharan.srikanteshwara@broadcom.com,
sathya.prakash@broadcom.com, sreekanth.reddy@broadcom.com,
suganath-prabu.subramani@broadcom.com, james.smart@broadcom.com,
dick.kennedy@broadcom.com, jkc@redhat.com,
faisal.latif@intel.com, shiraz.saleem@intel.com,
tariqt@nvidia.com, ahleihel@redhat.com, kheib@redhat.com,
borisp@nvidia.com, saeedm@nvidia.com, benve@cisco.com,
govind@gmx.com, jassisinghbrar@gmail.com, luobin9@huawei.com,
ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com,
somnath.kotur@broadcom.com, nilal@redhat.com
Subject: [PATCH v1 12/14] hinic: Use irq_set_affinity_and_hint
Date: Thu, 17 Jun 2021 14:22:40 -0400 [thread overview]
Message-ID: <20210617182242.8637-13-nitesh@redhat.com> (raw)
In-Reply-To: <20210617182242.8637-1-nitesh@redhat.com>
The driver uses irq_set_affinity_hint() to:
- Set the affinity_hint which is consumed by the userspace for
distributing the interrupts
- Enforce affinity
As per commit 352f58b0d9f2 ("net-next/hinic: Set Rxq irq to specific cpu
for NUMA"), the hinic driver enforces its own affinity to bind IRQs to the
local NUMA node. However, irq_set_affinity_hint() applying the provided
cpumask as an affinity for the interrupt is an undocumented side effect.
To remove this side effect irq_set_affinity_hint() has been marked as
deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface
irq_set_affinity_and_hint() that applies the affinity and updates the
affinity_hint pointer. Also, use irq_update_affinity() when only
affinity_hint needs to be updated.
Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
---
drivers/net/ethernet/huawei/hinic/hinic_rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_rx.c b/drivers/net/ethernet/huawei/hinic/hinic_rx.c
index cce08647b9b2..c6cac4bbdb49 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_rx.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_rx.c
@@ -547,7 +547,7 @@ static int rx_request_irq(struct hinic_rxq *rxq)
goto err_req_irq;
cpumask_set_cpu(qp->q_id % num_online_cpus(), &rq->affinity_mask);
- err = irq_set_affinity_hint(rq->irq, &rq->affinity_mask);
+ err = irq_set_affinity_and_hint(rq->irq, &rq->affinity_mask);
if (err)
goto err_irq_affinity;
@@ -564,7 +564,7 @@ static void rx_free_irq(struct hinic_rxq *rxq)
{
struct hinic_rq *rq = rxq->rq;
- irq_set_affinity_hint(rq->irq, NULL);
+ irq_update_affinity_hint(rq->irq, NULL);
free_irq(rq->irq, rxq);
rx_del_napi(rxq);
}
--
2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Nitesh Narayan Lal <nitesh@redhat.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v1 12/14] hinic: Use irq_set_affinity_and_hint
Date: Thu, 17 Jun 2021 14:22:40 -0400 [thread overview]
Message-ID: <20210617182242.8637-13-nitesh@redhat.com> (raw)
In-Reply-To: <20210617182242.8637-1-nitesh@redhat.com>
The driver uses irq_set_affinity_hint() to:
- Set the affinity_hint which is consumed by the userspace for
distributing the interrupts
- Enforce affinity
As per commit 352f58b0d9f2 ("net-next/hinic: Set Rxq irq to specific cpu
for NUMA"), the hinic driver enforces its own affinity to bind IRQs to the
local NUMA node. However, irq_set_affinity_hint() applying the provided
cpumask as an affinity for the interrupt is an undocumented side effect.
To remove this side effect irq_set_affinity_hint() has been marked as
deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface
irq_set_affinity_and_hint() that applies the affinity and updates the
affinity_hint pointer. Also, use irq_update_affinity() when only
affinity_hint needs to be updated.
Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
---
drivers/net/ethernet/huawei/hinic/hinic_rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_rx.c b/drivers/net/ethernet/huawei/hinic/hinic_rx.c
index cce08647b9b2..c6cac4bbdb49 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_rx.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_rx.c
@@ -547,7 +547,7 @@ static int rx_request_irq(struct hinic_rxq *rxq)
goto err_req_irq;
cpumask_set_cpu(qp->q_id % num_online_cpus(), &rq->affinity_mask);
- err = irq_set_affinity_hint(rq->irq, &rq->affinity_mask);
+ err = irq_set_affinity_and_hint(rq->irq, &rq->affinity_mask);
if (err)
goto err_irq_affinity;
@@ -564,7 +564,7 @@ static void rx_free_irq(struct hinic_rxq *rxq)
{
struct hinic_rq *rq = rxq->rq;
- irq_set_affinity_hint(rq->irq, NULL);
+ irq_update_affinity_hint(rq->irq, NULL);
free_irq(rq->irq, rxq);
rx_del_napi(rxq);
}
--
2.27.0
next prev parent reply other threads:[~2021-06-17 18:25 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 18:22 [PATCH v1 00/14] genirq: Cleanup the usage of irq_set_affinity_hint Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 01/14] genirq: Provide new interfaces for affinity hints Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2021-06-25 17:52 ` Nitesh Lal
2021-06-25 17:52 ` [Intel-wired-lan] " Nitesh Lal
2021-06-17 18:22 ` [PATCH v1 02/14] iavf: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 03/14] i40e: " Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2021-06-17 19:31 ` Robin Murphy
2021-06-17 19:31 ` [Intel-wired-lan] " Robin Murphy
2021-06-17 19:34 ` Nitesh Lal
2021-06-17 19:34 ` [Intel-wired-lan] " Nitesh Lal
2021-06-17 18:22 ` [PATCH v1 05/14] scsi: mpt3sas: " Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 06/14] RDMA/i40iw: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 07/14] enic: " Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 08/14] be2net: " Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 09/14] ixgbe: " Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 10/14] mailbox: " Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 11/14] scsi: lpfc: Use irq_set_affinity Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2021-06-17 18:22 ` Nitesh Narayan Lal [this message]
2021-06-17 18:22 ` [Intel-wired-lan] [PATCH v1 12/14] hinic: Use irq_set_affinity_and_hint Nitesh Narayan Lal
2021-06-17 18:22 ` [PATCH v1 13/14] net/mlx5: Use irq_update_affinity_hint Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2021-06-21 8:01 ` Leon Romanovsky
2021-06-21 8:01 ` [Intel-wired-lan] " Leon Romanovsky
2021-06-17 18:22 ` [PATCH v1 14/14] net/mlx4: " Nitesh Narayan Lal
2021-06-17 18:22 ` [Intel-wired-lan] " Nitesh Narayan Lal
2021-06-21 8:01 ` Leon Romanovsky
2021-06-21 8:01 ` [Intel-wired-lan] " Leon Romanovsky
2021-06-21 12:59 ` Nitesh Lal
2021-06-21 12:59 ` [Intel-wired-lan] " Nitesh Lal
2021-06-25 21:08 ` Nitesh Lal
2021-06-25 21:08 ` [Intel-wired-lan] " Nitesh Lal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617182242.8637-13-nitesh@redhat.com \
--to=nitesh@redhat.com \
--cc=abelits@marvell.com \
--cc=ahleihel@redhat.com \
--cc=ajit.khaparde@broadcom.com \
--cc=akpm@linux-foundation.org \
--cc=benve@cisco.com \
--cc=bhelgaas@google.com \
--cc=borisp@nvidia.com \
--cc=chris.friesen@windriver.com \
--cc=davem@davemloft.net \
--cc=dick.kennedy@broadcom.com \
--cc=faisal.latif@intel.com \
--cc=frederic@kernel.org \
--cc=govind@gmx.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=james.smart@broadcom.com \
--cc=jassisinghbrar@gmail.com \
--cc=jbrandeb@kernel.org \
--cc=jesse.brandeburg@intel.com \
--cc=jkc@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=kashyap.desai@broadcom.com \
--cc=kheib@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luobin9@huawei.com \
--cc=maz@kernel.org \
--cc=mingo@kernel.org \
--cc=mtosatti@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=nilal@redhat.com \
--cc=peterz@infradead.org \
--cc=pjwaskiewicz@gmail.com \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=saeedm@nvidia.com \
--cc=sassmann@redhat.com \
--cc=sathya.prakash@broadcom.com \
--cc=sfr@canb.auug.org.au \
--cc=shiraz.saleem@intel.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=stephen@networkplumber.org \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=tariqt@nvidia.com \
--cc=tglx@linutronix.de \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.