Re: Re: [RESEND PATCH v4 06/10] dt-bindings: gpio: change items restriction of clock for rockchip, gpio-bank

From: "jay.xu@rock-chips.com" <jay.xu@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>, cl <cl@rock-chips.com>
Cc: robh+dt <robh+dt@kernel.org>, jagan <jagan@amarulasolutions.com>,
	wens <wens@csie.org>, uwe <uwe@kleine-koenig.org>,
	mail <mail@david-bauer.net>, "Johan Jonker" <jbx6244@gmail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	jensenhuang <jensenhuang@friendlyarm.com>,
	michael <michael@amarulasolutions.com>, cnsztl <cnsztl@gmail.com>,
	devicetree <devicetree@vger.kernel.org>,
	"ulf.hansson" <ulf.hansson@linaro.org>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	gregkh <gregkh@linuxfoundation.org>,
	linux-serial <linux-serial@vger.kernel.org>,
	linux-i2c <linux-i2c@vger.kernel.org>,
	"林涛(底层平台)" <shawn.lin@rock-chips.com>,
	吴达超 <david.wu@rock-chips.com>,
	zhangqing <zhangqing@rock-chips.com>,
	"Tao Huang" <huangtao@rock-chips.com>, cl <cl@rock-chips.com>,
	wim <wim@linux-watchdog.org>, linux <linux@roeck-us.net>,
	jamie <jamie@jamieiles.com>,
	linux-watchdog <linux-watchdog@vger.kernel.org>,
	maz <maz@kernel.org>
Subject: Re: Re: [RESEND PATCH v4 06/10] dt-bindings: gpio: change items restriction of clock for rockchip, gpio-bank
Date: Fri, 18 Jun 2021 14:41:45 +0800	[thread overview]
Message-ID: <2021061814414460293612@rock-chips.com> (raw)
In-Reply-To: 5026524.44csPzL39Z@phil

Hi Heiko

--------------
jay.xu@rock-chips.com
>Hi,
>
>Am Donnerstag, 13. Mai 2021, 08:46:06 CEST schrieb cl@rock-chips.com:
>> From: Liang Chen <cl@rock-chips.com>
>>
>> The clock property need 2 items on some rockchip chips.
>>
>> Signed-off-by: Liang Chen <cl@rock-chips.com>
>
>this patch should definitly move over to Jianquns gpio driver series,
>as it introduces the usage of these new clocks.
>
>Also while the single-clock variant definitly doesn't need it,
>I think we may want clock-names "apb_pclk", "debounce-ref" for the
>2-clock variants?
> 
Okay, I think it's very good idea, 
but is it possible to post the reg-name patch after these dts serial and gpio serial patches ?

>
>Heiko
>
>> ---
>>  Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
>> index d993e00..0d62c28 100644
>> --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
>> +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
>> @@ -22,7 +22,10 @@ properties:
>>      maxItems: 1
>> 
>>    clocks:
>> -    maxItems: 1
>> +    minItems: 1
>> +    items:
>> +      - description: APB interface clock source
>> +      - description: GPIO debounce reference clock source
>> 
>>    gpio-controller: true
>> 
>>
>
>
>
>
>
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip