From: ira.weiny@intel.com
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Ira Weiny <ira.weiny@intel.com>,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Doug Ledford <dledford@redhat.com>,
Faisal Latif <faisal.latif@intel.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Bernard Metzler <bmt@zurich.ibm.com>,
Kamal Heib <kheib@redhat.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH V2] RDMA/irdma: Remove use of kmap()
Date: Tue, 22 Jun 2021 09:56:22 -0700 [thread overview]
Message-ID: <20210622165622.2638628-1-ira.weiny@intel.com> (raw)
In-Reply-To: <20210622061422.2633501-3-ira.weiny@intel.com>
From: Ira Weiny <ira.weiny@intel.com>
kmap() is being deprecated and will break uses of device dax after PKS
protection is introduced.[1]
The kmap() used in the irdma CM driver is thread local. Therefore
kmap_local_page() is sufficient to use and may provide performance benefits
as well. kmap_local_page() will work with device dax and pgmap
protected pages.
Use kmap_local_page() instead of kmap().
[1] https://lore.kernel.org/lkml/20201009195033.3208459-59-ira.weiny@intel.com/
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
Changes for V2:
Move to the new irdma driver for 5.14
---
drivers/infiniband/hw/irdma/cm.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/irdma/cm.c b/drivers/infiniband/hw/irdma/cm.c
index 3d2bdb033a54..6b62299abfbb 100644
--- a/drivers/infiniband/hw/irdma/cm.c
+++ b/drivers/infiniband/hw/irdma/cm.c
@@ -3675,14 +3675,14 @@ int irdma_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
ibmr->device = iwpd->ibpd.device;
iwqp->lsmm_mr = ibmr;
if (iwqp->page)
- iwqp->sc_qp.qp_uk.sq_base = kmap(iwqp->page);
+ iwqp->sc_qp.qp_uk.sq_base = kmap_local_page(iwqp->page);
cm_node->lsmm_size = accept.size + conn_param->private_data_len;
irdma_sc_send_lsmm(&iwqp->sc_qp, iwqp->ietf_mem.va, cm_node->lsmm_size,
ibmr->lkey);
if (iwqp->page)
- kunmap(iwqp->page);
+ kunmap_local(iwqp->sc_qp.qp_uk.sq_base);
iwqp->cm_id = cm_id;
cm_node->cm_id = cm_id;
@@ -4093,10 +4093,10 @@ static void irdma_cm_event_connected(struct irdma_cm_event *event)
irdma_cm_init_tsa_conn(iwqp, cm_node);
read0 = (cm_node->send_rdma0_op == SEND_RDMA_READ_ZERO);
if (iwqp->page)
- iwqp->sc_qp.qp_uk.sq_base = kmap(iwqp->page);
+ iwqp->sc_qp.qp_uk.sq_base = kmap_local_page(iwqp->page);
irdma_sc_send_rtt(&iwqp->sc_qp, read0);
if (iwqp->page)
- kunmap(iwqp->page);
+ kunmap_local(iwqp->sc_qp.qp_uk.sq_base);
attr.qp_state = IB_QPS_RTS;
cm_node->qhash_set = false;
--
2.28.0.rc0.12.gb6a658bd00c9
next prev parent reply other threads:[~2021-06-22 16:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 6:14 [PATCH 0/4] Remove use of kmap() ira.weiny
2021-06-22 6:14 ` [PATCH 1/4] RDMA/hfi1: " ira.weiny
2021-06-24 18:13 ` Jason Gunthorpe
2021-06-22 6:14 ` [PATCH 2/4] RDMA/i40iw: " ira.weiny
2021-06-22 12:14 ` Jason Gunthorpe
2021-06-22 16:56 ` ira.weiny [this message]
2021-06-24 18:13 ` [PATCH V2] RDMA/irdma: " Jason Gunthorpe
2021-06-22 6:14 ` [PATCH 3/4] RDMA/siw: Remove kmap() ira.weiny
2021-07-15 18:00 ` Jason Gunthorpe
2021-06-22 6:14 ` [PATCH 4/4] RDMA/siw: Convert siw_tx_hdt() to kmap_local_page() ira.weiny
2021-06-22 20:34 ` [PATCH V2] " ira.weiny
2021-06-23 22:15 ` [PATCH V3] " ira.weiny
2021-06-24 17:48 ` [PATCH V4] " ira.weiny
2021-07-15 18:00 ` Jason Gunthorpe
2021-06-29 14:11 ` Bernard Metzler
2021-06-29 22:13 ` Ira Weiny
2021-06-24 15:45 ` [PATCH V3] " Bernard Metzler
2021-06-24 17:33 ` Ira Weiny
2021-06-23 14:36 ` [PATCH V2] " Bernard Metzler
2021-06-23 15:34 ` Ira Weiny
2021-06-22 16:42 ` [PATCH 4/4] " Bernard Metzler
2021-06-22 20:39 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210622165622.2638628-1-ira.weiny@intel.com \
--to=ira.weiny@intel.com \
--cc=bmt@zurich.ibm.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=jgg@ziepe.ca \
--cc=kheib@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.