Re: [PATCH 3/4] RDMA/siw: Remove kmap()

From: Jason Gunthorpe <jgg@nvidia.com>
To: ira.weiny@intel.com
Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
	Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
	Doug Ledford <dledford@redhat.com>,
	Faisal Latif <faisal.latif@intel.com>,
	Shiraz Saleem <shiraz.saleem@intel.com>,
	Bernard Metzler <bmt@zurich.ibm.com>,
	Kamal Heib <kheib@redhat.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] RDMA/siw: Remove kmap()
Date: Thu, 15 Jul 2021 15:00:36 -0300	[thread overview]
Message-ID: <20210715180036.GA667398@nvidia.com> (raw)
In-Reply-To: <20210622061422.2633501-4-ira.weiny@intel.com>

On Mon, Jun 21, 2021 at 11:14:21PM -0700, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> kmap() is being deprecated and will break uses of device dax after PKS
> protection is introduced.[1]
> 
> These uses of kmap() in the SIW driver are thread local.  Therefore
> kmap_local_page() is sufficient to use and will work with pgmap
> protected pages when those are implemnted.
> 
> There is one more use of kmap() in this driver which is split into its
> own patch because kmap_local_page() has strict ordering rules and the
> use of the kmap_mask over multiple segments must be handled carefully.
> Therefore, that conversion is handled in a stand alone patch.
> 
> Use kmap_local_page() instead of kmap() in the 'easy' cases.
> 
> [1] https://lore.kernel.org/lkml/20201009195033.3208459-59-ira.weiny@intel.com/
> 
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> ---
>  drivers/infiniband/sw/siw/siw_qp_tx.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)

Applied to for-next, thanks

Jason