Re: [PATCH v3 6/9] microblaze: use generic strncpy/strnlen from_user

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 6/9] microblaze: use generic strncpy/strnlen from_user
Date: Fri, 23 Jul 2021 04:48:38 +0800	[thread overview]
Message-ID: <202107230453.Cz16fInO-lkp@intel.com> (raw)
In-Reply-To: <20210722124814.778059-7-arnd@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 5475 bytes --]

Hi Arnd,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.14-rc2 next-20210722]
[cannot apply to asm-generic/master arc/for-next uclinux-h8/h8300-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Arnd-Bergmann/asm-generic-uaccess-h-remove-__strncpy_from_user-__strnlen_user/20210722-214839
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3d5895cd351757f69c9a66fb5fc8cf19f454d773
config: microblaze-buildonly-randconfig-r005-20210722 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/50efd0b2c40f098c1c02453d22bc3f3ef58d8a76
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Arnd-Bergmann/asm-generic-uaccess-h-remove-__strncpy_from_user-__strnlen_user/20210722-214839
        git checkout 50efd0b2c40f098c1c02453d22bc3f3ef58d8a76
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=microblaze SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   lib/strncpy_from_user.c: In function 'strncpy_from_user':
>> lib/strncpy_from_user.c:123:13: error: implicit declaration of function 'user_addr_max' [-Werror=implicit-function-declaration]
     123 |  max_addr = user_addr_max();
         |             ^~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
>> lib/strnlen_user.c:92:6: error: conflicting types for 'strnlen_user'
      92 | long strnlen_user(const char __user *str, long count)
         |      ^~~~~~~~~~~~
   In file included from include/linux/uaccess.h:11,
                    from lib/strnlen_user.c:4:
   arch/microblaze/include/asm/uaccess.h:306:13: note: previous declaration of 'strnlen_user' was here
     306 | extern long strnlen_user(const char __user *sstr, int len);
         |             ^~~~~~~~~~~~
   lib/strnlen_user.c: In function 'strnlen_user':
>> lib/strnlen_user.c:99:13: error: implicit declaration of function 'user_addr_max' [-Werror=implicit-function-declaration]
      99 |  max_addr = user_addr_max();
         |             ^~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/strnlen_user +92 lib/strnlen_user.c

a08c5356a3aaf6 Linus Torvalds    2012-05-26  70  
a08c5356a3aaf6 Linus Torvalds    2012-05-26  71  /**
a08c5356a3aaf6 Linus Torvalds    2012-05-26  72   * strnlen_user: - Get the size of a user string INCLUDING final NUL.
a08c5356a3aaf6 Linus Torvalds    2012-05-26  73   * @str: The string to measure.
a08c5356a3aaf6 Linus Torvalds    2012-05-26  74   * @count: Maximum count (including NUL character)
a08c5356a3aaf6 Linus Torvalds    2012-05-26  75   *
b3c395ef5556a6 David Hildenbrand 2015-05-11  76   * Context: User context only. This function may sleep if pagefaults are
b3c395ef5556a6 David Hildenbrand 2015-05-11  77   *          enabled.
a08c5356a3aaf6 Linus Torvalds    2012-05-26  78   *
a08c5356a3aaf6 Linus Torvalds    2012-05-26  79   * Get the size of a NUL-terminated string in user space.
a08c5356a3aaf6 Linus Torvalds    2012-05-26  80   *
a08c5356a3aaf6 Linus Torvalds    2012-05-26  81   * Returns the size of the string INCLUDING the terminating NUL.
226a07ef0a5a2d Jan Kara          2015-06-03  82   * If the string is too long, returns a number larger than @count. User
226a07ef0a5a2d Jan Kara          2015-06-03  83   * has to check the return value against "> count".
a08c5356a3aaf6 Linus Torvalds    2012-05-26  84   * On exception (or invalid count), returns 0.
226a07ef0a5a2d Jan Kara          2015-06-03  85   *
226a07ef0a5a2d Jan Kara          2015-06-03  86   * NOTE! You should basically never use this function. There is
226a07ef0a5a2d Jan Kara          2015-06-03  87   * almost never any valid case for using the length of a user space
226a07ef0a5a2d Jan Kara          2015-06-03  88   * string, since the string can be changed at any time by other
226a07ef0a5a2d Jan Kara          2015-06-03  89   * threads. Use "strncpy_from_user()" instead to get a stable copy
226a07ef0a5a2d Jan Kara          2015-06-03  90   * of the string.
a08c5356a3aaf6 Linus Torvalds    2012-05-26  91   */
a08c5356a3aaf6 Linus Torvalds    2012-05-26 @92  long strnlen_user(const char __user *str, long count)
a08c5356a3aaf6 Linus Torvalds    2012-05-26  93  {
a08c5356a3aaf6 Linus Torvalds    2012-05-26  94  	unsigned long max_addr, src_addr;
a08c5356a3aaf6 Linus Torvalds    2012-05-26  95  
a08c5356a3aaf6 Linus Torvalds    2012-05-26  96  	if (unlikely(count <= 0))
a08c5356a3aaf6 Linus Torvalds    2012-05-26  97  		return 0;
a08c5356a3aaf6 Linus Torvalds    2012-05-26  98  
a08c5356a3aaf6 Linus Torvalds    2012-05-26 @99  	max_addr = user_addr_max();

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33408 bytes --]