From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-arch@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Brian Cain <bcain@codeaurora.org>,
Chris Zankel <chris@zankel.net>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Christoph Hellwig <hch@lst.de>, Guo Ren <guoren@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>, Helge Deller <deller@gmx.de>,
Jeff Dike <jdike@addtoit.com>,
Linus Walleij <linus.walleij@linaro.org>,
Max Filippov <jcmvbkbc@gmail.com>,
Michal Simek <monstr@monstr.eu>,
Richard Weinberger <richard@nod.at>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Vasily Gorbik <gor@linux.ibm.com>,
Vineet Gupta <vgupta@synopsys.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org,
uclinux-h8-devel@lists.sourceforge.jp,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v3 7/9] asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user
Date: Thu, 22 Jul 2021 15:02:09 +0200 [thread overview]
Message-ID: <20210722130209.GG26225@lst.de> (raw)
In-Reply-To: <20210722124814.778059-8-arnd@kernel.org>
On Thu, Jul 22, 2021 at 02:48:12PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The inline version is used on three NOMMU architectures and is
> particularly inefficient when it scans the string one byte at a time
> twice. It also lacks a check for user_addr_max(), but this is
> probably ok on NOMMU targets.
>
> Consolidate the asm-generic implementation with the library version
> that is used everywhere else. This version is generalized enough to
> work efficiently on both MMU and NOMMU targets, and using the
> same code everywhere reduces the potential for subtle bugs.
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-arch@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Brian Cain <bcain@codeaurora.org>,
Chris Zankel <chris@zankel.net>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Christoph Hellwig <hch@lst.de>, Guo Ren <guoren@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>, Helge Deller <deller@gmx.de>,
Jeff Dike <jdike@addtoit.com>,
Linus Walleij <linus.walleij@linaro.org>,
Max Filippov <jcmvbkbc@gmail.com>,
Michal Simek <monstr@monstr.eu>,
Richard Weinberger <richard@nod.at>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Vasily Gorbik <gor@linux.ibm.com>,
Vineet Gupta <vgupta@synopsys.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org,
uclinux-h8-devel@lists.sourceforge.jp,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v3 7/9] asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user
Date: Thu, 22 Jul 2021 15:02:09 +0200 [thread overview]
Message-ID: <20210722130209.GG26225@lst.de> (raw)
In-Reply-To: <20210722124814.778059-8-arnd@kernel.org>
On Thu, Jul 22, 2021 at 02:48:12PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The inline version is used on three NOMMU architectures and is
> particularly inefficient when it scans the string one byte at a time
> twice. It also lacks a check for user_addr_max(), but this is
> probably ok on NOMMU targets.
>
> Consolidate the asm-generic implementation with the library version
> that is used everywhere else. This version is generalized enough to
> work efficiently on both MMU and NOMMU targets, and using the
> same code everywhere reduces the potential for subtle bugs.
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-arch@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Brian Cain <bcain@codeaurora.org>,
Chris Zankel <chris@zankel.net>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Christoph Hellwig <hch@lst.de>, Guo Ren <guoren@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>, Helge Deller <deller@gmx.de>,
Jeff Dike <jdike@addtoit.com>,
Linus Walleij <linus.walleij@linaro.org>,
Max Filippov <jcmvbkbc@gmail.com>,
Michal Simek <monstr@monstr.eu>,
Richard Weinberger <richard@nod.at>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Vasily Gorbik <gor@linux.ibm.com>,
Vineet Gupta <vgupta@synopsys.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org,
uclinux-h8-devel@lists.sourceforge.jp,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v3 7/9] asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user
Date: Thu, 22 Jul 2021 13:02:09 +0000 [thread overview]
Message-ID: <20210722130209.GG26225@lst.de> (raw)
In-Reply-To: <20210722124814.778059-8-arnd@kernel.org>
On Thu, Jul 22, 2021 at 02:48:12PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The inline version is used on three NOMMU architectures and is
> particularly inefficient when it scans the string one byte at a time
> twice. It also lacks a check for user_addr_max(), but this is
> probably ok on NOMMU targets.
>
> Consolidate the asm-generic implementation with the library version
> that is used everywhere else. This version is generalized enough to
> work efficiently on both MMU and NOMMU targets, and using the
> same code everywhere reduces the potential for subtle bugs.
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-arch@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Brian Cain <bcain@codeaurora.org>,
Chris Zankel <chris@zankel.net>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Christoph Hellwig <hch@lst.de>, Guo Ren <guoren@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>, Helge Deller <deller@gmx.de>,
Jeff Dike <jdike@addtoit.com>,
Linus Walleij <linus.walleij@linaro.org>,
Max Filippov <jcmvbkbc@gmail.com>,
Michal Simek <monstr@monstr.eu>,
Richard Weinberger <richard@nod.at>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Vasily Gorbik <gor@linux.ibm.com>,
Vineet Gupta <vgupta@synopsys.com>,
Yoshinori
Subject: Re: [PATCH v3 7/9] asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user
Date: Thu, 22 Jul 2021 15:02:09 +0200 [thread overview]
Message-ID: <20210722130209.GG26225@lst.de> (raw)
In-Reply-To: <20210722124814.778059-8-arnd@kernel.org>
On Thu, Jul 22, 2021 at 02:48:12PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The inline version is used on three NOMMU architectures and is
> particularly inefficient when it scans the string one byte at a time
> twice. It also lacks a check for user_addr_max(), but this is
> probably ok on NOMMU targets.
>
> Consolidate the asm-generic implementation with the library version
> that is used everywhere else. This version is generalized enough to
> work efficiently on both MMU and NOMMU targets, and using the
> same code everywhere reduces the potential for subtle bugs.
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-07-22 13:05 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 12:48 [PATCH v3 0/6] asm-generic: strncpy_from_user/strnlen_user cleanup Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` [PATCH v3 1/9] asm-generic/uaccess.h: remove __strncpy_from_user/__strnlen_user Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:59 ` Christoph Hellwig
2021-07-22 12:59 ` Christoph Hellwig
2021-07-22 12:59 ` Christoph Hellwig
2021-07-22 12:59 ` Christoph Hellwig
2021-07-22 12:48 ` [PATCH v3 2/9] h8300: remove stale strncpy_from_user Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:59 ` Christoph Hellwig
2021-07-22 12:59 ` Christoph Hellwig
2021-07-22 12:59 ` Christoph Hellwig
2021-07-22 12:59 ` Christoph Hellwig
2021-07-22 12:48 ` [PATCH v3 3/9] hexagon: use generic strncpy/strnlen from_user Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 13:00 ` Christoph Hellwig
2021-07-22 13:00 ` Christoph Hellwig
2021-07-22 13:00 ` Christoph Hellwig
2021-07-22 13:00 ` Christoph Hellwig
2021-07-22 12:48 ` [PATCH v3 4/9] arc: " Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 13:00 ` Christoph Hellwig
2021-07-22 13:00 ` Christoph Hellwig
2021-07-22 13:00 ` Christoph Hellwig
2021-07-22 13:00 ` Christoph Hellwig
2021-07-22 15:34 ` Vineet Gupta
2021-07-22 15:34 ` Vineet Gupta
2021-07-22 15:34 ` Vineet Gupta
2021-07-22 15:34 ` Vineet Gupta
2021-07-22 15:34 ` Vineet Gupta
2021-07-22 12:48 ` [PATCH v3 5/9] csky: " Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 13:01 ` Christoph Hellwig
2021-07-22 13:01 ` Christoph Hellwig
2021-07-22 13:01 ` Christoph Hellwig
2021-07-22 13:01 ` Christoph Hellwig
2021-07-22 12:48 ` [PATCH v3 6/9] microblaze: " Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 13:01 ` Christoph Hellwig
2021-07-22 13:01 ` Christoph Hellwig
2021-07-22 13:01 ` Christoph Hellwig
2021-07-22 13:01 ` Christoph Hellwig
2021-07-22 20:48 ` kernel test robot
2021-07-23 12:36 ` Arnd Bergmann
2021-07-23 12:36 ` Arnd Bergmann
2021-07-23 12:42 ` Christoph Hellwig
2021-07-23 12:42 ` Christoph Hellwig
2021-07-22 12:48 ` [PATCH v3 7/9] asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 13:02 ` Christoph Hellwig [this message]
2021-07-22 13:02 ` Christoph Hellwig
2021-07-22 13:02 ` Christoph Hellwig
2021-07-22 13:02 ` Christoph Hellwig
2021-07-22 12:48 ` [PATCH v3 8/9] asm-generic: remove extra strn{cpy_from,len}_user declarations Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` [PATCH v3 8/9] asm-generic: remove extra strn{cpy_from, len}_user declarations Arnd Bergmann
2021-07-22 13:02 ` [PATCH v3 8/9] asm-generic: remove extra strn{cpy_from,len}_user declarations Christoph Hellwig
2021-07-22 13:02 ` Christoph Hellwig
2021-07-22 13:02 ` Christoph Hellwig
2021-07-22 13:02 ` Christoph Hellwig
2021-07-22 12:48 ` [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM,STRNLEN}_USER symbols Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` Arnd Bergmann
2021-07-22 12:48 ` [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM, STRNLEN}_USER symbols Arnd Bergmann
2021-07-22 13:03 ` [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM,STRNLEN}_USER symbols Christoph Hellwig
2021-07-22 13:03 ` Christoph Hellwig
2021-07-22 13:03 ` Christoph Hellwig
2021-07-22 13:03 ` Christoph Hellwig
2021-07-22 13:57 ` [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM, STRNLEN}_USER symbols Johannes Berg
2021-07-22 13:57 ` Johannes Berg
2021-07-22 13:57 ` Johannes Berg
2021-07-22 13:57 ` Johannes Berg
2021-07-22 13:57 ` Johannes Berg
2021-07-22 14:01 ` Arnd Bergmann
2021-07-22 14:01 ` Arnd Bergmann
2021-07-22 14:01 ` Arnd Bergmann
2021-07-22 14:01 ` Arnd Bergmann
2021-07-22 14:01 ` Arnd Bergmann
2021-07-22 20:07 ` Heiko Carstens
2021-07-22 20:07 ` Heiko Carstens
2021-07-22 20:07 ` Heiko Carstens
2021-07-22 20:07 ` Heiko Carstens
2021-07-22 20:07 ` Heiko Carstens
2021-07-23 12:44 ` Arnd Bergmann
2021-07-23 12:44 ` Arnd Bergmann
2021-07-23 12:44 ` Arnd Bergmann
2021-07-23 12:44 ` Arnd Bergmann
2021-07-24 9:44 ` [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM,STRNLEN}_USER symbols Geert Uytterhoeven
2021-07-24 9:44 ` Geert Uytterhoeven
2021-07-24 9:44 ` Geert Uytterhoeven
2021-07-24 9:44 ` [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM, STRNLEN}_USER symbols Geert Uytterhoeven
2021-07-26 8:55 ` [PATCH v3 9/9] asm-generic: reverse GENERIC_{STRNCPY_FROM,STRNLEN}_USER symbols Helge Deller
2021-07-26 8:55 ` Helge Deller
2021-07-26 8:55 ` Helge Deller
2021-07-26 8:55 ` Helge Deller
2021-07-26 8:55 ` Helge Deller
2021-08-14 1:04 ` [PATCH v3 0/6] asm-generic: strncpy_from_user/strnlen_user cleanup Vineet Gupta
2021-08-14 11:10 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210722130209.GG26225@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bcain@codeaurora.org \
--cc=borntraeger@de.ibm.com \
--cc=chris@zankel.net \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=gor@linux.ibm.com \
--cc=guoren@kernel.org \
--cc=hca@linux.ibm.com \
--cc=jcmvbkbc@gmail.com \
--cc=jdike@addtoit.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=monstr@monstr.eu \
--cc=richard@nod.at \
--cc=tsbogend@alpha.franken.de \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=vgupta@synopsys.com \
--cc=viro@zeniv.linux.org.uk \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.