From: Mark Brown <broonie@kernel.org>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1 1/3] kselftest/arm64: Provide a helper binary and "library" for SVE RDVL
Date: Wed, 28 Jul 2021 11:20:35 +0100 [thread overview]
Message-ID: <20210728102035.GB4670@sirena.org.uk> (raw)
In-Reply-To: <20210728094117.GA1724@arm.com>
[-- Attachment #1: Type: text/plain, Size: 955 bytes --]
On Wed, Jul 28, 2021 at 10:41:30AM +0100, Dave Martin wrote:
> On Tue, Jul 27, 2021 at 07:06:47PM +0100, Mark Brown wrote:
> > SVE provides an instruction RDVL which reports the currently configured
> > vector length. In order to validate that our vector length configuration
> > interfaces are working correctly without having to build the C code for
> > +.globl rdvl_sve
> > +rdvl_sve:
> > + rdvl x0, #1
> > + ret
>
> This works, but can we use an ACLE intrinsic for this? I'm pretty GCC
> and LLVM have been up to date with that stuff for some time, though
> you'd have to check with the compiler folks.
If we put SVE into C source files we need to build the C code with SVE
support enabled, I felt it was safer to avoid any possibility that we
might get some interference with the tests due to interactions with SVE
code generated by the compiler. It should be fine, but it's even easier
to not have to think about it at all.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1 1/3] kselftest/arm64: Provide a helper binary and "library" for SVE RDVL
Date: Wed, 28 Jul 2021 11:20:35 +0100 [thread overview]
Message-ID: <20210728102035.GB4670@sirena.org.uk> (raw)
In-Reply-To: <20210728094117.GA1724@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 955 bytes --]
On Wed, Jul 28, 2021 at 10:41:30AM +0100, Dave Martin wrote:
> On Tue, Jul 27, 2021 at 07:06:47PM +0100, Mark Brown wrote:
> > SVE provides an instruction RDVL which reports the currently configured
> > vector length. In order to validate that our vector length configuration
> > interfaces are working correctly without having to build the C code for
> > +.globl rdvl_sve
> > +rdvl_sve:
> > + rdvl x0, #1
> > + ret
>
> This works, but can we use an ACLE intrinsic for this? I'm pretty GCC
> and LLVM have been up to date with that stuff for some time, though
> you'd have to check with the compiler folks.
If we put SVE into C source files we need to build the C code with SVE
support enabled, I felt it was safer to avoid any possibility that we
might get some interference with the tests due to interactions with SVE
code generated by the compiler. It should be fine, but it's even easier
to not have to think about it at all.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-28 10:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 18:06 [PATCH v1 0/3] kselftest/arm64: Vector length configuration tests Mark Brown
2021-07-27 18:06 ` Mark Brown
2021-07-27 18:06 ` [PATCH v1 1/3] kselftest/arm64: Provide a helper binary and "library" for SVE RDVL Mark Brown
2021-07-27 18:06 ` Mark Brown
2021-07-28 9:41 ` Dave Martin
2021-07-28 9:41 ` Dave Martin
2021-07-28 10:20 ` Mark Brown [this message]
2021-07-28 10:20 ` Mark Brown
2021-07-28 10:45 ` Dave Martin
2021-07-28 10:45 ` Dave Martin
2021-07-27 18:06 ` [PATCH v1 2/3] kselftest/arm64: Validate vector lengths are set in sve-probe-vls Mark Brown
2021-07-27 18:06 ` Mark Brown
2021-07-28 9:41 ` Dave Martin
2021-07-28 9:41 ` Dave Martin
2021-07-28 11:07 ` Mark Brown
2021-07-28 11:07 ` Mark Brown
2021-07-28 11:35 ` Dave Martin
2021-07-28 11:35 ` Dave Martin
2021-07-27 18:06 ` [PATCH v1 3/3] kselftest/arm64: Add tests for SVE vector configuration Mark Brown
2021-07-27 18:06 ` Mark Brown
2021-07-28 9:41 ` Dave Martin
2021-07-28 9:41 ` Dave Martin
2021-07-28 12:59 ` Mark Brown
2021-07-28 12:59 ` Mark Brown
2021-07-28 13:44 ` Dave Martin
2021-07-28 13:44 ` Dave Martin
2021-07-28 16:29 ` Mark Brown
2021-07-28 16:29 ` Mark Brown
2021-07-28 16:37 ` Dave Martin
2021-07-28 16:37 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728102035.GB4670@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Dave.Martin@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.