From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: David Airlie <airlied@linux.ie>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Jonathan Corbet <corbet@lwn.net>, Daniel Vetter <daniel@ffwll.ch>,
Diana Craciun <diana.craciun@oss.nxp.com>,
dri-devel@lists.freedesktop.org,
Eric Auger <eric.auger@redhat.com>,
Eric Farman <farman@linux.ibm.com>,
Harald Freudenberger <freude@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Jason Herne <jjherne@linux.ibm.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
kvm@vger.kernel.org, Kirti Wankhede <kwankhede@nvidia.com>,
linux-doc@vger.kernel.org, linux-s390@vger.kernel.org,
Matthew Rosato <mjrosato@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Zhi Wang <zhi.a.wang@intel.com>,
"Raj, Ashok" <ashok.raj@intel.com>,
Christoph Hellwig <hch@lst.de>,
Leon Romanovsky <leonro@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Yishai Hadas <yishaih@nvidia.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>
Subject: Re: [PATCH v3 04/14] vfio: Provide better generic support for open/release vfio_device_ops
Date: Thu, 29 Jul 2021 09:26:09 +0200 [thread overview]
Message-ID: <20210729072609.GD31896@lst.de> (raw)
In-Reply-To: <4-v3-6c9e19cc7d44+15613-vfio_reflck_jgg@nvidia.com>
> + device->open_count++;
> + if (device->open_count == 1 && device->ops->open_device) {
I would have written this as
if (++device->open_count == 1 && device->ops->open_device) {
to make the pattern more clear, but that is just a minor nitpick.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Kirti Wankhede <kwankhede@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Diana Craciun <diana.craciun@oss.nxp.com>,
Leon Romanovsky <leonro@nvidia.com>,
Christoph Hellwig <hch@lst.de>,
linux-s390@vger.kernel.org,
Matthew Rosato <mjrosato@linux.ibm.com>,
Jonathan Corbet <corbet@lwn.net>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
intel-gfx@lists.freedesktop.org,
Jason Herne <jjherne@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Eric Auger <eric.auger@redhat.com>,
Harald Freudenberger <freude@linux.ibm.com>,
intel-gvt-dev@lists.freedesktop.org, "Raj,
Ashok" <ashok.raj@intel.com>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Yishai Hadas <yishaih@nvidia.com>,
Cornelia Huck <cohuck@redhat.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>
Subject: Re: [Intel-gfx] [PATCH v3 04/14] vfio: Provide better generic support for open/release vfio_device_ops
Date: Thu, 29 Jul 2021 09:26:09 +0200 [thread overview]
Message-ID: <20210729072609.GD31896@lst.de> (raw)
In-Reply-To: <4-v3-6c9e19cc7d44+15613-vfio_reflck_jgg@nvidia.com>
> + device->open_count++;
> + if (device->open_count == 1 && device->ops->open_device) {
I would have written this as
if (++device->open_count == 1 && device->ops->open_device) {
to make the pattern more clear, but that is just a minor nitpick.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-07-29 7:26 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 0:49 [PATCH v3 00/14] Provide core infrastructure for managing open/release Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-07-29 0:49 ` [PATCH v3 01/14] vfio/samples: Remove module get/put Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-07-29 0:49 ` [PATCH v3 02/14] vfio/mbochs: Fix missing error unwind of mbochs_used_mbytes Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-07-29 5:59 ` kernel test robot
2021-07-29 9:38 ` Dan Carpenter
2021-07-29 9:38 ` Dan Carpenter
2021-07-29 12:09 ` Jason Gunthorpe
2021-07-29 12:09 ` Jason Gunthorpe
2021-07-29 7:21 ` Christoph Hellwig
2021-07-29 7:21 ` [Intel-gfx] " Christoph Hellwig
2021-07-29 0:49 ` [PATCH v3 03/14] vfio: Introduce a vfio_uninit_group_dev() API call Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-07-29 0:49 ` [PATCH v3 04/14] vfio: Provide better generic support for open/release vfio_device_ops Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-07-29 7:26 ` Christoph Hellwig [this message]
2021-07-29 7:26 ` [Intel-gfx] " Christoph Hellwig
2021-07-29 0:49 ` [PATCH v3 05/14] vfio/samples: Delete useless open/close Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-07-29 0:49 ` [PATCH v3 06/14] vfio/fsl: Move to the device set infrastructure Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-07-29 0:49 ` [PATCH v3 07/14] vfio/platform: Use open_device() instead of open coding a refcnt scheme Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-08-05 12:37 ` Eric Auger
2021-08-05 12:37 ` [Intel-gfx] " Eric Auger
2021-07-29 0:49 ` [PATCH v3 08/14] vfio/pci: Move to the device set infrastructure Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-07-29 0:49 ` [PATCH v3 09/14] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-07-29 7:30 ` Christoph Hellwig
2021-07-29 7:30 ` [Intel-gfx] " Christoph Hellwig
2021-08-03 16:34 ` Alex Williamson
2021-08-03 16:34 ` [Intel-gfx] " Alex Williamson
2021-08-03 16:41 ` Jason Gunthorpe
2021-08-03 16:41 ` [Intel-gfx] " Jason Gunthorpe
2021-08-03 16:52 ` Alex Williamson
2021-08-03 16:52 ` [Intel-gfx] " Alex Williamson
2021-08-05 11:47 ` Jason Gunthorpe
2021-08-05 11:47 ` [Intel-gfx] " Jason Gunthorpe
2021-08-05 17:33 ` Alex Williamson
2021-08-05 17:33 ` [Intel-gfx] " Alex Williamson
2021-08-05 23:05 ` Jason Gunthorpe
2021-08-05 23:05 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` [PATCH v3 10/14] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-07-29 0:49 ` [PATCH v3 11/14] vfio/mbochs: Fix close when multiple device FDs are open Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-07-29 0:49 ` [PATCH v3 12/14] vfio/ap,ccw: Fix open/close " Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] [PATCH v3 12/14] vfio/ap, ccw: " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-07-29 0:49 ` [PATCH v3 13/14] vfio/gvt: " Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-07-29 0:49 ` [PATCH v3 14/14] vfio: Remove struct vfio_device_ops open/release Jason Gunthorpe
2021-07-29 0:49 ` [Intel-gfx] " Jason Gunthorpe
2021-07-29 0:49 ` Jason Gunthorpe
2021-07-29 2:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Provide core infrastructure for managing open/release (rev7) Patchwork
2021-07-29 2:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-29 8:16 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-08-05 14:26 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Provide core infrastructure for managing open/release (rev8) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729072609.GD31896@lst.de \
--to=hch@lst.de \
--cc=airlied@linux.ie \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=diana.craciun@oss.nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric.auger@redhat.com \
--cc=farman@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=jjherne@linux.ibm.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=mjrosato@linux.ibm.com \
--cc=oberpar@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=rodrigo.vivi@intel.com \
--cc=vneethv@linux.ibm.com \
--cc=yishaih@nvidia.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.