From: Miquel Raynal <miquel.raynal@bootlin.com> To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Cc: Ezequiel Garcia <ezequiel@collabora.com>, linux-mtd <linux-mtd@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com> Subject: Re: [PATCH 3/3] mtdblock: Warn if the added for a NAND device Date: Tue, 17 Aug 2021 18:49:13 +0200 [thread overview] Message-ID: <20210817184913.5162b242@xps13> (raw) In-Reply-To: <CAAEAJfDqEu0XtZ_FvVUM31p5PumPmK0x-r8sFWXzENDqf5zj_g@mail.gmail.com> Hi Ezequiel, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote on Tue, 17 Aug 2021 13:27:54 -0300: > Bonjour Miquel, > > On Fri, 6 Aug 2021 at 17:05, Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > > On Sun, 2021-08-01 at 23:45:09 UTC, Ezequiel Garcia wrote: > > > There is a surprisingly large number of tutorials > > > that suggest using mtdblock to mount SquashFS filesystems > > > on flash devices, including NAND devices. > > > > > > This approach is suboptimal than using UBI. If the flash device > > > is NAND, this is specially true, due to wear leveling, bit-flips and > > > badblocks. In this case UBI is strongly preferred, so be nice to users > > > and print a warning suggesting to consider UBI block, if mtdblock > > > is added for a NAND device. > > > > > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > > > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. > > > > Any chance you respin this one? > > It appears somehow this made its way to the patch: > "Untracked files not listed" sorry about that -- could you remove it? Yeah no problem about that, it happens ;) > While there, you can fix the typo in the commit title: > "mtdblock: Warn if the added for a NAND device" -> "mtdblock: Warn if > added for a NAND device" Done as well. Cheers! Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Cc: Ezequiel Garcia <ezequiel@collabora.com>, linux-mtd <linux-mtd@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com> Subject: Re: [PATCH 3/3] mtdblock: Warn if the added for a NAND device Date: Tue, 17 Aug 2021 18:49:13 +0200 [thread overview] Message-ID: <20210817184913.5162b242@xps13> (raw) In-Reply-To: <CAAEAJfDqEu0XtZ_FvVUM31p5PumPmK0x-r8sFWXzENDqf5zj_g@mail.gmail.com> Hi Ezequiel, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote on Tue, 17 Aug 2021 13:27:54 -0300: > Bonjour Miquel, > > On Fri, 6 Aug 2021 at 17:05, Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > > On Sun, 2021-08-01 at 23:45:09 UTC, Ezequiel Garcia wrote: > > > There is a surprisingly large number of tutorials > > > that suggest using mtdblock to mount SquashFS filesystems > > > on flash devices, including NAND devices. > > > > > > This approach is suboptimal than using UBI. If the flash device > > > is NAND, this is specially true, due to wear leveling, bit-flips and > > > badblocks. In this case UBI is strongly preferred, so be nice to users > > > and print a warning suggesting to consider UBI block, if mtdblock > > > is added for a NAND device. > > > > > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > > > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. > > > > Any chance you respin this one? > > It appears somehow this made its way to the patch: > "Untracked files not listed" sorry about that -- could you remove it? Yeah no problem about that, it happens ;) > While there, you can fix the typo in the commit title: > "mtdblock: Warn if the added for a NAND device" -> "mtdblock: Warn if > added for a NAND device" Done as well. Cheers! Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-08-17 16:49 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-01 23:45 [PATCH 0/3] mtdblock: Advertise about UBI and UBI block Ezequiel Garcia 2021-08-01 23:45 ` Ezequiel Garcia 2021-08-01 23:45 ` [PATCH 1/3] mtdblock: Update old JFFS2 mention in Kconfig Ezequiel Garcia 2021-08-01 23:45 ` Ezequiel Garcia 2021-08-01 23:45 ` [PATCH 2/3] mtdblock: Add comment about UBI block devices Ezequiel Garcia 2021-08-01 23:45 ` Ezequiel Garcia 2021-08-01 23:45 ` [PATCH 3/3] mtdblock: Warn if the added for a NAND device Ezequiel Garcia 2021-08-01 23:45 ` Ezequiel Garcia 2021-08-01 23:45 ` [PATCH 0/3] mtdblock: Advertise about UBI and UBI block Ezequiel Garcia 2021-08-01 23:45 ` Ezequiel Garcia 2021-08-01 23:45 ` [PATCH 1/3] mtdblock: Update old JFFS2 mention in Kconfig Ezequiel Garcia 2021-08-01 23:45 ` Ezequiel Garcia 2021-08-06 20:05 ` Miquel Raynal 2021-08-06 20:05 ` Miquel Raynal 2021-08-01 23:45 ` [PATCH 2/3] mtdblock: Add comment about UBI block devices Ezequiel Garcia 2021-08-01 23:45 ` Ezequiel Garcia 2021-08-06 20:05 ` Miquel Raynal 2021-08-06 20:05 ` Miquel Raynal 2021-08-01 23:45 ` [PATCH 3/3] mtdblock: Warn if the added for a NAND device Ezequiel Garcia 2021-08-01 23:45 ` Ezequiel Garcia 2021-08-06 20:05 ` Miquel Raynal 2021-08-06 20:05 ` Miquel Raynal 2021-08-17 16:27 ` Ezequiel Garcia 2021-08-17 16:27 ` Ezequiel Garcia 2021-08-17 16:49 ` Miquel Raynal [this message] 2021-08-17 16:49 ` Miquel Raynal 2021-10-26 15:03 ` [PATCH 0/3] mtdblock: Advertise about UBI and UBI block Trevor Woerner 2021-10-26 15:03 ` Trevor Woerner 2021-10-26 19:01 ` Richard Weinberger 2021-10-26 19:01 ` Richard Weinberger 2021-10-28 13:31 ` Trevor Woerner 2021-10-28 13:31 ` Trevor Woerner 2021-11-09 10:55 ` Miquel Raynal 2021-11-09 10:55 ` Miquel Raynal 2021-11-09 11:45 ` Daniel Golle 2021-11-09 11:45 ` Daniel Golle 2021-11-12 13:54 ` Ezequiel Garcia 2021-11-12 13:54 ` Ezequiel Garcia 2022-01-20 9:39 ` Miquel Raynal 2022-01-20 9:39 ` Miquel Raynal 2022-01-20 10:26 ` Ezequiel Garcia 2022-01-20 10:26 ` Ezequiel Garcia 2022-01-20 11:22 ` Miquel Raynal 2022-01-20 11:22 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210817184913.5162b242@xps13 \ --to=miquel.raynal@bootlin.com \ --cc=ezequiel@collabora.com \ --cc=ezequiel@vanguardiasur.com.ar \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.