From: Mark Brown <broonie@kernel.org> To: Amit Kachhap <amit.kachhap@arm.com> Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>, Boyan Karatotev <boyan.karatotev@arm.com>, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] kselftest/arm64: pac: Fix skipping of tests on systems without PAC Date: Fri, 20 Aug 2021 13:00:09 +0100 [thread overview] Message-ID: <20210820120009.GQ4177@sirena.org.uk> (raw) In-Reply-To: <20d96c3e-36f8-276f-ab02-daf5bc7c976f@arm.com> [-- Attachment #1: Type: text/plain, Size: 1036 bytes --] On Fri, Aug 20, 2021 at 05:05:05PM +0530, Amit Kachhap wrote: > On 8/20/21 4:25 PM, Mark Brown wrote: > > On Fri, Aug 20, 2021 at 12:39:39PM +0530, Amit Kachhap wrote: > > > - ASSERT_NE(0, hwcaps & HWCAP_PACA) TH_LOG("PAUTH not enabled"); \ > > > + ASSERT_NE(0, hwcaps & HWCAP_PACA) SKIP(return, "PAUTH not enabled"); > > That's what the patch does? > Agree, I saw few other testcases where ASSERT is used along with SKIP. > (tools/testing/selftests/core/close_range_test.c) so this way > ASSERT_GENERIC_* macro will be clear. There will be just an extra > log like "hwcaps & HWCAP_PACA = 0" in this case. I'm not 100% sure I follow what you're saying here? I don't see a log message saying "hwcaps & HWCAP_PACA = 0" on non-PAC systems, or is that what you're saying you want to see? > Probably your way is consistent as other tests in arm64 also just > skips due to HWCAP mismatch. Right, we can't usefully run tests for features not present in the system - this sort of thing is the intent of the kselftest skip feature. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Amit Kachhap <amit.kachhap@arm.com> Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>, Boyan Karatotev <boyan.karatotev@arm.com>, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] kselftest/arm64: pac: Fix skipping of tests on systems without PAC Date: Fri, 20 Aug 2021 13:00:09 +0100 [thread overview] Message-ID: <20210820120009.GQ4177@sirena.org.uk> (raw) In-Reply-To: <20d96c3e-36f8-276f-ab02-daf5bc7c976f@arm.com> [-- Attachment #1.1: Type: text/plain, Size: 1036 bytes --] On Fri, Aug 20, 2021 at 05:05:05PM +0530, Amit Kachhap wrote: > On 8/20/21 4:25 PM, Mark Brown wrote: > > On Fri, Aug 20, 2021 at 12:39:39PM +0530, Amit Kachhap wrote: > > > - ASSERT_NE(0, hwcaps & HWCAP_PACA) TH_LOG("PAUTH not enabled"); \ > > > + ASSERT_NE(0, hwcaps & HWCAP_PACA) SKIP(return, "PAUTH not enabled"); > > That's what the patch does? > Agree, I saw few other testcases where ASSERT is used along with SKIP. > (tools/testing/selftests/core/close_range_test.c) so this way > ASSERT_GENERIC_* macro will be clear. There will be just an extra > log like "hwcaps & HWCAP_PACA = 0" in this case. I'm not 100% sure I follow what you're saying here? I don't see a log message saying "hwcaps & HWCAP_PACA = 0" on non-PAC systems, or is that what you're saying you want to see? > Probably your way is consistent as other tests in arm64 also just > skips due to HWCAP mismatch. Right, we can't usefully run tests for features not present in the system - this sort of thing is the intent of the kselftest skip feature. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-20 12:00 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-19 16:57 [PATCH] kselftest/arm64: pac: Fix skipping of tests on systems without PAC Mark Brown 2021-08-19 16:57 ` Mark Brown 2021-08-20 7:09 ` Amit Kachhap 2021-08-20 7:09 ` Amit Kachhap 2021-08-20 10:55 ` Mark Brown 2021-08-20 10:55 ` Mark Brown 2021-08-20 11:35 ` Amit Kachhap 2021-08-20 11:35 ` Amit Kachhap 2021-08-20 12:00 ` Mark Brown [this message] 2021-08-20 12:00 ` Mark Brown 2021-08-20 16:57 ` Catalin Marinas 2021-08-20 16:57 ` Catalin Marinas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210820120009.GQ4177@sirena.org.uk \ --to=broonie@kernel.org \ --cc=amit.kachhap@arm.com \ --cc=boyan.karatotev@arm.com \ --cc=catalin.marinas@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=shuah@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.