From: Miquel Raynal <miquel.raynal@bootlin.com> To: Apurva Nandan <a-nandan@ti.com> Cc: Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Mark Brown <broonie@kernel.org>, Patrice Chotard <patrice.chotard@foss.st.com>, Boris Brezillon <boris.brezillon@collabora.com>, <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>, Pratyush Yadav <p.yadav@ti.com> Subject: Re: [PATCH 08/13] mtd: spinand: Reject 8D-8D-8D op_templates if octal_dtr_enale() is missing in manufacturer_op Date: Fri, 20 Aug 2021 14:14:13 +0200 [thread overview] Message-ID: <20210820141413.6c519255@xps13> (raw) In-Reply-To: <4d428465-59d7-6771-8344-c5090add2a06@ti.com> Hi Apurva, Apurva Nandan <a-nandan@ti.com> wrote on Fri, 20 Aug 2021 16:56:50 +0530: > On 07/08/21 12:31 am, Miquel Raynal wrote: > > Hi Apurva, > > > > Apurva Nandan <a-nandan@ti.com> wrote on Tue, 13 Jul 2021 13:05:33 > > +0000: > > > >> The SPI NAND core doesn't know how to switch the flash to Octal DTR > >> mode (i.e. which operations to perform). If the manufacturer hasn't > >> implemented the octal_dtr_enable() manufacturer_op, the SPI NAND core > >> wouldn't be able to switch to 8D-8D-8D mode and will also not be able > >> to run in 1S-1S-1S mode due to already selected 8D-8D-8D read/write > >> cache op_templates. > >> > >> So, avoid choosing a Octal DTR SPI op_template for read_cache, > >> write_cache and update_cache operations, if the manufacturer_op > >> octal_dtr_enable() is missing. > > > > After looking at your previous commit I don't see why this patch would > > be needed. octal_dtr_enable() only updates the mode when it succeeds so > > I don't think this patch is really needed. > > > > I added it to prevent any errors happening dues to a missing implementation of octal_dtr_enable() from manufacturer driver side. > So, if the manufacturers skips the octal_dtr_enable() implementation, we want the spinand core to run in 1s-1s-1s mode. I still don't get the point: you fail the probe if the octal bit is enabled but the manufacturer did not implement octal_dtr_enable(), so how could we have issues? Maybe I am overlooking something though, but this seemed completely redundant to my eyes so far. > > Read/write/update op variant selection happens in select_op_variant(), much before octal_dtr_enable(). So just check if there is a definition of octal_dtr_enable in manufacturer ops and then only use 8D op variants. > > Removing this wouldn't break anything in the current implementation. > Do you think we should drop this? > > >> > >> Signed-off-by: Apurva Nandan <a-nandan@ti.com> > >> --- > >> drivers/mtd/nand/spi/core.c | 7 ++++++- > >> 1 file changed, 6 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > >> index 19d8affac058..8711e887b795 100644 > >> --- a/drivers/mtd/nand/spi/core.c > >> +++ b/drivers/mtd/nand/spi/core.c > >> @@ -1028,6 +1028,8 @@ static int spinand_manufacturer_match(struct spinand_device *spinand, > >> if (id[0] != manufacturer->id) > >> continue; > >> >> + spinand->manufacturer = manufacturer; > >> + > >> ret = spinand_match_and_init(spinand, > >> manufacturer->chips, > >> manufacturer->nchips, > >> @@ -1035,7 +1037,6 @@ static int spinand_manufacturer_match(struct spinand_device *spinand, > >> if (ret < 0) > >> continue; > >> >> - spinand->manufacturer = manufacturer; > >> return 0; > >> } > >> return -ENOTSUPP; > >> @@ -1097,6 +1098,10 @@ spinand_select_op_variant(struct spinand_device *spinand, > >> unsigned int nbytes; > >> int ret; > >> >> + if (spinand_op_is_octal_dtr(&op) && > >> + !spinand->manufacturer->ops->octal_dtr_enable) > >> + continue; > >> + > >> nbytes = nanddev_per_page_oobsize(nand) + > >> nanddev_page_size(nand); > >> > > Thanks, > > Miquèl > > > > ______________________________________________________ > > Linux MTD discussion mailing list > > http://lists.infradead.org/mailman/listinfo/linux-mtd/ > > > > Thanks, > Apurva Nandan Thanks, Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Apurva Nandan <a-nandan@ti.com> Cc: Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Mark Brown <broonie@kernel.org>, Patrice Chotard <patrice.chotard@foss.st.com>, Boris Brezillon <boris.brezillon@collabora.com>, <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>, Pratyush Yadav <p.yadav@ti.com> Subject: Re: [PATCH 08/13] mtd: spinand: Reject 8D-8D-8D op_templates if octal_dtr_enale() is missing in manufacturer_op Date: Fri, 20 Aug 2021 14:14:13 +0200 [thread overview] Message-ID: <20210820141413.6c519255@xps13> (raw) In-Reply-To: <4d428465-59d7-6771-8344-c5090add2a06@ti.com> Hi Apurva, Apurva Nandan <a-nandan@ti.com> wrote on Fri, 20 Aug 2021 16:56:50 +0530: > On 07/08/21 12:31 am, Miquel Raynal wrote: > > Hi Apurva, > > > > Apurva Nandan <a-nandan@ti.com> wrote on Tue, 13 Jul 2021 13:05:33 > > +0000: > > > >> The SPI NAND core doesn't know how to switch the flash to Octal DTR > >> mode (i.e. which operations to perform). If the manufacturer hasn't > >> implemented the octal_dtr_enable() manufacturer_op, the SPI NAND core > >> wouldn't be able to switch to 8D-8D-8D mode and will also not be able > >> to run in 1S-1S-1S mode due to already selected 8D-8D-8D read/write > >> cache op_templates. > >> > >> So, avoid choosing a Octal DTR SPI op_template for read_cache, > >> write_cache and update_cache operations, if the manufacturer_op > >> octal_dtr_enable() is missing. > > > > After looking at your previous commit I don't see why this patch would > > be needed. octal_dtr_enable() only updates the mode when it succeeds so > > I don't think this patch is really needed. > > > > I added it to prevent any errors happening dues to a missing implementation of octal_dtr_enable() from manufacturer driver side. > So, if the manufacturers skips the octal_dtr_enable() implementation, we want the spinand core to run in 1s-1s-1s mode. I still don't get the point: you fail the probe if the octal bit is enabled but the manufacturer did not implement octal_dtr_enable(), so how could we have issues? Maybe I am overlooking something though, but this seemed completely redundant to my eyes so far. > > Read/write/update op variant selection happens in select_op_variant(), much before octal_dtr_enable(). So just check if there is a definition of octal_dtr_enable in manufacturer ops and then only use 8D op variants. > > Removing this wouldn't break anything in the current implementation. > Do you think we should drop this? > > >> > >> Signed-off-by: Apurva Nandan <a-nandan@ti.com> > >> --- > >> drivers/mtd/nand/spi/core.c | 7 ++++++- > >> 1 file changed, 6 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > >> index 19d8affac058..8711e887b795 100644 > >> --- a/drivers/mtd/nand/spi/core.c > >> +++ b/drivers/mtd/nand/spi/core.c > >> @@ -1028,6 +1028,8 @@ static int spinand_manufacturer_match(struct spinand_device *spinand, > >> if (id[0] != manufacturer->id) > >> continue; > >> >> + spinand->manufacturer = manufacturer; > >> + > >> ret = spinand_match_and_init(spinand, > >> manufacturer->chips, > >> manufacturer->nchips, > >> @@ -1035,7 +1037,6 @@ static int spinand_manufacturer_match(struct spinand_device *spinand, > >> if (ret < 0) > >> continue; > >> >> - spinand->manufacturer = manufacturer; > >> return 0; > >> } > >> return -ENOTSUPP; > >> @@ -1097,6 +1098,10 @@ spinand_select_op_variant(struct spinand_device *spinand, > >> unsigned int nbytes; > >> int ret; > >> >> + if (spinand_op_is_octal_dtr(&op) && > >> + !spinand->manufacturer->ops->octal_dtr_enable) > >> + continue; > >> + > >> nbytes = nanddev_per_page_oobsize(nand) + > >> nanddev_page_size(nand); > >> > > Thanks, > > Miquèl > > > > ______________________________________________________ > > Linux MTD discussion mailing list > > http://lists.infradead.org/mailman/listinfo/linux-mtd/ > > > > Thanks, > Apurva Nandan Thanks, Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-08-20 12:14 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-13 13:05 [PATCH 00/13] mtd: spinand: Add Octal DTR SPI (8D-8D-8D) mode support Apurva Nandan 2021-07-13 13:05 ` Apurva Nandan 2021-07-13 13:05 ` [PATCH 01/13] spi: spi-mem: Add DTR templates for cmd, address, dummy and data phase Apurva Nandan 2021-07-13 13:05 ` Apurva Nandan 2021-07-14 17:06 ` Mark Brown 2021-07-14 17:06 ` Mark Brown 2021-08-23 7:57 ` Boris Brezillon 2021-08-23 7:57 ` Boris Brezillon 2021-07-13 13:05 ` [PATCH 02/13] mtd: spinand: Add enum spinand_proto to indicate current SPI IO mode Apurva Nandan 2021-07-13 13:05 ` Apurva Nandan 2021-07-13 13:05 ` [PATCH 03/13] mtd: spinand: Setup spi_mem_op for the SPI IO protocol using reg_proto Apurva Nandan 2021-07-13 13:05 ` Apurva Nandan 2021-08-06 18:30 ` Miquel Raynal 2021-08-06 18:30 ` Miquel Raynal 2021-08-20 9:52 ` Apurva Nandan 2021-08-20 9:52 ` Apurva Nandan 2021-08-20 12:08 ` Miquel Raynal 2021-08-20 12:08 ` Miquel Raynal 2021-08-23 7:11 ` Boris Brezillon 2021-08-23 7:11 ` Boris Brezillon 2021-08-23 7:24 ` Miquel Raynal 2021-08-23 7:24 ` Miquel Raynal 2021-07-13 13:05 ` [PATCH 04/13] mtd: spinand: Fix odd byte addr and data phase in read/write reg op and write VCR op for Octal DTR mode Apurva Nandan 2021-07-13 13:05 ` Apurva Nandan 2021-08-06 18:43 ` Miquel Raynal 2021-08-06 18:43 ` Miquel Raynal 2021-08-20 10:27 ` Apurva Nandan 2021-08-20 10:27 ` Apurva Nandan 2021-08-20 12:06 ` Miquel Raynal 2021-08-20 12:06 ` Miquel Raynal 2021-07-13 13:05 ` [PATCH 05/13] mtd: spinand: Add adjust_op() in manufacturer_ops to modify the ops for manufacturer specific changes Apurva Nandan 2021-07-13 13:05 ` Apurva Nandan 2021-07-13 13:05 ` [PATCH 06/13] mtd: spinand: Add macros for Octal DTR page read and write operations Apurva Nandan 2021-07-13 13:05 ` Apurva Nandan 2021-08-06 18:54 ` Miquel Raynal 2021-08-06 18:54 ` Miquel Raynal 2021-08-20 10:35 ` Apurva Nandan 2021-08-20 10:35 ` Apurva Nandan 2021-07-13 13:05 ` [PATCH 07/13] mtd: spinand: Allow enabling Octal DTR mode in the core Apurva Nandan 2021-07-13 13:05 ` Apurva Nandan 2021-08-06 18:58 ` Miquel Raynal 2021-08-06 18:58 ` Miquel Raynal 2021-08-20 10:41 ` Apurva Nandan 2021-08-20 10:41 ` Apurva Nandan 2021-07-13 13:05 ` [PATCH 08/13] mtd: spinand: Reject 8D-8D-8D op_templates if octal_dtr_enale() is missing in manufacturer_op Apurva Nandan 2021-07-13 13:05 ` Apurva Nandan 2021-08-06 19:01 ` Miquel Raynal 2021-08-06 19:01 ` Miquel Raynal 2021-08-20 11:26 ` Apurva Nandan 2021-08-20 11:26 ` Apurva Nandan 2021-08-20 12:14 ` Miquel Raynal [this message] 2021-08-20 12:14 ` Miquel Raynal 2021-08-20 13:54 ` Apurva Nandan 2021-08-20 13:54 ` Apurva Nandan 2021-08-20 14:38 ` Miquel Raynal 2021-08-20 14:38 ` Miquel Raynal 2021-08-20 15:53 ` Apurva Nandan 2021-08-20 15:53 ` Apurva Nandan 2021-07-13 13:05 ` [PATCH 09/13] mtd: spinand: Add support for write volatile configuration register op Apurva Nandan 2021-07-13 13:05 ` Apurva Nandan 2021-08-06 19:05 ` Miquel Raynal 2021-08-06 19:05 ` Miquel Raynal 2021-08-20 11:30 ` Apurva Nandan 2021-08-20 11:30 ` Apurva Nandan 2021-07-13 13:05 ` [PATCH 10/13] mtd: spinand: Add octal_dtr_enable() for Winbond manufacturer_ops Apurva Nandan 2021-07-13 13:05 ` Apurva Nandan 2021-08-06 19:06 ` Miquel Raynal 2021-08-06 19:06 ` Miquel Raynal 2021-08-20 11:31 ` Apurva Nandan 2021-08-20 11:31 ` Apurva Nandan 2021-07-13 13:05 ` [PATCH 11/13] mtd: spinand: Add support for Power-on-Reset (PoR) instruction Apurva Nandan 2021-07-13 13:05 ` Apurva Nandan 2021-08-06 19:08 ` Miquel Raynal 2021-08-06 19:08 ` Miquel Raynal 2021-08-20 11:39 ` Apurva Nandan 2021-08-20 11:39 ` Apurva Nandan 2021-08-20 12:18 ` Miquel Raynal 2021-08-20 12:18 ` Miquel Raynal 2021-08-20 13:41 ` Apurva Nandan 2021-08-20 13:41 ` Apurva Nandan 2021-08-20 14:17 ` Miquel Raynal 2021-08-20 14:17 ` Miquel Raynal 2021-08-20 15:56 ` Apurva Nandan 2021-08-20 15:56 ` Apurva Nandan 2021-07-13 13:05 ` [PATCH 12/13] mtd: spinand: Perform Power-on-Reset when runtime_pm suspend is issued Apurva Nandan 2021-07-13 13:05 ` Apurva Nandan 2021-08-06 19:12 ` Miquel Raynal 2021-08-06 19:12 ` Miquel Raynal 2021-08-20 11:45 ` Apurva Nandan 2021-08-20 11:45 ` Apurva Nandan 2021-07-13 13:05 ` [PATCH 13/13] mtd: spinand: Add support for Winbond W35N01JW SPI NAND flash Apurva Nandan 2021-07-13 13:05 ` Apurva Nandan 2021-08-06 19:14 ` Miquel Raynal 2021-08-06 19:14 ` Miquel Raynal 2021-08-20 11:51 ` Apurva Nandan 2021-08-20 11:51 ` Apurva Nandan 2021-08-20 12:02 ` Miquel Raynal 2021-08-20 12:02 ` Miquel Raynal 2021-08-20 13:14 ` Apurva Nandan 2021-08-20 13:14 ` Apurva Nandan 2021-07-20 16:53 ` [PATCH 00/13] mtd: spinand: Add Octal DTR SPI (8D-8D-8D) mode support Nandan, Apurva 2021-07-20 16:53 ` Nandan, Apurva
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210820141413.6c519255@xps13 \ --to=miquel.raynal@bootlin.com \ --cc=a-nandan@ti.com \ --cc=boris.brezillon@collabora.com \ --cc=broonie@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=p.yadav@ti.com \ --cc=patrice.chotard@foss.st.com \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.