From: Bjorn Helgaas <helgaas@kernel.org> To: "Pali Rohár" <pali@kernel.org> Cc: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>, "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>, "Bjorn Helgaas" <bhelgaas@google.com>, "Rob Herring" <robh@kernel.org>, "Gregory Clement" <gregory.clement@bootlin.com>, "Marek Behún" <kabel@kernel.org>, "Remi Pommarel" <repk@triplefau.lt>, Xogium <contact@xogium.me>, "Tomasz Maciej Nowak" <tmn505@gmail.com>, "Nadav Haklai" <nadavh@marvell.com>, "Kostya Porotchkin" <kostap@marvell.com>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH 2/5] PCI: Add PCI_EXP_DEVCTL_PAYLOAD_* macros Date: Tue, 24 Aug 2021 14:00:39 -0500 [thread overview] Message-ID: <20210824190039.GA3486187@bjorn-Precision-5520> (raw) In-Reply-To: <20210624222621.4776-3-pali@kernel.org> On Fri, Jun 25, 2021 at 12:26:18AM +0200, Pali Rohár wrote: > Define a macro PCI_EXP_DEVCTL_PAYLOAD_* for every possible Max Payload > Size in linux/pci_regs.h, in the same style as PCI_EXP_DEVCTL_READRQ_*. > > Signed-off-by: Pali Rohár <pali@kernel.org> > Reviewed-by: Marek Behún <kabel@kernel.org> Acked-by: Bjorn Helgaas <bhelgaas@google.com> > --- > include/uapi/linux/pci_regs.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h > index e709ae8235e7..ff6ccbc6efe9 100644 > --- a/include/uapi/linux/pci_regs.h > +++ b/include/uapi/linux/pci_regs.h > @@ -504,6 +504,12 @@ > #define PCI_EXP_DEVCTL_URRE 0x0008 /* Unsupported Request Reporting En. */ > #define PCI_EXP_DEVCTL_RELAX_EN 0x0010 /* Enable relaxed ordering */ > #define PCI_EXP_DEVCTL_PAYLOAD 0x00e0 /* Max_Payload_Size */ > +#define PCI_EXP_DEVCTL_PAYLOAD_128B 0x0000 /* 128 Bytes */ > +#define PCI_EXP_DEVCTL_PAYLOAD_256B 0x0020 /* 256 Bytes */ > +#define PCI_EXP_DEVCTL_PAYLOAD_512B 0x0040 /* 512 Bytes */ > +#define PCI_EXP_DEVCTL_PAYLOAD_1024B 0x0060 /* 1024 Bytes */ > +#define PCI_EXP_DEVCTL_PAYLOAD_2048B 0x0080 /* 2048 Bytes */ > +#define PCI_EXP_DEVCTL_PAYLOAD_4096B 0x00a0 /* 4096 Bytes */ > #define PCI_EXP_DEVCTL_EXT_TAG 0x0100 /* Extended Tag Field Enable */ > #define PCI_EXP_DEVCTL_PHANTOM 0x0200 /* Phantom Functions Enable */ > #define PCI_EXP_DEVCTL_AUX_PME 0x0400 /* Auxiliary Power PM Enable */ > -- > 2.20.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org> To: "Pali Rohár" <pali@kernel.org> Cc: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>, "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>, "Bjorn Helgaas" <bhelgaas@google.com>, "Rob Herring" <robh@kernel.org>, "Gregory Clement" <gregory.clement@bootlin.com>, "Marek Behún" <kabel@kernel.org>, "Remi Pommarel" <repk@triplefau.lt>, Xogium <contact@xogium.me>, "Tomasz Maciej Nowak" <tmn505@gmail.com>, "Nadav Haklai" <nadavh@marvell.com>, "Kostya Porotchkin" <kostap@marvell.com>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH 2/5] PCI: Add PCI_EXP_DEVCTL_PAYLOAD_* macros Date: Tue, 24 Aug 2021 14:00:39 -0500 [thread overview] Message-ID: <20210824190039.GA3486187@bjorn-Precision-5520> (raw) In-Reply-To: <20210624222621.4776-3-pali@kernel.org> On Fri, Jun 25, 2021 at 12:26:18AM +0200, Pali Rohár wrote: > Define a macro PCI_EXP_DEVCTL_PAYLOAD_* for every possible Max Payload > Size in linux/pci_regs.h, in the same style as PCI_EXP_DEVCTL_READRQ_*. > > Signed-off-by: Pali Rohár <pali@kernel.org> > Reviewed-by: Marek Behún <kabel@kernel.org> Acked-by: Bjorn Helgaas <bhelgaas@google.com> > --- > include/uapi/linux/pci_regs.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h > index e709ae8235e7..ff6ccbc6efe9 100644 > --- a/include/uapi/linux/pci_regs.h > +++ b/include/uapi/linux/pci_regs.h > @@ -504,6 +504,12 @@ > #define PCI_EXP_DEVCTL_URRE 0x0008 /* Unsupported Request Reporting En. */ > #define PCI_EXP_DEVCTL_RELAX_EN 0x0010 /* Enable relaxed ordering */ > #define PCI_EXP_DEVCTL_PAYLOAD 0x00e0 /* Max_Payload_Size */ > +#define PCI_EXP_DEVCTL_PAYLOAD_128B 0x0000 /* 128 Bytes */ > +#define PCI_EXP_DEVCTL_PAYLOAD_256B 0x0020 /* 256 Bytes */ > +#define PCI_EXP_DEVCTL_PAYLOAD_512B 0x0040 /* 512 Bytes */ > +#define PCI_EXP_DEVCTL_PAYLOAD_1024B 0x0060 /* 1024 Bytes */ > +#define PCI_EXP_DEVCTL_PAYLOAD_2048B 0x0080 /* 2048 Bytes */ > +#define PCI_EXP_DEVCTL_PAYLOAD_4096B 0x00a0 /* 4096 Bytes */ > #define PCI_EXP_DEVCTL_EXT_TAG 0x0100 /* Extended Tag Field Enable */ > #define PCI_EXP_DEVCTL_PHANTOM 0x0200 /* Phantom Functions Enable */ > #define PCI_EXP_DEVCTL_AUX_PME 0x0400 /* Auxiliary Power PM Enable */ > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-24 19:00 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-24 22:26 [RESEND PATCH 0/5] PCI: aardvark: Initialization fixes Pali Rohár 2021-06-24 22:26 ` Pali Rohár 2021-06-24 22:26 ` [RESEND PATCH 1/5] PCI: aardvark: Fix link training Pali Rohár 2021-06-24 22:26 ` Pali Rohár 2021-06-24 22:26 ` [RESEND PATCH 2/5] PCI: Add PCI_EXP_DEVCTL_PAYLOAD_* macros Pali Rohár 2021-06-24 22:26 ` Pali Rohár 2021-08-13 15:46 ` Lorenzo Pieralisi 2021-08-13 15:46 ` Lorenzo Pieralisi 2021-08-24 19:00 ` Bjorn Helgaas [this message] 2021-08-24 19:00 ` Bjorn Helgaas 2021-06-24 22:26 ` [RESEND PATCH 3/5] PCI: aardvark: Fix PCIe Max Payload Size setting Pali Rohár 2021-06-24 22:26 ` Pali Rohár 2021-06-24 22:26 ` [RESEND PATCH 4/5] PCI: aardvark: Implement workaround for the readback value of VEND_ID Pali Rohár 2021-06-24 22:26 ` Pali Rohár 2021-06-24 22:26 ` [RESEND PATCH 5/5] PCI: aardvark: Implement workaround for PCIe Completion Timeout Pali Rohár 2021-06-24 22:26 ` Pali Rohár 2021-08-25 19:59 ` Pali Rohár 2021-08-25 19:59 ` Pali Rohár 2021-09-08 19:42 ` Pali Rohár 2021-09-08 19:42 ` Pali Rohár 2021-06-25 12:52 ` [RESEND PATCH 0/5] PCI: aardvark: Initialization fixes Lorenzo Pieralisi 2021-06-25 12:52 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210824190039.GA3486187@bjorn-Precision-5520 \ --to=helgaas@kernel.org \ --cc=bhelgaas@google.com \ --cc=contact@xogium.me \ --cc=gregory.clement@bootlin.com \ --cc=kabel@kernel.org \ --cc=kostap@marvell.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=nadavh@marvell.com \ --cc=pali@kernel.org \ --cc=repk@triplefau.lt \ --cc=robh@kernel.org \ --cc=thomas.petazzoni@bootlin.com \ --cc=tmn505@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.