From: kernel test robot <lkp@intel.com>
To: Sugar Zhang <sugar.zhang@rock-chips.com>,
broonie@kernel.org, heiko@sntech.de
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Sugar Zhang <sugar.zhang@rock-chips.com>,
linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: rockchip: i2s: Fix concurrency between tx/rx
Date: Mon, 30 Aug 2021 12:41:53 +0800 [thread overview]
Message-ID: <202108301246.4iYTZ4Mx-lkp@intel.com> (raw)
In-Reply-To: <1630290980-58894-1-git-send-email-sugar.zhang@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 3882 bytes --]
Hi Sugar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on rockchip/for-next]
[also build test ERROR on v5.14]
[cannot apply to asoc/for-next next-20210827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sugar-Zhang/ASoC-rockchip-i2s-Fix-concurrency-between-tx-rx/20210830-103815
base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
config: hexagon-randconfig-r041-20210829 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b1fde8a2b681dad2ce0c082a5d6422caa06b0bc)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/69f422462083a0abbfbe83c9ed6628dc6cc728a9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sugar-Zhang/ASoC-rockchip-i2s-Fix-concurrency-between-tx-rx/20210830-103815
git checkout 69f422462083a0abbfbe83c9ed6628dc6cc728a9
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=hexagon SHELL=/bin/bash sound/soc/rockchip/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> sound/soc/rockchip/rockchip_i2s.c:97:13: error: use of undeclared identifier 'lock'
spin_lock(&lock);
^
sound/soc/rockchip/rockchip_i2s.c:138:15: error: use of undeclared identifier 'lock'
spin_unlock(&lock);
^
sound/soc/rockchip/rockchip_i2s.c:146:13: error: use of undeclared identifier 'lock'
spin_lock(&lock);
^
sound/soc/rockchip/rockchip_i2s.c:187:15: error: use of undeclared identifier 'lock'
spin_unlock(&lock);
^
4 errors generated.
vim +/lock +97 sound/soc/rockchip/rockchip_i2s.c
91
92 static void rockchip_snd_txctrl(struct rk_i2s_dev *i2s, int on)
93 {
94 unsigned int val = 0;
95 int retry = 10;
96
> 97 spin_lock(&lock);
98 if (on) {
99 regmap_update_bits(i2s->regmap, I2S_DMACR,
100 I2S_DMACR_TDE_ENABLE, I2S_DMACR_TDE_ENABLE);
101
102 regmap_update_bits(i2s->regmap, I2S_XFER,
103 I2S_XFER_TXS_START | I2S_XFER_RXS_START,
104 I2S_XFER_TXS_START | I2S_XFER_RXS_START);
105
106 i2s->tx_start = true;
107 } else {
108 i2s->tx_start = false;
109
110 regmap_update_bits(i2s->regmap, I2S_DMACR,
111 I2S_DMACR_TDE_ENABLE, I2S_DMACR_TDE_DISABLE);
112
113 if (!i2s->rx_start) {
114 regmap_update_bits(i2s->regmap, I2S_XFER,
115 I2S_XFER_TXS_START |
116 I2S_XFER_RXS_START,
117 I2S_XFER_TXS_STOP |
118 I2S_XFER_RXS_STOP);
119
120 udelay(150);
121 regmap_update_bits(i2s->regmap, I2S_CLR,
122 I2S_CLR_TXC | I2S_CLR_RXC,
123 I2S_CLR_TXC | I2S_CLR_RXC);
124
125 regmap_read(i2s->regmap, I2S_CLR, &val);
126
127 /* Should wait for clear operation to finish */
128 while (val) {
129 regmap_read(i2s->regmap, I2S_CLR, &val);
130 retry--;
131 if (!retry) {
132 dev_warn(i2s->dev, "fail to clear\n");
133 break;
134 }
135 }
136 }
137 }
138 spin_unlock(&lock);
139 }
140
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35463 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Sugar Zhang <sugar.zhang@rock-chips.com>,
broonie@kernel.org, heiko@sntech.de
Cc: Sugar Zhang <sugar.zhang@rock-chips.com>,
linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
llvm@lists.linux.dev, kbuild-all@lists.01.org
Subject: Re: [PATCH] ASoC: rockchip: i2s: Fix concurrency between tx/rx
Date: Mon, 30 Aug 2021 12:41:53 +0800 [thread overview]
Message-ID: <202108301246.4iYTZ4Mx-lkp@intel.com> (raw)
In-Reply-To: <1630290980-58894-1-git-send-email-sugar.zhang@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 3882 bytes --]
Hi Sugar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on rockchip/for-next]
[also build test ERROR on v5.14]
[cannot apply to asoc/for-next next-20210827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sugar-Zhang/ASoC-rockchip-i2s-Fix-concurrency-between-tx-rx/20210830-103815
base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
config: hexagon-randconfig-r041-20210829 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b1fde8a2b681dad2ce0c082a5d6422caa06b0bc)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/69f422462083a0abbfbe83c9ed6628dc6cc728a9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sugar-Zhang/ASoC-rockchip-i2s-Fix-concurrency-between-tx-rx/20210830-103815
git checkout 69f422462083a0abbfbe83c9ed6628dc6cc728a9
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=hexagon SHELL=/bin/bash sound/soc/rockchip/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> sound/soc/rockchip/rockchip_i2s.c:97:13: error: use of undeclared identifier 'lock'
spin_lock(&lock);
^
sound/soc/rockchip/rockchip_i2s.c:138:15: error: use of undeclared identifier 'lock'
spin_unlock(&lock);
^
sound/soc/rockchip/rockchip_i2s.c:146:13: error: use of undeclared identifier 'lock'
spin_lock(&lock);
^
sound/soc/rockchip/rockchip_i2s.c:187:15: error: use of undeclared identifier 'lock'
spin_unlock(&lock);
^
4 errors generated.
vim +/lock +97 sound/soc/rockchip/rockchip_i2s.c
91
92 static void rockchip_snd_txctrl(struct rk_i2s_dev *i2s, int on)
93 {
94 unsigned int val = 0;
95 int retry = 10;
96
> 97 spin_lock(&lock);
98 if (on) {
99 regmap_update_bits(i2s->regmap, I2S_DMACR,
100 I2S_DMACR_TDE_ENABLE, I2S_DMACR_TDE_ENABLE);
101
102 regmap_update_bits(i2s->regmap, I2S_XFER,
103 I2S_XFER_TXS_START | I2S_XFER_RXS_START,
104 I2S_XFER_TXS_START | I2S_XFER_RXS_START);
105
106 i2s->tx_start = true;
107 } else {
108 i2s->tx_start = false;
109
110 regmap_update_bits(i2s->regmap, I2S_DMACR,
111 I2S_DMACR_TDE_ENABLE, I2S_DMACR_TDE_DISABLE);
112
113 if (!i2s->rx_start) {
114 regmap_update_bits(i2s->regmap, I2S_XFER,
115 I2S_XFER_TXS_START |
116 I2S_XFER_RXS_START,
117 I2S_XFER_TXS_STOP |
118 I2S_XFER_RXS_STOP);
119
120 udelay(150);
121 regmap_update_bits(i2s->regmap, I2S_CLR,
122 I2S_CLR_TXC | I2S_CLR_RXC,
123 I2S_CLR_TXC | I2S_CLR_RXC);
124
125 regmap_read(i2s->regmap, I2S_CLR, &val);
126
127 /* Should wait for clear operation to finish */
128 while (val) {
129 regmap_read(i2s->regmap, I2S_CLR, &val);
130 retry--;
131 if (!retry) {
132 dev_warn(i2s->dev, "fail to clear\n");
133 break;
134 }
135 }
136 }
137 }
138 spin_unlock(&lock);
139 }
140
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35463 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Sugar Zhang <sugar.zhang@rock-chips.com>,
broonie@kernel.org, heiko@sntech.de
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Sugar Zhang <sugar.zhang@rock-chips.com>,
linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: rockchip: i2s: Fix concurrency between tx/rx
Date: Mon, 30 Aug 2021 12:41:53 +0800 [thread overview]
Message-ID: <202108301246.4iYTZ4Mx-lkp@intel.com> (raw)
In-Reply-To: <1630290980-58894-1-git-send-email-sugar.zhang@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 3882 bytes --]
Hi Sugar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on rockchip/for-next]
[also build test ERROR on v5.14]
[cannot apply to asoc/for-next next-20210827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sugar-Zhang/ASoC-rockchip-i2s-Fix-concurrency-between-tx-rx/20210830-103815
base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
config: hexagon-randconfig-r041-20210829 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b1fde8a2b681dad2ce0c082a5d6422caa06b0bc)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/69f422462083a0abbfbe83c9ed6628dc6cc728a9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sugar-Zhang/ASoC-rockchip-i2s-Fix-concurrency-between-tx-rx/20210830-103815
git checkout 69f422462083a0abbfbe83c9ed6628dc6cc728a9
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=hexagon SHELL=/bin/bash sound/soc/rockchip/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> sound/soc/rockchip/rockchip_i2s.c:97:13: error: use of undeclared identifier 'lock'
spin_lock(&lock);
^
sound/soc/rockchip/rockchip_i2s.c:138:15: error: use of undeclared identifier 'lock'
spin_unlock(&lock);
^
sound/soc/rockchip/rockchip_i2s.c:146:13: error: use of undeclared identifier 'lock'
spin_lock(&lock);
^
sound/soc/rockchip/rockchip_i2s.c:187:15: error: use of undeclared identifier 'lock'
spin_unlock(&lock);
^
4 errors generated.
vim +/lock +97 sound/soc/rockchip/rockchip_i2s.c
91
92 static void rockchip_snd_txctrl(struct rk_i2s_dev *i2s, int on)
93 {
94 unsigned int val = 0;
95 int retry = 10;
96
> 97 spin_lock(&lock);
98 if (on) {
99 regmap_update_bits(i2s->regmap, I2S_DMACR,
100 I2S_DMACR_TDE_ENABLE, I2S_DMACR_TDE_ENABLE);
101
102 regmap_update_bits(i2s->regmap, I2S_XFER,
103 I2S_XFER_TXS_START | I2S_XFER_RXS_START,
104 I2S_XFER_TXS_START | I2S_XFER_RXS_START);
105
106 i2s->tx_start = true;
107 } else {
108 i2s->tx_start = false;
109
110 regmap_update_bits(i2s->regmap, I2S_DMACR,
111 I2S_DMACR_TDE_ENABLE, I2S_DMACR_TDE_DISABLE);
112
113 if (!i2s->rx_start) {
114 regmap_update_bits(i2s->regmap, I2S_XFER,
115 I2S_XFER_TXS_START |
116 I2S_XFER_RXS_START,
117 I2S_XFER_TXS_STOP |
118 I2S_XFER_RXS_STOP);
119
120 udelay(150);
121 regmap_update_bits(i2s->regmap, I2S_CLR,
122 I2S_CLR_TXC | I2S_CLR_RXC,
123 I2S_CLR_TXC | I2S_CLR_RXC);
124
125 regmap_read(i2s->regmap, I2S_CLR, &val);
126
127 /* Should wait for clear operation to finish */
128 while (val) {
129 regmap_read(i2s->regmap, I2S_CLR, &val);
130 retry--;
131 if (!retry) {
132 dev_warn(i2s->dev, "fail to clear\n");
133 break;
134 }
135 }
136 }
137 }
138 spin_unlock(&lock);
139 }
140
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35463 bytes --]
[-- Attachment #3: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] ASoC: rockchip: i2s: Fix concurrency between tx/rx
Date: Mon, 30 Aug 2021 12:41:53 +0800 [thread overview]
Message-ID: <202108301246.4iYTZ4Mx-lkp@intel.com> (raw)
In-Reply-To: <1630290980-58894-1-git-send-email-sugar.zhang@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 3986 bytes --]
Hi Sugar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on rockchip/for-next]
[also build test ERROR on v5.14]
[cannot apply to asoc/for-next next-20210827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sugar-Zhang/ASoC-rockchip-i2s-Fix-concurrency-between-tx-rx/20210830-103815
base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
config: hexagon-randconfig-r041-20210829 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b1fde8a2b681dad2ce0c082a5d6422caa06b0bc)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/69f422462083a0abbfbe83c9ed6628dc6cc728a9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sugar-Zhang/ASoC-rockchip-i2s-Fix-concurrency-between-tx-rx/20210830-103815
git checkout 69f422462083a0abbfbe83c9ed6628dc6cc728a9
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=hexagon SHELL=/bin/bash sound/soc/rockchip/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> sound/soc/rockchip/rockchip_i2s.c:97:13: error: use of undeclared identifier 'lock'
spin_lock(&lock);
^
sound/soc/rockchip/rockchip_i2s.c:138:15: error: use of undeclared identifier 'lock'
spin_unlock(&lock);
^
sound/soc/rockchip/rockchip_i2s.c:146:13: error: use of undeclared identifier 'lock'
spin_lock(&lock);
^
sound/soc/rockchip/rockchip_i2s.c:187:15: error: use of undeclared identifier 'lock'
spin_unlock(&lock);
^
4 errors generated.
vim +/lock +97 sound/soc/rockchip/rockchip_i2s.c
91
92 static void rockchip_snd_txctrl(struct rk_i2s_dev *i2s, int on)
93 {
94 unsigned int val = 0;
95 int retry = 10;
96
> 97 spin_lock(&lock);
98 if (on) {
99 regmap_update_bits(i2s->regmap, I2S_DMACR,
100 I2S_DMACR_TDE_ENABLE, I2S_DMACR_TDE_ENABLE);
101
102 regmap_update_bits(i2s->regmap, I2S_XFER,
103 I2S_XFER_TXS_START | I2S_XFER_RXS_START,
104 I2S_XFER_TXS_START | I2S_XFER_RXS_START);
105
106 i2s->tx_start = true;
107 } else {
108 i2s->tx_start = false;
109
110 regmap_update_bits(i2s->regmap, I2S_DMACR,
111 I2S_DMACR_TDE_ENABLE, I2S_DMACR_TDE_DISABLE);
112
113 if (!i2s->rx_start) {
114 regmap_update_bits(i2s->regmap, I2S_XFER,
115 I2S_XFER_TXS_START |
116 I2S_XFER_RXS_START,
117 I2S_XFER_TXS_STOP |
118 I2S_XFER_RXS_STOP);
119
120 udelay(150);
121 regmap_update_bits(i2s->regmap, I2S_CLR,
122 I2S_CLR_TXC | I2S_CLR_RXC,
123 I2S_CLR_TXC | I2S_CLR_RXC);
124
125 regmap_read(i2s->regmap, I2S_CLR, &val);
126
127 /* Should wait for clear operation to finish */
128 while (val) {
129 regmap_read(i2s->regmap, I2S_CLR, &val);
130 retry--;
131 if (!retry) {
132 dev_warn(i2s->dev, "fail to clear\n");
133 break;
134 }
135 }
136 }
137 }
138 spin_unlock(&lock);
139 }
140
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35463 bytes --]
next prev parent reply other threads:[~2021-08-30 4:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 2:36 [PATCH] ASoC: rockchip: i2s: Fix concurrency between tx/rx Sugar Zhang
2021-08-30 2:36 ` Sugar Zhang
2021-08-30 4:41 ` kernel test robot [this message]
2021-08-30 4:41 ` kernel test robot
2021-08-30 4:41 ` kernel test robot
2021-08-30 4:41 ` kernel test robot
2021-08-30 6:28 ` kernel test robot
2021-08-30 6:28 ` kernel test robot
2021-08-30 6:28 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108301246.4iYTZ4Mx-lkp@intel.com \
--to=lkp@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=sugar.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.