Re: [RFC][PATCH v2 13/13] iommu/nvidia-smmu-v3: Add mdev interface support

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC][PATCH v2 13/13] iommu/nvidia-smmu-v3: Add mdev interface support
Date: Tue, 31 Aug 2021 16:58:29 +0800	[thread overview]
Message-ID: <202108311628.ObgzQ7vB-lkp@intel.com> (raw)
In-Reply-To: <20210831025923.15812-14-nicolinc@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 4072 bytes --]

Hi Nicolin,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on iommu/next]
[also build test WARNING on next-20210830]
[cannot apply to vfio/next linus/master v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicolin-Chen/iommu-arm-smmu-v3-Add-NVIDIA-implementation/20210831-111013
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f0498366ced0e3160486087e3d218fd519092545
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nicolin-Chen/iommu-arm-smmu-v3-Add-NVIDIA-implementation/20210831-111013
        git checkout f0498366ced0e3160486087e3d218fd519092545
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/iommu/arm/arm-smmu-v3/nvidia-smmu-v3.c:251:5: warning: no previous prototype for 'nvidia_smmu_cmdqv_mdev_init' [-Wmissing-prototypes]
     251 | int nvidia_smmu_cmdqv_mdev_init(struct nvidia_smmu *nsmmu)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/iommu/arm/arm-smmu-v3/nvidia-smmu-v3.c:629:21: warning: no previous prototype for 'nvidia_smmu_create' [-Wmissing-prototypes]
     629 | struct nvidia_smmu *nvidia_smmu_create(struct arm_smmu_device *smmu)
         |                     ^~~~~~~~~~~~~~~~~~

vim +/nvidia_smmu_cmdqv_mdev_init +251 drivers/iommu/arm/arm-smmu-v3/nvidia-smmu-v3.c

   204	
   205	int nvidia_smmu_cmdqv_mdev_init(struct nvidia_smmu *nsmmu)
   206	{
   207		struct nvidia_cmdqv_mdev *cmdqv_mdev;
   208		int ret;
   209	
   210		/* Skip mdev init unless there are available VINTFs */
   211		if (nsmmu->num_total_vintfs <= 1)
   212			return 0;
   213	
   214		nsmmu->vintf_mdev = devm_kcalloc(nsmmu->cmdqv_dev, nsmmu->num_total_vintfs,
   215						 sizeof(*nsmmu->vintf_mdev), GFP_KERNEL);
   216		if (!nsmmu->vintf_mdev)
   217			return -ENOMEM;
   218	
   219		nsmmu->vcmdq_regcache = devm_kcalloc(nsmmu->cmdqv_dev, nsmmu->num_total_vcmdqs,
   220						     sizeof(*nsmmu->vcmdq_regcache), GFP_KERNEL);
   221		if (!nsmmu->vcmdq_regcache)
   222			return -ENOMEM;
   223	
   224		nsmmu->vmid_mappings = devm_kcalloc(nsmmu->cmdqv_dev, 1 << nsmmu->smmu.vmid_bits,
   225						    sizeof(*nsmmu->vmid_mappings), GFP_KERNEL);
   226		if (!nsmmu->vmid_mappings)
   227			return -ENOMEM;
   228	
   229		mutex_init(&nsmmu->mdev_lock);
   230		mutex_init(&nsmmu->vmid_lock);
   231	
   232		/* Add a dummy mdev instance to represent vintf0 */
   233		cmdqv_mdev = devm_kzalloc(nsmmu->cmdqv_dev, sizeof(*cmdqv_mdev), GFP_KERNEL);
   234		if (!cmdqv_mdev)
   235			return -ENOMEM;
   236	
   237		cmdqv_mdev->nsmmu = nsmmu;
   238		nsmmu->vintf_mdev[0] = cmdqv_mdev;
   239	
   240		ret = mdev_register_device(nsmmu->cmdqv_dev, &nvidia_smmu_cmdqv_mdev_ops);
   241		if (ret) {
   242			dev_err(nsmmu->cmdqv_dev, "failed to register mdev device: %d\n", ret);
   243			return ret;
   244		}
   245	
   246		platform_set_drvdata(to_platform_device(nsmmu->cmdqv_dev), nsmmu);
   247	
   248		return ret;
   249	}
   250	#else
 > 251	int nvidia_smmu_cmdqv_mdev_init(struct nvidia_smmu *nsmmu)
   252	{
   253		return 0;
   254	}
   255	#endif
   256	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 77964 bytes --]