All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nuno Sá" <nuno.sa@analog.com>
To: <linux-iio@vger.kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Dragos Bogdan <dragos.bogdan@analog.com>
Subject: [PATCH 0/5] Fixes and improvements to the ADIS lib/devices
Date: Fri, 3 Sep 2021 16:14:18 +0200	[thread overview]
Message-ID: <20210903141423.517028-1-nuno.sa@analog.com> (raw)

This series adds some fixes and improvements for the ADIS library and
devices. There are two fixes:
 
1) On the library 'adis_init()' function, a call to 'adis_enable_irq()'
was being done. That does not make sense because
'__adis_initial_startup()' will reset the device and put the data ready
pin in the default state. For some drivers, these could mean that we
were leaving probe in a state different from the desired one.
2) The adis16480 driver was registering a managed reset action to put
the device into sleep mode in the unbinding path. Well, not all devices
supported by the driver support sleep mode.
 
The rest of the series is a minor improvement about passing the handling of
enabling/disabling IRQs (for devices that cannot unmask the data ready
pin) inside the library.

Nuno Sá (5):
  iio: adis: do not disabe IRQs in 'adis_init()'
  iio: adis: handle devices that cannot unmask the drdy pin
  iio: adis16475: make use of the new unmasked_drdy flag
  iio: adis16460: make use of the new unmasked_drdy flag
  iio: adis16480: fix devices that do not support sleep mode

 drivers/iio/imu/adis.c         | 17 ++++++++++++++++-
 drivers/iio/imu/adis16460.c    | 18 +-----------------
 drivers/iio/imu/adis16475.c    | 19 +------------------
 drivers/iio/imu/adis16480.c    | 14 +++++++++++---
 drivers/iio/imu/adis_trigger.c |  4 ++++
 include/linux/iio/imu/adis.h   |  2 ++
 6 files changed, 35 insertions(+), 39 deletions(-)

-- 
2.33.0


             reply	other threads:[~2021-09-03 14:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-03 14:14 Nuno Sá [this message]
2021-09-03 14:14 ` [PATCH 1/5] iio: adis: do not disabe IRQs in 'adis_init()' Nuno Sá
2021-09-03 14:14 ` [PATCH 2/5] iio: adis: handle devices that cannot unmask the drdy pin Nuno Sá
2021-09-03 14:14 ` [PATCH 3/5] iio: adis16475: make use of the new unmasked_drdy flag Nuno Sá
2021-09-03 14:14 ` [PATCH 4/5] iio: adis16460: " Nuno Sá
2021-09-26 15:25   ` Jonathan Cameron
2021-09-03 14:14 ` [PATCH 5/5] iio: adis16480: fix devices that do not support sleep mode Nuno Sá
2021-09-26 15:23   ` Jonathan Cameron
2021-09-05 13:39 ` [PATCH 0/5] Fixes and improvements to the ADIS lib/devices Jonathan Cameron
2021-09-06  8:56   ` Sa, Nuno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210903141423.517028-1-nuno.sa@analog.com \
    --to=nuno.sa@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=dragos.bogdan@analog.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.