Re: [PATCH 0/5] Fixes and improvements to the ADIS lib/devices

From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: <linux-iio@vger.kernel.org>, Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Dragos Bogdan <dragos.bogdan@analog.com>
Subject: Re: [PATCH 0/5] Fixes and improvements to the ADIS lib/devices
Date: Sun, 5 Sep 2021 14:39:33 +0100	[thread overview]
Message-ID: <20210905143933.4f492b78@jic23-huawei> (raw)
In-Reply-To: <20210903141423.517028-1-nuno.sa@analog.com>

On Fri, 3 Sep 2021 16:14:18 +0200
Nuno Sá <nuno.sa@analog.com> wrote:

> This series adds some fixes and improvements for the ADIS library and
> devices. There are two fixes:
>  
> 1) On the library 'adis_init()' function, a call to 'adis_enable_irq()'
> was being done. That does not make sense because
> '__adis_initial_startup()' will reset the device and put the data ready
> pin in the default state. For some drivers, these could mean that we
> were leaving probe in a state different from the desired one.
> 2) The adis16480 driver was registering a managed reset action to put
> the device into sleep mode in the unbinding path. Well, not all devices
> supported by the driver support sleep mode.
>  
> The rest of the series is a minor improvement about passing the handling of
> enabling/disabling IRQs (for devices that cannot unmask the data ready
> pin) inside the library.
> 
> Nuno Sá (5):
>   iio: adis: do not disabe IRQs in 'adis_init()'
>   iio: adis: handle devices that cannot unmask the drdy pin
>   iio: adis16475: make use of the new unmasked_drdy flag
>   iio: adis16460: make use of the new unmasked_drdy flag
>   iio: adis16480: fix devices that do not support sleep mode

Hi Nuno.

Series looks good to me but I'd like it to sit on list a little longer before
I take any of it.

Would have been 'nice' to have had the two fixes at the start of the series
as they should probably go via stable whereas the 3 patches moving things
into the core are 5.16 material.

Looks like I should be fine picking two fixes up even in this order though so
not a big issue.

Thanks,

Jonathan

> 
>  drivers/iio/imu/adis.c         | 17 ++++++++++++++++-
>  drivers/iio/imu/adis16460.c    | 18 +-----------------
>  drivers/iio/imu/adis16475.c    | 19 +------------------
>  drivers/iio/imu/adis16480.c    | 14 +++++++++++---
>  drivers/iio/imu/adis_trigger.c |  4 ++++
>  include/linux/iio/imu/adis.h   |  2 ++
>  6 files changed, 35 insertions(+), 39 deletions(-)
> 