From: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmem: NVMEM_NINTENDO_OTP should depend on WII
Date: Thu, 16 Sep 2021 14:12:40 +0200 [thread overview]
Message-ID: <20210916121240.okknaglns4bjmczp@luna> (raw)
In-Reply-To: <01318920709dddc4d85fe895e2083ca0eee234d8.1631611652.git.geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]
Hi, thanks for this patch, once the Wii U platform will be added it will
need an additional test for WIIU, but for now this is:
Reviewed-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
On Tue, Sep 14, 2021 at 11:29:49AM +0200, Geert Uytterhoeven wrote:
> The Nintendo Wii and Wii U OTP is only present on Nintendo Wii and Wii U
> consoles. Hence add a dependency on WII, to prevent asking the user
> about this driver when configuring a kernel without Nintendo Wii and Wii
> U console support.
>
> Fixes: 3683b761fe3a10ad ("nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/nvmem/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index 39854d43758be3fb..da414617a54d4b99 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -109,6 +109,7 @@ config MTK_EFUSE
>
> config NVMEM_NINTENDO_OTP
> tristate "Nintendo Wii and Wii U OTP Support"
> + depends on WII || COMPILE_TEST
> help
> This is a driver exposing the OTP of a Nintendo Wii or Wii U console.
>
> --
> 2.25.1
--
Emmanuel Gil Peyrot
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] nvmem: NVMEM_NINTENDO_OTP should depend on WII
Date: Thu, 16 Sep 2021 14:12:40 +0200 [thread overview]
Message-ID: <20210916121240.okknaglns4bjmczp@luna> (raw)
In-Reply-To: <01318920709dddc4d85fe895e2083ca0eee234d8.1631611652.git.geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]
Hi, thanks for this patch, once the Wii U platform will be added it will
need an additional test for WIIU, but for now this is:
Reviewed-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
On Tue, Sep 14, 2021 at 11:29:49AM +0200, Geert Uytterhoeven wrote:
> The Nintendo Wii and Wii U OTP is only present on Nintendo Wii and Wii U
> consoles. Hence add a dependency on WII, to prevent asking the user
> about this driver when configuring a kernel without Nintendo Wii and Wii
> U console support.
>
> Fixes: 3683b761fe3a10ad ("nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/nvmem/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index 39854d43758be3fb..da414617a54d4b99 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -109,6 +109,7 @@ config MTK_EFUSE
>
> config NVMEM_NINTENDO_OTP
> tristate "Nintendo Wii and Wii U OTP Support"
> + depends on WII || COMPILE_TEST
> help
> This is a driver exposing the OTP of a Nintendo Wii or Wii U console.
>
> --
> 2.25.1
--
Emmanuel Gil Peyrot
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-16 12:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 9:29 [PATCH] nvmem: NVMEM_NINTENDO_OTP should depend on WII Geert Uytterhoeven
2021-09-14 9:29 ` Geert Uytterhoeven
2021-09-16 12:12 ` Emmanuel Gil Peyrot [this message]
2021-09-16 12:12 ` Emmanuel Gil Peyrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210916121240.okknaglns4bjmczp@luna \
--to=linkmauve@linkmauve.fr \
--cc=benh@kernel.crashing.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.