From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org,
o.rempel@pengutronix.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, aisheng.dong@nxp.com,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V4 3/6] remoteproc: imx_rproc: fix TCM io memory type
Date: Mon, 20 Sep 2021 10:59:20 -0600 [thread overview]
Message-ID: <20210920165920.GC2023964@p14s> (raw)
In-Reply-To: <20210910090621.3073540-4-peng.fan@oss.nxp.com>
On Fri, Sep 10, 2021 at 05:06:18PM +0800, Peng Fan (OSS) wrote:
> From: Dong Aisheng <aisheng.dong@nxp.com>
>
> is_iomem was introduced in the commit 40df0a91b2a5 ("remoteproc: add
> is_iomem to da_to_va"), but the driver seemed missed to provide the io
> type correctly.
> This patch updates remoteproc driver to indicate the TCM on IMX are io
> memories. Without the change, remoteproc kick will fail.
If the kick fails on all these platforms, why was patch 40df0a91b2a5 ever
submitted at all? To me this is a serious problem that should have been caught
before it got sent to the mailing list.
I have applied this patch but based on the blatant problems this patchset
underscores, how can I trust future patches coming from NXP?
>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Peng Fan <peng.fan@nxp.com>
> Reviewed-and-tested-by: Peng Fan <peng.fan@nxp.com>
> Fixes: 79806d32d5aa ("remoteproc: imx_rproc: support i.MX8MN/P")
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/remoteproc/imx_rproc.c | 35 ++++++++++++++++++++--------------
> 1 file changed, 21 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index d88f76f5305eb..71dcc6dd32e40 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -71,6 +71,7 @@ struct imx_rproc_mem {
> /* att flags */
> /* M4 own area. Can be mapped at probe */
> #define ATT_OWN BIT(1)
> +#define ATT_IOMEM BIT(2)
>
> /* address translation table */
> struct imx_rproc_att {
> @@ -117,7 +118,7 @@ struct imx_rproc {
> static const struct imx_rproc_att imx_rproc_att_imx8mn[] = {
> /* dev addr , sys addr , size , flags */
> /* ITCM */
> - { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN },
> + { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM },
> /* OCRAM_S */
> { 0x00180000, 0x00180000, 0x00009000, 0 },
> /* OCRAM */
> @@ -131,7 +132,7 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = {
> /* DDR (Code) - alias */
> { 0x10000000, 0x40000000, 0x0FFE0000, 0 },
> /* DTCM */
> - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN },
> + { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM },
> /* OCRAM_S - alias */
> { 0x20180000, 0x00180000, 0x00008000, ATT_OWN },
> /* OCRAM */
> @@ -147,7 +148,7 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = {
> static const struct imx_rproc_att imx_rproc_att_imx8mq[] = {
> /* dev addr , sys addr , size , flags */
> /* TCML - alias */
> - { 0x00000000, 0x007e0000, 0x00020000, 0 },
> + { 0x00000000, 0x007e0000, 0x00020000, ATT_IOMEM},
> /* OCRAM_S */
> { 0x00180000, 0x00180000, 0x00008000, 0 },
> /* OCRAM */
> @@ -159,9 +160,9 @@ static const struct imx_rproc_att imx_rproc_att_imx8mq[] = {
> /* DDR (Code) - alias */
> { 0x10000000, 0x80000000, 0x0FFE0000, 0 },
> /* TCML */
> - { 0x1FFE0000, 0x007E0000, 0x00020000, ATT_OWN },
> + { 0x1FFE0000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM},
> /* TCMU */
> - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN },
> + { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM},
> /* OCRAM_S */
> { 0x20180000, 0x00180000, 0x00008000, ATT_OWN },
> /* OCRAM */
> @@ -199,12 +200,12 @@ static const struct imx_rproc_att imx_rproc_att_imx7d[] = {
> /* OCRAM_PXP (Code) - alias */
> { 0x00940000, 0x00940000, 0x00008000, 0 },
> /* TCML (Code) */
> - { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN },
> + { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN | ATT_IOMEM },
> /* DDR (Code) - alias, first part of DDR (Data) */
> { 0x10000000, 0x80000000, 0x0FFF0000, 0 },
>
> /* TCMU (Data) */
> - { 0x20000000, 0x00800000, 0x00008000, ATT_OWN },
> + { 0x20000000, 0x00800000, 0x00008000, ATT_OWN | ATT_IOMEM },
> /* OCRAM (Data) */
> { 0x20200000, 0x00900000, 0x00020000, 0 },
> /* OCRAM_EPDC (Data) */
> @@ -218,18 +219,18 @@ static const struct imx_rproc_att imx_rproc_att_imx7d[] = {
> static const struct imx_rproc_att imx_rproc_att_imx6sx[] = {
> /* dev addr , sys addr , size , flags */
> /* TCML (M4 Boot Code) - alias */
> - { 0x00000000, 0x007F8000, 0x00008000, 0 },
> + { 0x00000000, 0x007F8000, 0x00008000, ATT_IOMEM },
> /* OCRAM_S (Code) */
> { 0x00180000, 0x008F8000, 0x00004000, 0 },
> /* OCRAM_S (Code) - alias */
> { 0x00180000, 0x008FC000, 0x00004000, 0 },
> /* TCML (Code) */
> - { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN },
> + { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN | ATT_IOMEM },
> /* DDR (Code) - alias, first part of DDR (Data) */
> { 0x10000000, 0x80000000, 0x0FFF8000, 0 },
>
> /* TCMU (Data) */
> - { 0x20000000, 0x00800000, 0x00008000, ATT_OWN },
> + { 0x20000000, 0x00800000, 0x00008000, ATT_OWN | ATT_IOMEM },
> /* OCRAM_S (Data) - alias? */
> { 0x208F8000, 0x008F8000, 0x00004000, 0 },
> /* DDR (Data) */
> @@ -341,7 +342,7 @@ static int imx_rproc_stop(struct rproc *rproc)
> }
>
> static int imx_rproc_da_to_sys(struct imx_rproc *priv, u64 da,
> - size_t len, u64 *sys)
> + size_t len, u64 *sys, bool *is_iomem)
> {
> const struct imx_rproc_dcfg *dcfg = priv->dcfg;
> int i;
> @@ -354,6 +355,8 @@ static int imx_rproc_da_to_sys(struct imx_rproc *priv, u64 da,
> unsigned int offset = da - att->da;
>
> *sys = att->sa + offset;
> + if (is_iomem)
> + *is_iomem = att->flags & ATT_IOMEM;
> return 0;
> }
> }
> @@ -377,7 +380,7 @@ static void *imx_rproc_da_to_va(struct rproc *rproc, u64 da, size_t len, bool *i
> * On device side we have many aliases, so we need to convert device
> * address (M4) to system bus address first.
> */
> - if (imx_rproc_da_to_sys(priv, da, len, &sys))
> + if (imx_rproc_da_to_sys(priv, da, len, &sys, is_iomem))
> return NULL;
>
> for (i = 0; i < IMX_RPROC_MEM_MAX; i++) {
> @@ -553,8 +556,12 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
> if (b >= IMX_RPROC_MEM_MAX)
> break;
>
> - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
> - att->sa, att->size);
> + if (att->flags & ATT_IOMEM)
> + priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
> + att->sa, att->size);
> + else
> + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev,
> + att->sa, att->size);
> if (!priv->mem[b].cpu_addr) {
> dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa);
> return -ENOMEM;
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org,
o.rempel@pengutronix.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, aisheng.dong@nxp.com,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V4 3/6] remoteproc: imx_rproc: fix TCM io memory type
Date: Mon, 20 Sep 2021 10:59:20 -0600 [thread overview]
Message-ID: <20210920165920.GC2023964@p14s> (raw)
In-Reply-To: <20210910090621.3073540-4-peng.fan@oss.nxp.com>
On Fri, Sep 10, 2021 at 05:06:18PM +0800, Peng Fan (OSS) wrote:
> From: Dong Aisheng <aisheng.dong@nxp.com>
>
> is_iomem was introduced in the commit 40df0a91b2a5 ("remoteproc: add
> is_iomem to da_to_va"), but the driver seemed missed to provide the io
> type correctly.
> This patch updates remoteproc driver to indicate the TCM on IMX are io
> memories. Without the change, remoteproc kick will fail.
If the kick fails on all these platforms, why was patch 40df0a91b2a5 ever
submitted at all? To me this is a serious problem that should have been caught
before it got sent to the mailing list.
I have applied this patch but based on the blatant problems this patchset
underscores, how can I trust future patches coming from NXP?
>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Peng Fan <peng.fan@nxp.com>
> Reviewed-and-tested-by: Peng Fan <peng.fan@nxp.com>
> Fixes: 79806d32d5aa ("remoteproc: imx_rproc: support i.MX8MN/P")
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/remoteproc/imx_rproc.c | 35 ++++++++++++++++++++--------------
> 1 file changed, 21 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index d88f76f5305eb..71dcc6dd32e40 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -71,6 +71,7 @@ struct imx_rproc_mem {
> /* att flags */
> /* M4 own area. Can be mapped at probe */
> #define ATT_OWN BIT(1)
> +#define ATT_IOMEM BIT(2)
>
> /* address translation table */
> struct imx_rproc_att {
> @@ -117,7 +118,7 @@ struct imx_rproc {
> static const struct imx_rproc_att imx_rproc_att_imx8mn[] = {
> /* dev addr , sys addr , size , flags */
> /* ITCM */
> - { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN },
> + { 0x00000000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM },
> /* OCRAM_S */
> { 0x00180000, 0x00180000, 0x00009000, 0 },
> /* OCRAM */
> @@ -131,7 +132,7 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = {
> /* DDR (Code) - alias */
> { 0x10000000, 0x40000000, 0x0FFE0000, 0 },
> /* DTCM */
> - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN },
> + { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM },
> /* OCRAM_S - alias */
> { 0x20180000, 0x00180000, 0x00008000, ATT_OWN },
> /* OCRAM */
> @@ -147,7 +148,7 @@ static const struct imx_rproc_att imx_rproc_att_imx8mn[] = {
> static const struct imx_rproc_att imx_rproc_att_imx8mq[] = {
> /* dev addr , sys addr , size , flags */
> /* TCML - alias */
> - { 0x00000000, 0x007e0000, 0x00020000, 0 },
> + { 0x00000000, 0x007e0000, 0x00020000, ATT_IOMEM},
> /* OCRAM_S */
> { 0x00180000, 0x00180000, 0x00008000, 0 },
> /* OCRAM */
> @@ -159,9 +160,9 @@ static const struct imx_rproc_att imx_rproc_att_imx8mq[] = {
> /* DDR (Code) - alias */
> { 0x10000000, 0x80000000, 0x0FFE0000, 0 },
> /* TCML */
> - { 0x1FFE0000, 0x007E0000, 0x00020000, ATT_OWN },
> + { 0x1FFE0000, 0x007E0000, 0x00020000, ATT_OWN | ATT_IOMEM},
> /* TCMU */
> - { 0x20000000, 0x00800000, 0x00020000, ATT_OWN },
> + { 0x20000000, 0x00800000, 0x00020000, ATT_OWN | ATT_IOMEM},
> /* OCRAM_S */
> { 0x20180000, 0x00180000, 0x00008000, ATT_OWN },
> /* OCRAM */
> @@ -199,12 +200,12 @@ static const struct imx_rproc_att imx_rproc_att_imx7d[] = {
> /* OCRAM_PXP (Code) - alias */
> { 0x00940000, 0x00940000, 0x00008000, 0 },
> /* TCML (Code) */
> - { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN },
> + { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN | ATT_IOMEM },
> /* DDR (Code) - alias, first part of DDR (Data) */
> { 0x10000000, 0x80000000, 0x0FFF0000, 0 },
>
> /* TCMU (Data) */
> - { 0x20000000, 0x00800000, 0x00008000, ATT_OWN },
> + { 0x20000000, 0x00800000, 0x00008000, ATT_OWN | ATT_IOMEM },
> /* OCRAM (Data) */
> { 0x20200000, 0x00900000, 0x00020000, 0 },
> /* OCRAM_EPDC (Data) */
> @@ -218,18 +219,18 @@ static const struct imx_rproc_att imx_rproc_att_imx7d[] = {
> static const struct imx_rproc_att imx_rproc_att_imx6sx[] = {
> /* dev addr , sys addr , size , flags */
> /* TCML (M4 Boot Code) - alias */
> - { 0x00000000, 0x007F8000, 0x00008000, 0 },
> + { 0x00000000, 0x007F8000, 0x00008000, ATT_IOMEM },
> /* OCRAM_S (Code) */
> { 0x00180000, 0x008F8000, 0x00004000, 0 },
> /* OCRAM_S (Code) - alias */
> { 0x00180000, 0x008FC000, 0x00004000, 0 },
> /* TCML (Code) */
> - { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN },
> + { 0x1FFF8000, 0x007F8000, 0x00008000, ATT_OWN | ATT_IOMEM },
> /* DDR (Code) - alias, first part of DDR (Data) */
> { 0x10000000, 0x80000000, 0x0FFF8000, 0 },
>
> /* TCMU (Data) */
> - { 0x20000000, 0x00800000, 0x00008000, ATT_OWN },
> + { 0x20000000, 0x00800000, 0x00008000, ATT_OWN | ATT_IOMEM },
> /* OCRAM_S (Data) - alias? */
> { 0x208F8000, 0x008F8000, 0x00004000, 0 },
> /* DDR (Data) */
> @@ -341,7 +342,7 @@ static int imx_rproc_stop(struct rproc *rproc)
> }
>
> static int imx_rproc_da_to_sys(struct imx_rproc *priv, u64 da,
> - size_t len, u64 *sys)
> + size_t len, u64 *sys, bool *is_iomem)
> {
> const struct imx_rproc_dcfg *dcfg = priv->dcfg;
> int i;
> @@ -354,6 +355,8 @@ static int imx_rproc_da_to_sys(struct imx_rproc *priv, u64 da,
> unsigned int offset = da - att->da;
>
> *sys = att->sa + offset;
> + if (is_iomem)
> + *is_iomem = att->flags & ATT_IOMEM;
> return 0;
> }
> }
> @@ -377,7 +380,7 @@ static void *imx_rproc_da_to_va(struct rproc *rproc, u64 da, size_t len, bool *i
> * On device side we have many aliases, so we need to convert device
> * address (M4) to system bus address first.
> */
> - if (imx_rproc_da_to_sys(priv, da, len, &sys))
> + if (imx_rproc_da_to_sys(priv, da, len, &sys, is_iomem))
> return NULL;
>
> for (i = 0; i < IMX_RPROC_MEM_MAX; i++) {
> @@ -553,8 +556,12 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
> if (b >= IMX_RPROC_MEM_MAX)
> break;
>
> - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
> - att->sa, att->size);
> + if (att->flags & ATT_IOMEM)
> + priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
> + att->sa, att->size);
> + else
> + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev,
> + att->sa, att->size);
> if (!priv->mem[b].cpu_addr) {
> dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa);
> return -ENOMEM;
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-09-20 17:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 9:06 [PATCH V4 0/6] remoteproc: elf_loader and imx fix Peng Fan (OSS)
2021-09-10 9:06 ` Peng Fan (OSS)
2021-09-10 9:06 ` [PATCH V4 1/6] remoteproc: elf_loader: fix loading segment when is_iomem true Peng Fan (OSS)
2021-09-10 9:06 ` Peng Fan (OSS)
2021-09-20 16:23 ` Mathieu Poirier
2021-09-20 16:23 ` Mathieu Poirier
2021-09-10 9:06 ` [PATCH V4 2/6] remoteproc: fix the wrong default value of is_iomem Peng Fan (OSS)
2021-09-10 9:06 ` Peng Fan (OSS)
2021-09-20 16:54 ` Mathieu Poirier
2021-09-20 16:54 ` Mathieu Poirier
2021-09-10 9:06 ` [PATCH V4 3/6] remoteproc: imx_rproc: fix TCM io memory type Peng Fan (OSS)
2021-09-10 9:06 ` Peng Fan (OSS)
2021-09-20 16:59 ` Mathieu Poirier [this message]
2021-09-20 16:59 ` Mathieu Poirier
2021-09-21 2:26 ` Peng Fan
2021-09-21 2:26 ` Peng Fan
2021-09-10 9:06 ` [PATCH V4 4/6] remoteproc: imx_rproc: fix ignoring mapping vdev regions Peng Fan (OSS)
2021-09-10 9:06 ` Peng Fan (OSS)
2021-09-10 9:06 ` [PATCH V4 5/6] remoteproc: imx_rproc: fix rsc-table name Peng Fan (OSS)
2021-09-10 9:06 ` Peng Fan (OSS)
2021-09-10 9:06 ` [PATCH V4 6/6] remoteproc: imx_rproc: change to ioremap_wc for dram Peng Fan (OSS)
2021-09-10 9:06 ` Peng Fan (OSS)
2021-09-20 17:00 ` Mathieu Poirier
2021-09-20 17:00 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920165920.GC2023964@p14s \
--to=mathieu.poirier@linaro.org \
--cc=aisheng.dong@nxp.com \
--cc=bjorn.andersson@linaro.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=ohad@wizery.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.