All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Mike Rapoport <rppt@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	David Hildenbrand <david@redhat.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Alex Bee <knaerzche@gmail.com>, Will Deacon <will@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [BUG 5.14] arm64/mm: dma memory mapping fails (in some cases)
Date: Tue, 21 Sep 2021 17:38:05 +0200	[thread overview]
Message-ID: <20210921153805.GA29952@lst.de> (raw)
In-Reply-To: <YUmnEoifUsnvAiuV@kernel.org>

On Tue, Sep 21, 2021 at 12:34:10PM +0300, Mike Rapoport wrote:
> > It doesn't create any new mappings.  The only real issue is that it
> > does the wrong thing for RAM in a way that might not be noticed on
> > simple (x86/PC) platforms.
> 
> But if the mapping request was rejected by devm_ioremap_resource() because
> of an attempt to map RAM, why we would get to dma_map_resource() at all? 

dma_map_resource takes a phys_addr_t that could come from anywhere.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Mike Rapoport <rppt@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	David Hildenbrand <david@redhat.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Alex Bee <knaerzche@gmail.com>, Will Deacon <will@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [BUG 5.14] arm64/mm: dma memory mapping fails (in some cases)
Date: Tue, 21 Sep 2021 17:38:05 +0200	[thread overview]
Message-ID: <20210921153805.GA29952@lst.de> (raw)
In-Reply-To: <YUmnEoifUsnvAiuV@kernel.org>

On Tue, Sep 21, 2021 at 12:34:10PM +0300, Mike Rapoport wrote:
> > It doesn't create any new mappings.  The only real issue is that it
> > does the wrong thing for RAM in a way that might not be noticed on
> > simple (x86/PC) platforms.
> 
> But if the mapping request was rejected by devm_ioremap_resource() because
> of an attempt to map RAM, why we would get to dma_map_resource() at all? 

dma_map_resource takes a phys_addr_t that could come from anywhere.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-21 15:38 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24 13:40 [BUG 5.14] arm64/mm: dma memory mapping fails (in some cases) Alex Bee
2021-08-24 13:40 ` Alex Bee
2021-08-24 17:37 ` Catalin Marinas
2021-08-24 17:37   ` Catalin Marinas
2021-08-24 18:06   ` Robin Murphy
2021-08-24 18:06     ` Robin Murphy
2021-08-24 18:28   ` Mike Rapoport
2021-08-24 18:28     ` Mike Rapoport
2021-08-24 18:46     ` Robin Murphy
2021-08-24 18:46       ` Robin Murphy
2021-08-24 18:59       ` David Hildenbrand
2021-08-24 18:59         ` David Hildenbrand
2021-08-25 10:20         ` Catalin Marinas
2021-08-25 10:20           ` Catalin Marinas
2021-08-25 10:28           ` Will Deacon
2021-08-25 10:28             ` Will Deacon
2021-08-25 10:32             ` Will Deacon
2021-08-25 10:32               ` Will Deacon
2021-08-25 10:33             ` Robin Murphy
2021-08-25 10:33               ` Robin Murphy
2021-08-25 10:38           ` David Hildenbrand
2021-08-25 10:38             ` David Hildenbrand
2021-08-25 10:54             ` Mike Rapoport
2021-08-25 10:54               ` Mike Rapoport
2021-08-25 10:55             ` Catalin Marinas
2021-08-25 10:55               ` Catalin Marinas
2021-08-25 11:12               ` David Hildenbrand
2021-08-25 11:12                 ` David Hildenbrand
2021-08-25 17:15                 ` Catalin Marinas
2021-08-25 17:15                   ` Catalin Marinas
2021-08-25 10:58             ` Robin Murphy
2021-08-25 10:58               ` Robin Murphy
2021-08-25 11:21               ` David Hildenbrand
2021-08-25 11:21                 ` David Hildenbrand
2021-08-25 10:52           ` Mike Rapoport
2021-08-25 10:52             ` Mike Rapoport
2021-09-17 21:22           ` Mike Rapoport
2021-09-17 21:22             ` Mike Rapoport
2021-09-18  5:18             ` Christoph Hellwig
2021-09-18  5:18               ` Christoph Hellwig
2021-09-18  8:37               ` Mike Rapoport
2021-09-18  8:37                 ` Mike Rapoport
2021-09-18 11:39                 ` Mike Rapoport
2021-09-18 11:39                   ` Mike Rapoport
2021-09-20 10:57                   ` Catalin Marinas
2021-09-20 10:57                     ` Catalin Marinas
2021-09-21  8:20                     ` Christoph Hellwig
2021-09-21  8:20                       ` Christoph Hellwig
2021-09-21  9:34                       ` Mike Rapoport
2021-09-21  9:34                         ` Mike Rapoport
2021-09-21 15:38                         ` Christoph Hellwig [this message]
2021-09-21 15:38                           ` Christoph Hellwig
2021-09-22  7:22                           ` Mike Rapoport
2021-09-22  7:22                             ` Mike Rapoport
2021-09-20 11:13               ` David Hildenbrand
2021-09-20 11:13                 ` David Hildenbrand
2021-08-24 20:14     ` Alex Bee
2021-08-24 20:14       ` Alex Bee
2021-08-25  4:39       ` Mike Rapoport
2021-08-25  4:39         ` Mike Rapoport
2021-08-25 10:00         ` Alex Bee
2021-08-25 10:00           ` Alex Bee
2021-08-24 20:07   ` Alex Bee
2021-08-24 20:07     ` Alex Bee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210921153805.GA29952@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=david@redhat.com \
    --cc=knaerzche@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=robin.murphy@arm.com \
    --cc=rppt@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.