From: Fernando Ramos <greenfoo@u92.eu>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, sean@poorly.run,
linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: [PATCH v2 01/17] drm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()
Date: Fri, 24 Sep 2021 08:43:08 +0200 [thread overview]
Message-ID: <20210924064324.229457-2-greenfoo@u92.eu> (raw)
In-Reply-To: <20210924064324.229457-1-greenfoo@u92.eu>
As requested in Documentation/gpu/todo.rst, replace the boilerplate code
surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN()
and DRM_MODESET_LOCK_ALL_END()
Signed-off-by: Fernando Ramos <greenfoo@u92.eu>
---
drivers/gpu/drm/drm_client_modeset.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c
index ced09c7c06f9..5f5184f071ed 100644
--- a/drivers/gpu/drm/drm_client_modeset.c
+++ b/drivers/gpu/drm/drm_client_modeset.c
@@ -574,6 +574,7 @@ static bool drm_client_firmware_config(struct drm_client_dev *client,
int num_connectors_detected = 0;
int num_tiled_conns = 0;
struct drm_modeset_acquire_ctx ctx;
+ int err;
if (!drm_drv_uses_atomic_modeset(dev))
return false;
@@ -585,10 +586,7 @@ static bool drm_client_firmware_config(struct drm_client_dev *client,
if (!save_enabled)
return false;
- drm_modeset_acquire_init(&ctx, 0);
-
- while (drm_modeset_lock_all_ctx(dev, &ctx) != 0)
- drm_modeset_backoff(&ctx);
+ DRM_MODESET_LOCK_ALL_BEGIN(dev, ctx, 0, err);
memcpy(save_enabled, enabled, count);
mask = GENMASK(count - 1, 0);
@@ -743,8 +741,7 @@ static bool drm_client_firmware_config(struct drm_client_dev *client,
ret = false;
}
- drm_modeset_drop_locks(&ctx);
- drm_modeset_acquire_fini(&ctx);
+ DRM_MODESET_LOCK_ALL_END(dev, ctx, err);
kfree(save_enabled);
return ret;
--
2.33.0
WARNING: multiple messages have this Message-ID (diff)
From: Fernando Ramos <greenfoo@u92.eu>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, sean@poorly.run,
linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: [Intel-gfx] [PATCH v2 01/17] drm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()
Date: Fri, 24 Sep 2021 08:43:08 +0200 [thread overview]
Message-ID: <20210924064324.229457-2-greenfoo@u92.eu> (raw)
In-Reply-To: <20210924064324.229457-1-greenfoo@u92.eu>
As requested in Documentation/gpu/todo.rst, replace the boilerplate code
surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN()
and DRM_MODESET_LOCK_ALL_END()
Signed-off-by: Fernando Ramos <greenfoo@u92.eu>
---
drivers/gpu/drm/drm_client_modeset.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c
index ced09c7c06f9..5f5184f071ed 100644
--- a/drivers/gpu/drm/drm_client_modeset.c
+++ b/drivers/gpu/drm/drm_client_modeset.c
@@ -574,6 +574,7 @@ static bool drm_client_firmware_config(struct drm_client_dev *client,
int num_connectors_detected = 0;
int num_tiled_conns = 0;
struct drm_modeset_acquire_ctx ctx;
+ int err;
if (!drm_drv_uses_atomic_modeset(dev))
return false;
@@ -585,10 +586,7 @@ static bool drm_client_firmware_config(struct drm_client_dev *client,
if (!save_enabled)
return false;
- drm_modeset_acquire_init(&ctx, 0);
-
- while (drm_modeset_lock_all_ctx(dev, &ctx) != 0)
- drm_modeset_backoff(&ctx);
+ DRM_MODESET_LOCK_ALL_BEGIN(dev, ctx, 0, err);
memcpy(save_enabled, enabled, count);
mask = GENMASK(count - 1, 0);
@@ -743,8 +741,7 @@ static bool drm_client_firmware_config(struct drm_client_dev *client,
ret = false;
}
- drm_modeset_drop_locks(&ctx);
- drm_modeset_acquire_fini(&ctx);
+ DRM_MODESET_LOCK_ALL_END(dev, ctx, err);
kfree(save_enabled);
return ret;
--
2.33.0
WARNING: multiple messages have this Message-ID (diff)
From: Fernando Ramos <greenfoo@u92.eu>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, sean@poorly.run,
linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: [Nouveau] [PATCH v2 01/17] drm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()
Date: Fri, 24 Sep 2021 08:43:08 +0200 [thread overview]
Message-ID: <20210924064324.229457-2-greenfoo@u92.eu> (raw)
In-Reply-To: <20210924064324.229457-1-greenfoo@u92.eu>
As requested in Documentation/gpu/todo.rst, replace the boilerplate code
surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN()
and DRM_MODESET_LOCK_ALL_END()
Signed-off-by: Fernando Ramos <greenfoo@u92.eu>
---
drivers/gpu/drm/drm_client_modeset.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c
index ced09c7c06f9..5f5184f071ed 100644
--- a/drivers/gpu/drm/drm_client_modeset.c
+++ b/drivers/gpu/drm/drm_client_modeset.c
@@ -574,6 +574,7 @@ static bool drm_client_firmware_config(struct drm_client_dev *client,
int num_connectors_detected = 0;
int num_tiled_conns = 0;
struct drm_modeset_acquire_ctx ctx;
+ int err;
if (!drm_drv_uses_atomic_modeset(dev))
return false;
@@ -585,10 +586,7 @@ static bool drm_client_firmware_config(struct drm_client_dev *client,
if (!save_enabled)
return false;
- drm_modeset_acquire_init(&ctx, 0);
-
- while (drm_modeset_lock_all_ctx(dev, &ctx) != 0)
- drm_modeset_backoff(&ctx);
+ DRM_MODESET_LOCK_ALL_BEGIN(dev, ctx, 0, err);
memcpy(save_enabled, enabled, count);
mask = GENMASK(count - 1, 0);
@@ -743,8 +741,7 @@ static bool drm_client_firmware_config(struct drm_client_dev *client,
ret = false;
}
- drm_modeset_drop_locks(&ctx);
- drm_modeset_acquire_fini(&ctx);
+ DRM_MODESET_LOCK_ALL_END(dev, ctx, err);
kfree(save_enabled);
return ret;
--
2.33.0
next prev parent reply other threads:[~2021-09-24 6:43 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 6:43 [PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` Fernando Ramos [this message]
2021-09-24 6:43 ` [Nouveau] [PATCH v2 01/17] drm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN() Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 02/17] drm/i915: " Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 03/17] drm/msm: " Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 04/17] drm: cleanup: drm_modeset_lock_all() " Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 05/17] drm/vmwgfx: " Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 06/17] drm/tegra: " Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 07/17] drm/shmobile: " Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 08/17] drm/radeon: " Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 09/17] drm/omapdrm: " Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 10/17] drm/nouveau: " Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 11/17] drm/msm: " Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 12/17] drm/i915: " Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 13/17] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() part 2 Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 14/17] drm/gma500: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 15/17] drm/amd: " Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 16/17] drm: cleanup: remove drm_modeset_(un)lock_all() Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 6:43 ` [PATCH v2 17/17] doc: drm: remove TODO entry regarding DRM_MODSET_LOCK_ALL cleanup Fernando Ramos
2021-09-24 6:43 ` [Nouveau] " Fernando Ramos
2021-09-24 6:43 ` [Intel-gfx] " Fernando Ramos
2021-09-24 7:04 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible (rev2) Patchwork
2021-10-01 18:36 ` [PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible Sean Paul
2021-10-01 18:36 ` [Intel-gfx] " Sean Paul
2021-10-01 18:36 ` [Nouveau] " Sean Paul
2021-10-01 19:00 ` Ville Syrjälä
2021-10-01 19:00 ` [Intel-gfx] " Ville Syrjälä
2021-10-01 19:00 ` [Nouveau] " Ville Syrjälä
2021-10-01 20:48 ` Sean Paul
2021-10-01 20:48 ` [Intel-gfx] " Sean Paul
2021-10-01 20:48 ` [Nouveau] " Sean Paul
2021-10-01 22:05 ` Ville Syrjälä
2021-10-01 22:05 ` [Intel-gfx] " Ville Syrjälä
2021-10-01 22:05 ` Ville Syrjälä
2021-10-02 2:30 ` [Intel-gfx] " Ville Syrjälä
2021-10-02 2:30 ` [Nouveau] " Ville Syrjälä
2021-10-02 7:13 ` Fernando Ramos
2021-10-02 7:13 ` [Nouveau] " Fernando Ramos
2021-10-02 17:28 ` Fernando Ramos
2021-10-02 17:28 ` [Nouveau] " Fernando Ramos
2021-10-04 8:01 ` Ville Syrjälä
2021-10-04 8:01 ` Ville Syrjälä
2021-10-02 22:32 ` Fernando Ramos
2021-10-02 22:32 ` [Nouveau] " Fernando Ramos
2021-10-04 8:19 ` Ville Syrjälä
2021-10-04 8:19 ` [Nouveau] " Ville Syrjälä
2021-10-04 8:39 ` Jani Nikula
2021-10-04 8:39 ` [Nouveau] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924064324.229457-2-greenfoo@u92.eu \
--to=greenfoo@u92.eu \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.