From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>, Ariel Elior <aelior@marvell.com>,
Bin Luo <luobin9@huawei.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Coiby Xu <coiby.xu@gmail.com>,
Derek Chickles <dchickles@marvell.com>,
drivers@pensando.io, Eric Dumazet <eric.dumazet@gmail.com>,
Felix Manlunas <fmanlunas@marvell.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Geetha sowjanya <gakula@marvell.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
GR-everest-linux-l2@marvell.com, GR-Linux-NIC-Dev@marvell.com,
hariprasad <hkelam@marvell.com>, Ido Schimmel <idosch@nvidia.com>,
intel-wired-lan@lists.osuosl.org,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Jerin Jacob <jerinj@marvell.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Jiri Pirko <jiri@nvidia.com>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Linu Cherian <lcherian@marvell.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-staging@lists.linux.dev,
Manish Chopra <manishc@marvell.com>,
Michael Chan <michael.chan@broadcom.com>,
Moshe Shemesh <moshe@nvidia.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com,
Richard Cochran <richardcochran@gmail.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Salil Mehta <salil.mehta@huawei.com>,
Satanand Burla <sburla@marvell.com>,
Shannon Nelson <snelson@pensando.io>,
Shay Drory <shayd@nvidia.com>,
Simon Horman <simon.horman@corigine.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Sunil Goutham <sgoutham@marvell.com>,
Taras Chornyi <tchornyi@marvell.com>,
Tariq Toukan <tariqt@nvidia.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
UNGLinuxDriver@microchip.com, Vadym Kochan <vkochan@marvell.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>
Subject: Re: [PATCH net-next v1 4/5] net/mlx5: Register separate reload devlink ops for multiport device
Date: Wed, 29 Sep 2021 07:26:31 -0700 [thread overview]
Message-ID: <20210929072631.437ffad9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <YVR1PKQjsBfvUTPU@unreal>
On Wed, 29 Sep 2021 17:16:28 +0300 Leon Romanovsky wrote:
> > > @@ -808,6 +812,9 @@ int mlx5_devlink_register(struct devlink *devlink)
> > > if (err)
> > > goto traps_reg_err;
> > >
> > > + if (!mlx5_core_is_mp_slave(dev))
> > > + devlink_set_ops(devlink, &mlx5_devlink_reload);
> >
> > Does this work? Where do you make a copy of the ops? 🤔 You can't modify
> > the driver-global ops, to state the obvious.
>
> devlink_ops pointer is not constant at this stage, so why can't I copy
> reload_* pointers to the "main" devlink ops?
>
> I wanted to avoid to copy all pointers.
Hm. I must be missing a key piece here. IIUC you want to have different
ops based on some device property. But there is only one
static struct devlink_ops mlx5_devlink_ops;
so how can two devlink instances in the system use that and have
different ops without a copy?
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v1 4/5] net/mlx5: Register separate reload devlink ops for multiport device
Date: Wed, 29 Sep 2021 07:26:31 -0700 [thread overview]
Message-ID: <20210929072631.437ffad9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <YVR1PKQjsBfvUTPU@unreal>
On Wed, 29 Sep 2021 17:16:28 +0300 Leon Romanovsky wrote:
> > > @@ -808,6 +812,9 @@ int mlx5_devlink_register(struct devlink *devlink)
> > > if (err)
> > > goto traps_reg_err;
> > >
> > > + if (!mlx5_core_is_mp_slave(dev))
> > > + devlink_set_ops(devlink, &mlx5_devlink_reload);
> >
> > Does this work? Where do you make a copy of the ops? ? You can't modify
> > the driver-global ops, to state the obvious.
>
> devlink_ops pointer is not constant at this stage, so why can't I copy
> reload_* pointers to the "main" devlink ops?
>
> I wanted to avoid to copy all pointers.
Hm. I must be missing a key piece here. IIUC you want to have different
ops based on some device property. But there is only one
static struct devlink_ops mlx5_devlink_ops;
so how can two devlink instances in the system use that and have
different ops without a copy?
next prev parent reply other threads:[~2021-09-29 14:26 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 12:00 [PATCH net-next v1 0/5] Devlink reload and missed notifications fix Leon Romanovsky
2021-09-29 12:00 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-29 12:00 ` [PATCH net-next v1 1/5] devlink: Add missed notifications iterators Leon Romanovsky
2021-09-29 12:00 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-29 13:29 ` Vladimir Oltean
2021-09-29 13:29 ` [Intel-wired-lan] " Vladimir Oltean
2021-09-29 12:00 ` [PATCH net-next v1 2/5] devlink: Allow modification of devlink ops Leon Romanovsky
2021-09-29 12:00 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-29 12:00 ` [PATCH net-next v1 3/5] devlink: Allow set specific ops callbacks dynamically Leon Romanovsky
2021-09-29 12:00 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-29 12:25 ` Greg Kroah-Hartman
2021-09-29 12:25 ` [Intel-wired-lan] " Greg Kroah-Hartman
2021-09-29 12:58 ` Leon Romanovsky
2021-09-29 12:58 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-29 12:00 ` [PATCH net-next v1 4/5] net/mlx5: Register separate reload devlink ops for multiport device Leon Romanovsky
2021-09-29 12:00 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-29 13:55 ` Jakub Kicinski
2021-09-29 13:55 ` [Intel-wired-lan] " Jakub Kicinski
2021-09-29 14:16 ` Leon Romanovsky
2021-09-29 14:16 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-29 14:26 ` Jakub Kicinski [this message]
2021-09-29 14:26 ` Jakub Kicinski
2021-09-29 14:31 ` Leon Romanovsky
2021-09-29 14:31 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-29 14:35 ` Jakub Kicinski
2021-09-29 14:35 ` [Intel-wired-lan] " Jakub Kicinski
2021-09-29 15:24 ` Leon Romanovsky
2021-09-29 15:24 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-29 12:00 ` [PATCH net-next v1 5/5] devlink: Delete reload enable/disable interface Leon Romanovsky
2021-09-29 12:00 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-29 13:40 ` [PATCH net-next v1 0/5] Devlink reload and missed notifications fix Jakub Kicinski
2021-09-29 13:40 ` [Intel-wired-lan] " Jakub Kicinski
2021-09-29 13:46 ` Vladimir Oltean
2021-09-29 13:46 ` [Intel-wired-lan] " Vladimir Oltean
2021-09-29 13:56 ` Jakub Kicinski
2021-09-29 13:56 ` [Intel-wired-lan] " Jakub Kicinski
2021-09-29 14:20 ` Leon Romanovsky
2021-09-29 14:20 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-29 14:13 ` Leon Romanovsky
2021-09-29 14:13 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-29 14:39 ` Jakub Kicinski
2021-09-29 14:39 ` [Intel-wired-lan] " Jakub Kicinski
2021-09-29 15:31 ` Leon Romanovsky
2021-09-29 15:31 ` [Intel-wired-lan] " Leon Romanovsky
2021-09-29 17:55 ` Jakub Kicinski
2021-09-29 17:55 ` [Intel-wired-lan] " Jakub Kicinski
2021-09-29 19:11 ` Leon Romanovsky
2021-09-29 19:11 ` [Intel-wired-lan] " Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929072631.437ffad9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=aelior@marvell.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=claudiu.manoil@nxp.com \
--cc=coiby.xu@gmail.com \
--cc=davem@davemloft.net \
--cc=dchickles@marvell.com \
--cc=drivers@pensando.io \
--cc=eric.dumazet@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=fmanlunas@marvell.com \
--cc=gakula@marvell.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkelam@marvell.com \
--cc=idosch@nvidia.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ioana.ciornei@nxp.com \
--cc=jerinj@marvell.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@nvidia.com \
--cc=jonathan.lemon@gmail.com \
--cc=lcherian@marvell.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=luobin9@huawei.com \
--cc=manishc@marvell.com \
--cc=michael.chan@broadcom.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=sbhatta@marvell.com \
--cc=sburla@marvell.com \
--cc=sgoutham@marvell.com \
--cc=shayd@nvidia.com \
--cc=simon.horman@corigine.com \
--cc=snelson@pensando.io \
--cc=tariqt@nvidia.com \
--cc=tchornyi@marvell.com \
--cc=vivien.didelot@gmail.com \
--cc=vkochan@marvell.com \
--cc=vladimir.oltean@nxp.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.