From: Andreas Rammhold <andreas@rammhold.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Heiko Stübner" <heiko@sntech.de>,
netdev@vger.kernel.org, "Punit Agrawal" <punitagrawal@gmail.com>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, davem@davemloft.net,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
"Michael Riesch" <michael.riesch@wolfvision.net>
Subject: Re: [PATCH] net: stmmac: dwmac-rk: Fix ethernet on rk3399 based devices
Date: Sat, 2 Oct 2021 23:33:03 +0200 [thread overview]
Message-ID: <20211002213303.bofdao6ar7wvodka@wrt> (raw)
In-Reply-To: <20211001160238.4335a83d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 16:02 01.10.21, Jakub Kicinski wrote:
> On Wed, 29 Sep 2021 23:02:35 +0200 Heiko Stübner wrote:
> > Am Mittwoch, 29. September 2021, 15:50:49 CEST schrieb Punit Agrawal:
> > > Commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings")
> > > while getting rid of a runtime PM warning ended up breaking ethernet
> > > on rk3399 based devices. By dropping an extra reference to the device,
> > > the commit ends up enabling suspend / resume of the ethernet device -
> > > which appears to be broken.
> > >
> > > While the issue with runtime pm is being investigated, partially
> > > revert commit 2d26f6e39afb to restore the network on rk3399.
> > >
> > > Fixes: 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings")
> > > Suggested-by: Heiko Stuebner <heiko@sntech.de>
> > > Signed-off-by: Punit Agrawal <punitagrawal@gmail.com>
> > > Cc: Michael Riesch <michael.riesch@wolfvision.net>
> >
> > On a rk3399-puma which has the described issue,
> > Tested-by: Heiko Stuebner <heiko@sntech.de>
>
> Applied, thanks!
This also fixed the issue on a RockPi4.
Will any of you submit this to the stable kernels (as this broke within
3.13 for me) or shall I do that?
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Rammhold <andreas@rammhold.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Heiko Stübner" <heiko@sntech.de>,
netdev@vger.kernel.org, "Punit Agrawal" <punitagrawal@gmail.com>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, davem@davemloft.net,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
"Michael Riesch" <michael.riesch@wolfvision.net>
Subject: Re: [PATCH] net: stmmac: dwmac-rk: Fix ethernet on rk3399 based devices
Date: Sat, 2 Oct 2021 23:33:03 +0200 [thread overview]
Message-ID: <20211002213303.bofdao6ar7wvodka@wrt> (raw)
In-Reply-To: <20211001160238.4335a83d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 16:02 01.10.21, Jakub Kicinski wrote:
> On Wed, 29 Sep 2021 23:02:35 +0200 Heiko Stübner wrote:
> > Am Mittwoch, 29. September 2021, 15:50:49 CEST schrieb Punit Agrawal:
> > > Commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings")
> > > while getting rid of a runtime PM warning ended up breaking ethernet
> > > on rk3399 based devices. By dropping an extra reference to the device,
> > > the commit ends up enabling suspend / resume of the ethernet device -
> > > which appears to be broken.
> > >
> > > While the issue with runtime pm is being investigated, partially
> > > revert commit 2d26f6e39afb to restore the network on rk3399.
> > >
> > > Fixes: 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings")
> > > Suggested-by: Heiko Stuebner <heiko@sntech.de>
> > > Signed-off-by: Punit Agrawal <punitagrawal@gmail.com>
> > > Cc: Michael Riesch <michael.riesch@wolfvision.net>
> >
> > On a rk3399-puma which has the described issue,
> > Tested-by: Heiko Stuebner <heiko@sntech.de>
>
> Applied, thanks!
This also fixed the issue on a RockPi4.
Will any of you submit this to the stable kernels (as this broke within
3.13 for me) or shall I do that?
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Rammhold <andreas@rammhold.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Heiko Stübner" <heiko@sntech.de>,
netdev@vger.kernel.org, "Punit Agrawal" <punitagrawal@gmail.com>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, davem@davemloft.net,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
"Michael Riesch" <michael.riesch@wolfvision.net>
Subject: Re: [PATCH] net: stmmac: dwmac-rk: Fix ethernet on rk3399 based devices
Date: Sat, 2 Oct 2021 23:33:03 +0200 [thread overview]
Message-ID: <20211002213303.bofdao6ar7wvodka@wrt> (raw)
In-Reply-To: <20211001160238.4335a83d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 16:02 01.10.21, Jakub Kicinski wrote:
> On Wed, 29 Sep 2021 23:02:35 +0200 Heiko Stübner wrote:
> > Am Mittwoch, 29. September 2021, 15:50:49 CEST schrieb Punit Agrawal:
> > > Commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings")
> > > while getting rid of a runtime PM warning ended up breaking ethernet
> > > on rk3399 based devices. By dropping an extra reference to the device,
> > > the commit ends up enabling suspend / resume of the ethernet device -
> > > which appears to be broken.
> > >
> > > While the issue with runtime pm is being investigated, partially
> > > revert commit 2d26f6e39afb to restore the network on rk3399.
> > >
> > > Fixes: 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings")
> > > Suggested-by: Heiko Stuebner <heiko@sntech.de>
> > > Signed-off-by: Punit Agrawal <punitagrawal@gmail.com>
> > > Cc: Michael Riesch <michael.riesch@wolfvision.net>
> >
> > On a rk3399-puma which has the described issue,
> > Tested-by: Heiko Stuebner <heiko@sntech.de>
>
> Applied, thanks!
This also fixed the issue on a RockPi4.
Will any of you submit this to the stable kernels (as this broke within
3.13 for me) or shall I do that?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-02 21:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 13:50 [PATCH] net: stmmac: dwmac-rk: Fix ethernet on rk3399 based devices Punit Agrawal
2021-09-29 13:50 ` Punit Agrawal
2021-09-29 13:50 ` Punit Agrawal
2021-09-29 21:02 ` Heiko Stübner
2021-09-29 21:02 ` Heiko Stübner
2021-09-29 21:02 ` Heiko Stübner
2021-10-01 23:02 ` Jakub Kicinski
2021-10-01 23:02 ` Jakub Kicinski
2021-10-01 23:02 ` Jakub Kicinski
2021-10-02 21:33 ` Andreas Rammhold [this message]
2021-10-02 21:33 ` Andreas Rammhold
2021-10-02 21:33 ` Andreas Rammhold
2021-10-03 0:20 ` Jakub Kicinski
2021-10-03 0:20 ` Jakub Kicinski
2021-10-03 0:20 ` Jakub Kicinski
2021-10-03 0:41 ` Andreas Rammhold
2021-10-03 0:41 ` Andreas Rammhold
2021-10-03 0:41 ` Andreas Rammhold
2021-10-03 9:15 ` Heiko Stübner
2021-10-03 9:15 ` Heiko Stübner
2021-10-03 9:15 ` Heiko Stübner
2021-10-04 12:06 ` Punit Agrawal
2021-10-04 12:06 ` Punit Agrawal
2021-10-04 12:06 ` Punit Agrawal
2021-10-05 9:08 ` andreas
2021-10-05 9:08 ` andreas
2021-10-05 9:08 ` andreas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211002213303.bofdao6ar7wvodka@wrt \
--to=andreas@rammhold.de \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=heiko@sntech.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=punitagrawal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.