All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, "Albert Ou" <aou@eecs.berkeley.edu>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Borislav Petkov" <bp@alien8.de>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Chris Zankel" <chris@zankel.net>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Greentime Hu" <green.hu@gmail.com>,
	"Guo Ren" <guoren@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Helge Deller" <deller@gmx.de>, "Ingo Molnar" <mingo@redhat.com>,
	"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Jonas Bonn" <jonas@southpole.se>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Julien Thierry" <jthierry@redhat.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
	"Ley Foon Tan" <ley.foon.tan@intel.com>,
	"Marc Zyngier" <maz@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Matt Turner" <mattst88@gmail.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Michal Marek" <michal.lkml@markovi.net>,
	"Michal Simek" <monstr@monstr.eu>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Nick Hu" <nickhu@andestech.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Paul Mackerras" <paulus@samba.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Rich Felker" <dalias@libc.org>,
	"Richard Henderson" <rth@twiddle.net>,
	"Rob Herring" <robh@kernel.org>,
	"Robert Richter" <rric@kernel.org>,
	"Russell King" <linux@armlinux.org.uk>,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Stafford Horne" <shorne@gmail.com>,
	"Stefan Kristiansson" <stefan.kristiansson@saunalahti.fi>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Vincent Chen" <deanbo422@gmail.com>,
	"Vineet Gupta" <vgupta@kernel.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Will Deacon" <will@kernel.org>,
	"William Cohen" <wcohen@redhat.com>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org,
	linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org,
	openrisc@lists.librecores.org, sparclinux@vger.kernel.org,
	uclinux-h8-devel@lists.sourceforge.jp, x86@kernel.org
Subject: Re: [PATCH 2/2] kbuild: use more subdir- for visiting subdirectories while cleaning
Date: Tue, 12 Oct 2021 23:45:47 -0700	[thread overview]
Message-ID: <202110122345.4B8FE35AED@keescook> (raw)
In-Reply-To: <20211013063622.548590-2-masahiroy@kernel.org>

On Wed, Oct 13, 2021 at 03:36:22PM +0900, Masahiro Yamada wrote:
> Documentation/kbuild/makefiles.rst suggests to use "archclean" for
> cleaning arch/$(SRCARCH)/boot/.
> 
> Since commit d92cc4d51643 ("kbuild: require all architectures to have
> arch/$(SRCARCH)/Kbuild"), we can use the "subdir- += boot" trick for
> all architectures. This can take advantage of the parallel option (-j)
> for "make clean".
> 
> I also cleaned up the comments. The "archdep" target does not exist.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

I like the clean-up!

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, "Albert Ou" <aou@eecs.berkeley.edu>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Borislav Petkov" <bp@alien8.de>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Chris Zankel" <chris@zankel.net>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Greentime Hu" <green.hu@gmail.com>,
	"Guo Ren" <guoren@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Helge Deller" <deller@gmx.de>, "Ingo Molnar" <mingo@redhat.com>,
	"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Jonas Bonn" <jonas@southpole.se>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Julien Thierry" <jthierry@redhat.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
	"Ley Foon Tan" <ley.foon.tan@intel.com>,
	"Marc Zyngier" <maz@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Matt Turner" <mattst88@gmail.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Michal Marek" <michal.lkml@markovi.net>,
	"Michal Simek" <monstr@monstr.eu>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Nick Hu" <nickhu@andestech.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Paul Mackerras" <paulus@samba.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Rich Felker" <dalias@libc.org>,
	"Richard Henderson" <rth@twiddle.net>,
	"Rob Herring" <robh@kernel.org>,
	"Robert Richter" <rric@kernel.org>,
	"Russell King" <linux@armlinux.org.uk>,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Stafford Horne" <shorne@gmail.com>,
	"Stefan Kristiansson" <stefan.kristiansson@saunalahti.fi>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Vincent Chen" <deanbo422@gmail.com>,
	"Vineet Gupta" <vgupta@kernel.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Will Deacon" <will@kernel.org>,
	"William Cohen" <wcohen@redhat.com>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org,
	linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org,
	openrisc@lists.librecores.org, sparclinux@vger.kernel.org,
	uclinux-h8-devel@lists.sourceforge.jp, x86@kernel.org
Subject: Re: [PATCH 2/2] kbuild: use more subdir- for visiting subdirectories while cleaning
Date: Tue, 12 Oct 2021 23:45:47 -0700	[thread overview]
Message-ID: <202110122345.4B8FE35AED@keescook> (raw)
In-Reply-To: <20211013063622.548590-2-masahiroy@kernel.org>

On Wed, Oct 13, 2021 at 03:36:22PM +0900, Masahiro Yamada wrote:
> Documentation/kbuild/makefiles.rst suggests to use "archclean" for
> cleaning arch/$(SRCARCH)/boot/.
> 
> Since commit d92cc4d51643 ("kbuild: require all architectures to have
> arch/$(SRCARCH)/Kbuild"), we can use the "subdir- += boot" trick for
> all architectures. This can take advantage of the parallel option (-j)
> for "make clean".
> 
> I also cleaned up the comments. The "archdep" target does not exist.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

I like the clean-up!

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, "Albert Ou" <aou@eecs.berkeley.edu>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Borislav Petkov" <bp@alien8.de>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Chris Zankel" <chris@zankel.net>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Greentime Hu" <green.hu@gmail.com>,
	"Guo Ren" <guoren@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Helge Deller" <deller@gmx.de>, "Ingo Molnar" <mingo@redhat.com>,
	"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Jonas Bonn" <jonas@southpole.se>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Julien Thierry" <jthierry@redhat.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
	"Ley Foon Tan" <ley.foon.tan@intel.com>,
	"Marc Zyngier" <maz@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Matt Turner" <mattst88@gmail.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Michal Marek" <michal.lkml@markovi.net>,
	"Michal Simek" <monstr@monstr.eu>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Nick Hu" <nickhu@andestech.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Paul Mackerras" <paulus@samba.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Rich Felker" <dalias@libc.org>,
	"Richard Henderson" <rth@twiddle.net>,
	"Rob Herring" <robh@kernel.org>,
	"Robert Richter" <rric@kernel.org>,
	"Russell King" <linux@armlinux.org.uk>,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Stafford Horne" <shorne@gmail.com>,
	"Stefan Kristiansson" <stefan.kristiansson@saunalahti.fi>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Vincent Chen" <deanbo422@gmail.com>,
	"Vineet Gupta" <vgupta@kernel.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Will Deacon" <will@kernel.org>,
	"William Cohen" <wcohen@redhat.com>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org,
	linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org,
	openrisc@lists.librecores.org, sparclinux@vger.kernel.org,
	uclinux-h8-devel@lists.sourceforge.jp, x86@kernel.org
Subject: Re: [PATCH 2/2] kbuild: use more subdir- for visiting subdirectories while cleaning
Date: Tue, 12 Oct 2021 23:45:47 -0700	[thread overview]
Message-ID: <202110122345.4B8FE35AED@keescook> (raw)
In-Reply-To: <20211013063622.548590-2-masahiroy@kernel.org>

On Wed, Oct 13, 2021 at 03:36:22PM +0900, Masahiro Yamada wrote:
> Documentation/kbuild/makefiles.rst suggests to use "archclean" for
> cleaning arch/$(SRCARCH)/boot/.
> 
> Since commit d92cc4d51643 ("kbuild: require all architectures to have
> arch/$(SRCARCH)/Kbuild"), we can use the "subdir- += boot" trick for
> all architectures. This can take advantage of the parallel option (-j)
> for "make clean".
> 
> I also cleaned up the comments. The "archdep" target does not exist.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

I like the clean-up!

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	linux-ia64@vger.kernel.org, linux-doc@vger.kernel.org,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	linux-mips@vger.kernel.org,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Rich Felker" <dalias@libc.org>, "Guo Ren" <guoren@kernel.org>,
	linux-csky@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,
	"Vincent Chen" <deanbo422@gmail.com>,
	"Will Deacon" <will@kernel.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Paul Mackerras" <paulus@samba.org>,
	"Jonas Bonn" <jonas@southpole.se>,
	"Rob Herring" <robh@kernel.org>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
	"Marc Zyngier" <maz@kernel.org>, "Helge Deller" <deller@gmx.de>,
	linux-sh@vger.kernel.org, "Russell King" <linux@armlinux.org.uk>,
	"Ley Foon Tan" <ley.foon.tan@intel.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	linux-alpha@vger.kernel.org, "Ingo Molnar" <mingo@redhat.com>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	linux-parisc@vger.kernel.org,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Matt Turner" <mattst88@gmail.com>,
	linux-snps-arc@lists.infradead.org,
	uclinux-h8-devel@lists.sourceforge.jp,
	linux-xtensa@linux-xtensa.org,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Robert Richter" <rric@kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	linux-kbuild@vger.kernel.org,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Stefan Kristiansson" <stefan.kristiansson@saunalahti.fi>,
	"Nathan Chancellor" <nathan@kernel.org>,
	linux-m68k@lists.linux-m68k.org,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
	"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
	"Greentime Hu" <green.hu@gmail.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Stafford Horne" <shorne@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	"Richard Henderson" <rth@twiddle.net>,
	"William Cohen" <wcohen@redhat.com>,
	"Chris Zankel" <chris@zankel.net>,
	"Michal Simek" <monstr@monstr.eu>,
	"Michal Marek" <michal.lkml@markovi.net>,
	"Julien Thierry" <jthierry@redhat.com>,
	"Nick Hu" <nickhu@andestech.com>,
	linux-s390@vger.kernel.org, "Jonathan Corbet" <corbet@lwn.net>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	linux-kernel@vger.kernel.org, openrisc@lists.librecores.org,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Vineet Gupta" <vgupta@kernel.org>,
	linuxppc-dev@lists.ozlabs.org,
	"David S. Miller" <davem@davemloft.net>,
	x86@kernel.org
Subject: Re: [PATCH 2/2] kbuild: use more subdir- for visiting subdirectories while cleaning
Date: Tue, 12 Oct 2021 23:45:47 -0700	[thread overview]
Message-ID: <202110122345.4B8FE35AED@keescook> (raw)
In-Reply-To: <20211013063622.548590-2-masahiroy@kernel.org>

On Wed, Oct 13, 2021 at 03:36:22PM +0900, Masahiro Yamada wrote:
> Documentation/kbuild/makefiles.rst suggests to use "archclean" for
> cleaning arch/$(SRCARCH)/boot/.
> 
> Since commit d92cc4d51643 ("kbuild: require all architectures to have
> arch/$(SRCARCH)/Kbuild"), we can use the "subdir- += boot" trick for
> all architectures. This can take advantage of the parallel option (-j)
> for "make clean".
> 
> I also cleaned up the comments. The "archdep" target does not exist.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

I like the clean-up!

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH 2/2] kbuild: use more subdir- for visiting subdirectories while cleaning
Date: Tue, 12 Oct 2021 23:45:47 -0700	[thread overview]
Message-ID: <202110122345.4B8FE35AED@keescook> (raw)
In-Reply-To: <20211013063622.548590-2-masahiroy@kernel.org>

On Wed, Oct 13, 2021 at 03:36:22PM +0900, Masahiro Yamada wrote:
> Documentation/kbuild/makefiles.rst suggests to use "archclean" for
> cleaning arch/$(SRCARCH)/boot/.
> 
> Since commit d92cc4d51643 ("kbuild: require all architectures to have
> arch/$(SRCARCH)/Kbuild"), we can use the "subdir- += boot" trick for
> all architectures. This can take advantage of the parallel option (-j)
> for "make clean".
> 
> I also cleaned up the comments. The "archdep" target does not exist.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

I like the clean-up!

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, "Albert Ou" <aou@eecs.berkeley.edu>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Borislav Petkov" <bp@alien8.de>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Chris Zankel" <chris@zankel.net>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Greentime Hu" <green.hu@gmail.com>,
	"Guo Ren" <guoren@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Helge Deller" <deller@gmx.de>, "Ingo Molnar" <mingo@redhat.com>,
	"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Jonas Bonn" <jonas@southpole.se>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Julien Thierry" <jthierry@redhat.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
	"Ley Foon Tan" <ley.foon.tan@intel.com>,
	"Marc Zyngier" <maz@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Matt Turner" <mattst88@gmail.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Michal Marek" <michal.lkml@markovi.net>,
	"Michal Simek" <monstr@monstr.eu>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Nick Hu" <nickhu@andestech.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Paul Mackerras" <paulus@samba.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Rich Felker" <dalias@libc.org>,
	"Richard Henderson" <rth@twiddle.net>,
	"Rob Herring" <robh@kernel.org>,
	"Robert Richter" <rric@kernel.org>,
	"Russell King" <linux@armlinux.org.uk>,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Stafford Horne" <shorne@gmail.com>,
	"Stefan Kristiansson" <stefan.kristiansson@saunalahti.fi>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Vincent Chen" <deanbo422@gmail.com>,
	"Vineet Gupta" <vgupta@kernel.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Will Deacon" <will@kernel.org>,
	"William Cohen" <wcohen@redhat.com>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org,
	linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org,
	openrisc@lists.librecores.org, sparclinux@vger.kernel.org,
	uclinux-h8-devel@lists.sourceforge.jp, x86@kernel.org
Subject: Re: [PATCH 2/2] kbuild: use more subdir- for visiting subdirectories while cleaning
Date: Wed, 13 Oct 2021 06:45:47 +0000	[thread overview]
Message-ID: <202110122345.4B8FE35AED@keescook> (raw)
In-Reply-To: <20211013063622.548590-2-masahiroy@kernel.org>

On Wed, Oct 13, 2021 at 03:36:22PM +0900, Masahiro Yamada wrote:
> Documentation/kbuild/makefiles.rst suggests to use "archclean" for
> cleaning arch/$(SRCARCH)/boot/.
> 
> Since commit d92cc4d51643 ("kbuild: require all architectures to have
> arch/$(SRCARCH)/Kbuild"), we can use the "subdir- += boot" trick for
> all architectures. This can take advantage of the parallel option (-j)
> for "make clean".
> 
> I also cleaned up the comments. The "archdep" target does not exist.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

I like the clean-up!

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, Albert Ou <aou@eecs.berkeley.edu>,
	Arnd Bergmann <arnd@arndb.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Borislav Petkov <bp@alien8.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Chris Zankel <chris@zankel.net>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	"David S. Miller" <davem@davemloft.net>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greentime Hu <green.hu@gmail.com>, Guo Ren <guoren@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Heiko Carstens <hca@linux.ibm.com>, Helge Deller <deller@gmx.de>,
	Ingo Molnar <mingo@redhat.com>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	Jonas Bonn <jonas@southpole.se>, Jonathan Corbet <corbet@lwn.net>,
	Ju
Subject: Re: [PATCH 2/2] kbuild: use more subdir- for visiting subdirectories while cleaning
Date: Tue, 12 Oct 2021 23:45:47 -0700	[thread overview]
Message-ID: <202110122345.4B8FE35AED@keescook> (raw)
In-Reply-To: <20211013063622.548590-2-masahiroy@kernel.org>

On Wed, Oct 13, 2021 at 03:36:22PM +0900, Masahiro Yamada wrote:
> Documentation/kbuild/makefiles.rst suggests to use "archclean" for
> cleaning arch/$(SRCARCH)/boot/.
> 
> Since commit d92cc4d51643 ("kbuild: require all architectures to have
> arch/$(SRCARCH)/Kbuild"), we can use the "subdir- += boot" trick for
> all architectures. This can take advantage of the parallel option (-j)
> for "make clean".
> 
> I also cleaned up the comments. The "archdep" target does not exist.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

I like the clean-up!

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

  reply	other threads:[~2021-10-13  6:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13  6:36 [PATCH 1/2] sh: remove meaningless archclean line Masahiro Yamada
2021-10-13  6:36 ` [PATCH 2/2] kbuild: use more subdir- for visiting subdirectories while cleaning Masahiro Yamada
2021-10-13  6:36   ` Masahiro Yamada
2021-10-13  6:36   ` Masahiro Yamada
2021-10-13  6:36   ` [OpenRISC] " Masahiro Yamada
2021-10-13  6:36   ` Masahiro Yamada
2021-10-13  6:36   ` Masahiro Yamada
2021-10-13  6:36   ` Masahiro Yamada
2021-10-13  6:45   ` Kees Cook [this message]
2021-10-13  6:45     ` Kees Cook
2021-10-13  6:45     ` Kees Cook
2021-10-13  6:45     ` [OpenRISC] " Kees Cook
2021-10-13  6:45     ` Kees Cook
2021-10-13  6:45     ` Kees Cook
2021-10-13  6:45     ` Kees Cook
2021-10-13  6:59   ` Geert Uytterhoeven
2021-10-13  6:59     ` Geert Uytterhoeven
2021-10-13  6:59     ` Geert Uytterhoeven
2021-10-13  6:59     ` [OpenRISC] " Geert Uytterhoeven
2021-10-13  6:59     ` Geert Uytterhoeven
2021-10-13  6:59     ` Geert Uytterhoeven
2021-10-13  6:59     ` Geert Uytterhoeven
2021-10-15 12:09   ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202110122345.4B8FE35AED@keescook \
    --to=keescook@chromium.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=borntraeger@de.ibm.com \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=chris@zankel.net \
    --cc=corbet@lwn.net \
    --cc=dalias@libc.org \
    --cc=davem@davemloft.net \
    --cc=deanbo422@gmail.com \
    --cc=deller@gmx.de \
    --cc=geert@linux-m68k.org \
    --cc=gor@linux.ibm.com \
    --cc=green.hu@gmail.com \
    --cc=guoren@kernel.org \
    --cc=hca@linux.ibm.com \
    --cc=hpa@zytor.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jcmvbkbc@gmail.com \
    --cc=jonas@southpole.se \
    --cc=jthierry@redhat.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=ley.foon.tan@intel.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=linux-xtensa@linux-xtensa.org \
    --cc=linux@armlinux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=masahiroy@kernel.org \
    --cc=mattst88@gmail.com \
    --cc=maz@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=mingo@redhat.com \
    --cc=monstr@monstr.eu \
    --cc=mpe@ellerman.id.au \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nickhu@andestech.com \
    --cc=openrisc@lists.librecores.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=paulus@samba.org \
    --cc=rdunlap@infradead.org \
    --cc=robh@kernel.org \
    --cc=rric@kernel.org \
    --cc=rth@twiddle.net \
    --cc=samitolvanen@google.com \
    --cc=shorne@gmail.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=stefan.kristiansson@saunalahti.fi \
    --cc=tglx@linutronix.de \
    --cc=tsbogend@alpha.franken.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=uclinux-h8-devel@lists.sourceforge.jp \
    --cc=vgupta@kernel.org \
    --cc=viresh.kumar@linaro.org \
    --cc=wcohen@redhat.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.