From: Gao Xiang <xiang@kernel.org> To: Chao Yu <chao@kernel.org> Cc: Gao Xiang <xiang@kernel.org>, linux-erofs@lists.ozlabs.org, LKML <linux-kernel@vger.kernel.org>, Yue Hu <zbestahu@gmail.com>, Gao Xiang <hsiangkao@linux.alibaba.com> Subject: Re: [PATCH v3 2/3] erofs: introduce the secondary compression head Date: Sun, 17 Oct 2021 23:32:05 +0800 [thread overview] Message-ID: <20211017153202.GA4054@hsiangkao-HP-ZHAN-66-Pro-G1> (raw) In-Reply-To: <c3ad3f92-6a35-acbb-923a-21611d232689@kernel.org> Hi Chao, On Sun, Oct 17, 2021 at 11:27:54PM +0800, Chao Yu wrote: > On 2021/10/10 2:12, Gao Xiang wrote: > > From: Gao Xiang <hsiangkao@linux.alibaba.com> > > > > Previously, for each HEAD lcluster, it can be either HEAD or PLAIN > > lcluster to indicate whether the whole pcluster is compressed or not. > > > > In this patch, a new HEAD2 head type is introduced to specify another > > compression algorithm other than the primary algorithm for each > > compressed file, which can be used for upcoming LZMA compression and > > LZ4 range dictionary compression for various data patterns. > > > > It has been stayed in the EROFS roadmap for years. Complete it now! > > > > Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com> > > --- > > v2: https://lore.kernel.org/r/20211008200839.24541-3-xiang@kernel.org > > changes since v2: > > - simplify z_algorithmtype check suggested by Yue. > > > > fs/erofs/erofs_fs.h | 8 +++++--- > > fs/erofs/zmap.c | 38 ++++++++++++++++++++++++++------------ > > 2 files changed, 31 insertions(+), 15 deletions(-) > > > > diff --git a/fs/erofs/erofs_fs.h b/fs/erofs/erofs_fs.h > > index b0b23f41abc3..f579c8c78fff 100644 > > --- a/fs/erofs/erofs_fs.h > > +++ b/fs/erofs/erofs_fs.h > > @@ -21,11 +21,13 @@ > > #define EROFS_FEATURE_INCOMPAT_COMPR_CFGS 0x00000002 > > #define EROFS_FEATURE_INCOMPAT_BIG_PCLUSTER 0x00000002 > > #define EROFS_FEATURE_INCOMPAT_CHUNKED_FILE 0x00000004 > > +#define EROFS_FEATURE_INCOMPAT_COMPR_HEAD2 0x00000008 > > #define EROFS_ALL_FEATURE_INCOMPAT \ > > (EROFS_FEATURE_INCOMPAT_LZ4_0PADDING | \ > > EROFS_FEATURE_INCOMPAT_COMPR_CFGS | \ > > EROFS_FEATURE_INCOMPAT_BIG_PCLUSTER | \ > > - EROFS_FEATURE_INCOMPAT_CHUNKED_FILE) > > + EROFS_FEATURE_INCOMPAT_CHUNKED_FILE | \ > > + EROFS_FEATURE_INCOMPAT_COMPR_HEAD2) > > #define EROFS_SB_EXTSLOT_SIZE 16 > > @@ -314,9 +316,9 @@ struct z_erofs_map_header { > > */ > > enum { > > Z_EROFS_VLE_CLUSTER_TYPE_PLAIN = 0, > > - Z_EROFS_VLE_CLUSTER_TYPE_HEAD = 1, > > + Z_EROFS_VLE_CLUSTER_TYPE_HEAD1 = 1, > > Z_EROFS_VLE_CLUSTER_TYPE_NONHEAD = 2, > > - Z_EROFS_VLE_CLUSTER_TYPE_RESERVED = 3, > > + Z_EROFS_VLE_CLUSTER_TYPE_HEAD2 = 3, > > It needs to update comments above as well. okay, let me revise them now. Thanks, Gao XIang > > Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Gao Xiang <xiang@kernel.org> To: Chao Yu <chao@kernel.org> Cc: Gao Xiang <hsiangkao@linux.alibaba.com>, linux-erofs@lists.ozlabs.org, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 2/3] erofs: introduce the secondary compression head Date: Sun, 17 Oct 2021 23:32:05 +0800 [thread overview] Message-ID: <20211017153202.GA4054@hsiangkao-HP-ZHAN-66-Pro-G1> (raw) In-Reply-To: <c3ad3f92-6a35-acbb-923a-21611d232689@kernel.org> Hi Chao, On Sun, Oct 17, 2021 at 11:27:54PM +0800, Chao Yu wrote: > On 2021/10/10 2:12, Gao Xiang wrote: > > From: Gao Xiang <hsiangkao@linux.alibaba.com> > > > > Previously, for each HEAD lcluster, it can be either HEAD or PLAIN > > lcluster to indicate whether the whole pcluster is compressed or not. > > > > In this patch, a new HEAD2 head type is introduced to specify another > > compression algorithm other than the primary algorithm for each > > compressed file, which can be used for upcoming LZMA compression and > > LZ4 range dictionary compression for various data patterns. > > > > It has been stayed in the EROFS roadmap for years. Complete it now! > > > > Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com> > > --- > > v2: https://lore.kernel.org/r/20211008200839.24541-3-xiang@kernel.org > > changes since v2: > > - simplify z_algorithmtype check suggested by Yue. > > > > fs/erofs/erofs_fs.h | 8 +++++--- > > fs/erofs/zmap.c | 38 ++++++++++++++++++++++++++------------ > > 2 files changed, 31 insertions(+), 15 deletions(-) > > > > diff --git a/fs/erofs/erofs_fs.h b/fs/erofs/erofs_fs.h > > index b0b23f41abc3..f579c8c78fff 100644 > > --- a/fs/erofs/erofs_fs.h > > +++ b/fs/erofs/erofs_fs.h > > @@ -21,11 +21,13 @@ > > #define EROFS_FEATURE_INCOMPAT_COMPR_CFGS 0x00000002 > > #define EROFS_FEATURE_INCOMPAT_BIG_PCLUSTER 0x00000002 > > #define EROFS_FEATURE_INCOMPAT_CHUNKED_FILE 0x00000004 > > +#define EROFS_FEATURE_INCOMPAT_COMPR_HEAD2 0x00000008 > > #define EROFS_ALL_FEATURE_INCOMPAT \ > > (EROFS_FEATURE_INCOMPAT_LZ4_0PADDING | \ > > EROFS_FEATURE_INCOMPAT_COMPR_CFGS | \ > > EROFS_FEATURE_INCOMPAT_BIG_PCLUSTER | \ > > - EROFS_FEATURE_INCOMPAT_CHUNKED_FILE) > > + EROFS_FEATURE_INCOMPAT_CHUNKED_FILE | \ > > + EROFS_FEATURE_INCOMPAT_COMPR_HEAD2) > > #define EROFS_SB_EXTSLOT_SIZE 16 > > @@ -314,9 +316,9 @@ struct z_erofs_map_header { > > */ > > enum { > > Z_EROFS_VLE_CLUSTER_TYPE_PLAIN = 0, > > - Z_EROFS_VLE_CLUSTER_TYPE_HEAD = 1, > > + Z_EROFS_VLE_CLUSTER_TYPE_HEAD1 = 1, > > Z_EROFS_VLE_CLUSTER_TYPE_NONHEAD = 2, > > - Z_EROFS_VLE_CLUSTER_TYPE_RESERVED = 3, > > + Z_EROFS_VLE_CLUSTER_TYPE_HEAD2 = 3, > > It needs to update comments above as well. okay, let me revise them now. Thanks, Gao XIang > > Thanks,
next prev parent reply other threads:[~2021-10-17 15:32 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-08 20:08 [PATCH v2 0/3] erofs: some decompression improvements Gao Xiang 2021-10-08 20:08 ` Gao Xiang 2021-10-08 20:08 ` [PATCH v2 1/3] erofs: get compression algorithms directly on mapping Gao Xiang 2021-10-08 20:08 ` Gao Xiang 2021-10-09 1:52 ` Yue Hu 2021-10-09 1:52 ` Yue Hu 2021-10-17 15:25 ` Chao Yu 2021-10-17 15:25 ` Chao Yu 2021-10-08 20:08 ` [PATCH v2 2/3] erofs: introduce the secondary compression head Gao Xiang 2021-10-08 20:08 ` Gao Xiang 2021-10-09 3:50 ` Yue Hu 2021-10-09 3:50 ` Yue Hu 2021-10-09 4:47 ` Gao Xiang 2021-10-09 4:47 ` Gao Xiang 2021-10-09 18:12 ` [PATCH v3 " Gao Xiang 2021-10-09 18:12 ` Gao Xiang 2021-10-10 0:53 ` Yue Hu 2021-10-10 0:53 ` Yue Hu 2021-10-17 15:27 ` Chao Yu 2021-10-17 15:27 ` Chao Yu 2021-10-17 15:32 ` Gao Xiang [this message] 2021-10-17 15:32 ` Gao Xiang 2021-10-17 16:57 ` [PATCH v4 " Gao Xiang 2021-10-17 16:57 ` Gao Xiang 2021-10-19 12:56 ` Chao Yu 2021-10-19 12:56 ` Chao Yu 2021-10-08 20:08 ` [PATCH v2 3/3] erofs: introduce readmore decompression strategy Gao Xiang 2021-10-08 20:08 ` Gao Xiang 2021-10-17 15:34 ` Chao Yu 2021-10-17 15:34 ` Chao Yu 2021-10-17 15:42 ` Gao Xiang 2021-10-17 15:42 ` Gao Xiang 2021-10-19 12:58 ` Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211017153202.GA4054@hsiangkao-HP-ZHAN-66-Pro-G1 \ --to=xiang@kernel.org \ --cc=chao@kernel.org \ --cc=hsiangkao@linux.alibaba.com \ --cc=linux-erofs@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=zbestahu@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.