Re: [PATCH v3 0/4] HID: wiiu-drc: Add a driver for the Wii U gamepad

From: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
To: Jiri Kosina <jikos@kernel.org>
Cc: "Emmanuel Gil Peyrot" <linkmauve@linkmauve.fr>,
	linux-input@vger.kernel.org, "Ash Logan" <ash@heyquark.com>,
	"Jonathan Neuschäfer" <j.ne@posteo.net>,
	"Barnabás Pőcze" <pobrn@protonmail.com>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	linux-kernel@vger.kernel.org,
	"Daniel J. Ogorchock" <djogorchock@gmail.com>
Subject: Re: [PATCH v3 0/4] HID: wiiu-drc: Add a driver for the Wii U gamepad
Date: Tue, 19 Oct 2021 11:36:20 +0200	[thread overview]
Message-ID: <20211019093620.msk3k6cvxe3rtros@luna> (raw)
In-Reply-To: <nycvar.YFH.7.76.2110191128540.12554@cbobk.fhfr.pm>

[-- Attachment #1: Type: text/plain, Size: 1785 bytes --]

On Tue, Oct 19, 2021 at 11:30:06AM +0200, Jiri Kosina wrote:
> On Tue, 19 Oct 2021, Emmanuel Gil Peyrot wrote:
> 
> > > The code looks good to me, the only question/request I'd have is -- would 
> > > it be possible to adhere to the driver naming standards, and actually 
> > > incorporate the support to existing hid-nintendo driver? Or is there any 
> > > substantial reason which I don't see why this wouldn't be a good idea?
> > 
> > I don’t see any existing driver named that way in mainline, would it be
> > acceptable to simply rename the current patches to hid-nintendo?  What
> > should be done about the existing hid-wiimote driver then, should it
> > also be merged alongside?
> 
> hid-nintendo has just recently been staged for 5.16 in 
> hid.git#for-5.16/nintendo git branch. Could you please check that?

Got it, thanks!

> 
> > Another driver I’d like to submit eventually is the GameCube Controller 
> > Adapter for Wii U, which does exactly what its name says, but being an 
> > external USB adapter it also works on any USB computer; would it make 
> > sense to develop it alongside the current driver, just because it is 
> > sold by the same company?
> 
> We generally group the support for HID devices in drivers based on the 
> producing company, with a few exceptions where it doesn't make sense.

Would it make sense to decouple this driver from the joycon driver?  To
have some kind of sub-driver (possibly with Kconfig entries) for joycon,
wiimote, drc, gc-adapter, maybe more in the future?  I don’t see the drc
code go well into that one C file.  I can handle the split of the joycon
into its own file if that’s a good way forward.

> 
> Thanks,
> 
> -- 
> Jiri Kosina
> SUSE Labs

-- 
Emmanuel Gil Peyrot

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]