From: Jiri Kosina <jikos@kernel.org>
To: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Cc: linux-input@vger.kernel.org, "Ash Logan" <ash@heyquark.com>,
"Jonathan Neuschäfer" <j.ne@posteo.net>,
"Barnabás Pőcze" <pobrn@protonmail.com>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
linux-kernel@vger.kernel.org,
"Daniel J. Ogorchock" <djogorchock@gmail.com>
Subject: Re: [PATCH v3 0/4] HID: wiiu-drc: Add a driver for the Wii U gamepad
Date: Tue, 19 Oct 2021 11:14:02 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2110191112490.12554@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210921150837.ingexwsauvxgluca@luna>
On Tue, 21 Sep 2021, Emmanuel Gil Peyrot wrote:
> > This driver is for the DRC (wireless gamepad) when plugged to the DRH of
> > the Wii U, a chip exposing it as a USB device.
>
> Hi, I’d like to request a review on this series. I’ve been using it
> with success for quite some months, and from a self-review after not
> having touched it for as long it still looks correct. :)
>
> Thanks!
[ CCing Daniel ]
Thanks for the patch, and sorry for the delay in the review.
The code looks good to me, the only question/request I'd have is -- would
it be possible to adhere to the driver naming standards, and actually
incorporate the support to existing hid-nintendo driver? Or is there any
substantial reason which I don't see why this wouldn't be a good idea?
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2021-10-19 9:14 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 23:28 [PATCH 0/4] RFC: HID: wiiu-drc: Add a driver for the Wii U gamepad Emmanuel Gil Peyrot
2021-05-02 23:28 ` [PATCH 1/4] HID: wiiu-drc: Add a driver for this gamepad Emmanuel Gil Peyrot
2021-05-05 22:33 ` Jonathan Neuschäfer
2021-05-06 10:07 ` Emmanuel Gil Peyrot
2021-05-06 10:29 ` Jonathan Neuschäfer
2021-05-06 11:53 ` Barnabás Pőcze
2021-05-02 23:28 ` [PATCH 2/4] HID: wiiu-drc: Implement touch reports Emmanuel Gil Peyrot
2021-05-05 22:43 ` Jonathan Neuschäfer
2021-05-06 10:20 ` Emmanuel Gil Peyrot
2021-05-02 23:28 ` [PATCH 3/4] HID: wiiu-drc: Add accelerometer, gyroscope and magnetometer readings Emmanuel Gil Peyrot
2021-05-02 23:28 ` [PATCH 4/4] HID: wiiu-drc: Add battery reporting Emmanuel Gil Peyrot
2021-05-06 11:45 ` Barnabás Pőcze
2021-05-19 8:59 ` [PATCH v3 0/4] HID: wiiu-drc: Add a driver for the Wii U gamepad Emmanuel Gil Peyrot
2021-05-19 8:59 ` [PATCH v3 1/4] HID: wiiu-drc: Add a driver for this gamepad Emmanuel Gil Peyrot
2021-05-19 8:59 ` [PATCH v3 2/4] HID: wiiu-drc: Implement touch reports Emmanuel Gil Peyrot
2021-05-19 8:59 ` [PATCH v3 3/4] HID: wiiu-drc: Add accelerometer, gyroscope and magnetometer readings Emmanuel Gil Peyrot
2021-05-19 8:59 ` [PATCH v3 4/4] HID: wiiu-drc: Add battery reporting Emmanuel Gil Peyrot
2021-09-21 15:08 ` [PATCH v3 0/4] HID: wiiu-drc: Add a driver for the Wii U gamepad Emmanuel Gil Peyrot
2021-10-19 9:14 ` Jiri Kosina [this message]
2021-10-19 9:27 ` Emmanuel Gil Peyrot
2021-10-19 9:30 ` Jiri Kosina
2021-10-19 9:36 ` Emmanuel Gil Peyrot
2021-11-04 11:21 ` Emmanuel Gil Peyrot
2021-11-05 17:27 ` François-Xavier Carton
2021-10-19 23:59 ` François-Xavier Carton
2021-10-20 6:24 ` Emmanuel Gil Peyrot
2021-10-19 11:04 ` [PATCH v4 0/5] HID: nintendo: Add support " Emmanuel Gil Peyrot
2021-10-19 11:04 ` [PATCH v4 1/5] HID: nintendo: split switch support into its own file Emmanuel Gil Peyrot
2021-10-22 8:32 ` kernel test robot
2021-10-22 8:32 ` kernel test robot
2021-10-22 10:25 ` kernel test robot
2021-10-22 10:25 ` kernel test robot
2021-10-19 11:04 ` [PATCH v4 2/5] HID: nintendo: drc: add support for the Wii U gamepad Emmanuel Gil Peyrot
2021-11-05 20:55 ` kernel test robot
2021-11-05 20:55 ` kernel test robot
2021-10-19 11:04 ` [PATCH v4 3/5] HID: nintendo: drc: implement touch reports Emmanuel Gil Peyrot
2021-10-19 11:04 ` [PATCH v4 4/5] HID: nintendo: drc: add accelerometer, gyroscope and magnetometer readings Emmanuel Gil Peyrot
2021-10-19 11:04 ` [PATCH v4 5/5] HID: nintendo: drc: add battery reporting Emmanuel Gil Peyrot
2021-10-27 8:10 ` [PATCH v4 0/5] HID: nintendo: Add support for the Wii U gamepad Jiri Kosina
2021-10-27 10:10 ` [PATCH v5 " Emmanuel Gil Peyrot
2021-10-27 10:10 ` [PATCH v5 1/5] HID: nintendo: split switch support into its own file Emmanuel Gil Peyrot
2021-10-27 10:10 ` [PATCH v5 2/5] HID: nintendo: drc: add support for the Wii U gamepad Emmanuel Gil Peyrot
2021-10-27 10:10 ` [PATCH v5 3/5] HID: nintendo: drc: implement touch reports Emmanuel Gil Peyrot
2021-10-27 10:10 ` [PATCH v5 4/5] HID: nintendo: drc: add accelerometer, gyroscope and magnetometer readings Emmanuel Gil Peyrot
2021-10-27 10:10 ` [PATCH v5 5/5] HID: nintendo: drc: add battery reporting Emmanuel Gil Peyrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2110191112490.12554@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=ash@heyquark.com \
--cc=benjamin.tissoires@redhat.com \
--cc=djogorchock@gmail.com \
--cc=j.ne@posteo.net \
--cc=linkmauve@linkmauve.fr \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pobrn@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.