Re: [PATCH v5 12/21] drm/bridge: ps8640: Register and attach our DSI device at probe

From: kernel test robot <lkp@intel.com>
To: Maxime Ripard <maxime@cerno.tech>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Sam Ravnborg <sam@ravnborg.org>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>,
	Thierry Reding <thierry.reding@gmail.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Robert Foss <robert.foss@linaro.org>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org
Subject: Re: [PATCH v5 12/21] drm/bridge: ps8640: Register and attach our DSI device at probe
Date: Fri, 22 Oct 2021 02:40:42 +0800	[thread overview]
Message-ID: <202110220208.KhJv9kuy-lkp@intel.com> (raw)
In-Reply-To: <20211021073947.499373-13-maxime@cerno.tech>

[-- Attachment #1: Type: text/plain, Size: 4276 bytes --]

Hi Maxime,

I love your patch! Yet something to improve:

[auto build test ERROR on next-20211020]
[cannot apply to linus/master v5.15-rc6 v5.15-rc5 v5.15-rc4 v5.15-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Maxime-Ripard/drm-bridge-Make-panel-and-bridge-probe-order-consistent/20211021-154253
base:    51dba6e335ff9d1f6f50b5cacced8598956e1437
config: i386-randconfig-r033-20211021 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 3cea2505fd8d99a9ba0cb625aecfe28a47c4e3f8)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/585920edf3c968d2da5a1eeaa56a2a075d7067b9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Maxime-Ripard/drm-bridge-Make-panel-and-bridge-probe-order-consistent/20211021-154253
        git checkout 585920edf3c968d2da5a1eeaa56a2a075d7067b9
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/bridge/parade-ps8640.c:407:2: error: use of undeclared identifier 'ret'
           ret = drm_dp_aux_register(&ps_bridge->aux);
           ^
   drivers/gpu/drm/bridge/parade-ps8640.c:408:6: error: use of undeclared identifier 'ret'
           if (ret) {
               ^
>> drivers/gpu/drm/bridge/parade-ps8640.c:409:11: error: use of undeclared identifier 'dev'
                   dev_err(dev, "failed to register DP AUX channel: %d\n", ret);
                           ^
   drivers/gpu/drm/bridge/parade-ps8640.c:409:59: error: use of undeclared identifier 'ret'
                   dev_err(dev, "failed to register DP AUX channel: %d\n", ret);
                                                                           ^
   drivers/gpu/drm/bridge/parade-ps8640.c:410:10: error: use of undeclared identifier 'ret'
                   return ret;
                          ^
   5 errors generated.

vim +/ret +407 drivers/gpu/drm/bridge/parade-ps8640.c

bc1aee7fc8f05b Jitao Shi              2019-12-30  398  
a25b988ff83f3c Laurent Pinchart       2020-02-26  399  static int ps8640_bridge_attach(struct drm_bridge *bridge,
a25b988ff83f3c Laurent Pinchart       2020-02-26  400  				enum drm_bridge_attach_flags flags)
bc1aee7fc8f05b Jitao Shi              2019-12-30  401  {
bc1aee7fc8f05b Jitao Shi              2019-12-30  402  	struct ps8640 *ps_bridge = bridge_to_ps8640(bridge);
812a65ba9411c5 Enric Balletbo i Serra 2020-08-26  403  
812a65ba9411c5 Enric Balletbo i Serra 2020-08-26  404  	if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR))
812a65ba9411c5 Enric Balletbo i Serra 2020-08-26  405  		return -EINVAL;
812a65ba9411c5 Enric Balletbo i Serra 2020-08-26  406  
13afcdd7277eff Philip Chen            2021-09-21 @407  	ret = drm_dp_aux_register(&ps_bridge->aux);
13afcdd7277eff Philip Chen            2021-09-21  408  	if (ret) {
13afcdd7277eff Philip Chen            2021-09-21 @409  		dev_err(dev, "failed to register DP AUX channel: %d\n", ret);
e1881ac0e79203 Maxime Ripard          2021-10-21  410  		return ret;
13afcdd7277eff Philip Chen            2021-09-21  411  	}
bc1aee7fc8f05b Jitao Shi              2019-12-30  412  
bc1aee7fc8f05b Jitao Shi              2019-12-30  413  	/* Attach the panel-bridge to the dsi bridge */
bc1aee7fc8f05b Jitao Shi              2019-12-30  414  	return drm_bridge_attach(bridge->encoder, ps_bridge->panel_bridge,
a25b988ff83f3c Laurent Pinchart       2020-02-26  415  				 &ps_bridge->bridge, flags);
bc1aee7fc8f05b Jitao Shi              2019-12-30  416  }
bc1aee7fc8f05b Jitao Shi              2019-12-30  417  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34888 bytes --]