Re: [Intel-gfx] [PATCH 4/9] drm/i915/dmabuf: add paranoid flush-on-acquire

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 4/9] drm/i915/dmabuf: add paranoid flush-on-acquire
Date: Fri, 22 Oct 2021 18:50:47 +0800	[thread overview]
Message-ID: <202110221843.hKnZOVhR-lkp@intel.com> (raw)
In-Reply-To: <20211018174508.2137279-4-matthew.auld@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2676 bytes --]

Hi Matthew,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v5.15-rc6 next-20211021]
[cannot apply to drm-tip/drm-tip]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Matthew-Auld/drm-i915-mark-dmabuf-objects-as-ALLOC_USER/20211019-020842
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-a015-20211019 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/108491e634ed9e2e220cf01b127399bfa4598764
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matthew-Auld/drm-i915-mark-dmabuf-objects-as-ALLOC_USER/20211019-020842
        git checkout 108491e634ed9e2e220cf01b127399bfa4598764
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c: In function 'i915_gem_object_get_pages_dmabuf':
>> drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c:248:3: error: implicit declaration of function 'wbinvd_on_all_cpus' [-Werror=implicit-function-declaration]
     248 |   wbinvd_on_all_cpus();
         |   ^~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/wbinvd_on_all_cpus +248 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c

   232	
   233	static int i915_gem_object_get_pages_dmabuf(struct drm_i915_gem_object *obj)
   234	{
   235		struct drm_i915_private *i915 = to_i915(obj->base.dev);
   236		struct sg_table *pages;
   237		unsigned int sg_page_sizes;
   238	
   239		assert_object_held(obj);
   240	
   241		pages = dma_buf_map_attachment(obj->base.import_attach,
   242					       DMA_BIDIRECTIONAL);
   243		if (IS_ERR(pages))
   244			return PTR_ERR(pages);
   245	
   246		/* XXX: consider doing a vmap flush or something */
   247		if (!HAS_LLC(i915) || i915_gem_object_can_bypass_llc(obj))
 > 248			wbinvd_on_all_cpus();
   249	
   250		sg_page_sizes = i915_sg_dma_sizes(pages->sgl);
   251		__i915_gem_object_set_pages(obj, pages, sg_page_sizes);
   252	
   253		return 0;
   254	}
   255	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42994 bytes --]