From: Christoph Hellwig <hch@lst.de>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: axboe@kernel.dk, hch@lst.de, penguin-kernel@i-love.sakura.ne.jp,
dan.j.williams@intel.com, vishal.l.verma@intel.com,
dave.jiang@intel.com, ira.weiny@intel.com, richard@nod.at,
miquel.raynal@bootlin.com, vigneshr@ti.com, efremov@linux.com,
song@kernel.org, martin.petersen@oracle.com, hare@suse.de,
jack@suse.cz, ming.lei@redhat.com, tj@kernel.org,
linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org,
linux-raid@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 09/13] block/sunvdc: add error handling support for add_disk()
Date: Wed, 3 Nov 2021 17:07:28 +0100 [thread overview]
Message-ID: <20211103160728.GI31562@lst.de> (raw)
In-Reply-To: <20211103122157.1215783-10-mcgrof@kernel.org>
On Wed, Nov 03, 2021 at 05:21:53AM -0700, Luis Chamberlain wrote:
> We never checked for errors on add_disk() as this function
> returned void. Now that this is fixed, use the shiny new
> error handling.
>
> We re-use the same free tag call, so we also add a label for
> that as well.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: axboe@kernel.dk, hch@lst.de, penguin-kernel@i-love.sakura.ne.jp,
dan.j.williams@intel.com, vishal.l.verma@intel.com,
dave.jiang@intel.com, ira.weiny@intel.com, richard@nod.at,
miquel.raynal@bootlin.com, vigneshr@ti.com, efremov@linux.com,
song@kernel.org, martin.petersen@oracle.com, hare@suse.de,
jack@suse.cz, ming.lei@redhat.com, tj@kernel.org,
linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org,
linux-raid@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 09/13] block/sunvdc: add error handling support for add_disk()
Date: Wed, 3 Nov 2021 17:07:28 +0100 [thread overview]
Message-ID: <20211103160728.GI31562@lst.de> (raw)
In-Reply-To: <20211103122157.1215783-10-mcgrof@kernel.org>
On Wed, Nov 03, 2021 at 05:21:53AM -0700, Luis Chamberlain wrote:
> We never checked for errors on add_disk() as this function
> returned void. Now that this is fixed, use the shiny new
> error handling.
>
> We re-use the same free tag call, so we also add a label for
> that as well.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-11-03 16:07 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 12:21 [PATCH v2 00/13] block: add_disk() error handling stragglers Luis Chamberlain
2021-11-03 12:21 ` Luis Chamberlain
2021-11-03 12:21 ` [PATCH v2 01/13] nvdimm/btt: do not call del_gendisk() if not needed Luis Chamberlain
2021-11-03 12:21 ` Luis Chamberlain
2021-11-03 16:02 ` Christoph Hellwig
2021-11-03 16:02 ` Christoph Hellwig
2021-11-03 16:58 ` Luis Chamberlain
2021-11-03 16:58 ` Luis Chamberlain
2021-11-03 12:21 ` [PATCH v2 02/13] nvdimm/btt: use goto error labels on btt_blk_init() Luis Chamberlain
2021-11-03 12:21 ` Luis Chamberlain
2021-11-03 16:02 ` Christoph Hellwig
2021-11-03 16:02 ` Christoph Hellwig
2021-11-03 12:21 ` [PATCH v2 03/13] nvdimm/btt: add error handling support for add_disk() Luis Chamberlain
2021-11-03 12:21 ` Luis Chamberlain
2021-11-03 16:04 ` Christoph Hellwig
2021-11-03 16:04 ` Christoph Hellwig
2021-11-03 12:21 ` [PATCH v2 04/13] nvdimm/blk: avoid calling del_gendisk() on early failures Luis Chamberlain
2021-11-03 12:21 ` Luis Chamberlain
2021-11-03 16:05 ` Christoph Hellwig
2021-11-03 16:05 ` Christoph Hellwig
2021-11-03 16:47 ` Luis Chamberlain
2021-11-03 16:47 ` Luis Chamberlain
2021-11-03 12:21 ` [PATCH v2 05/13] nvdimm/blk: add error handling support for add_disk() Luis Chamberlain
2021-11-03 12:21 ` Luis Chamberlain
2021-11-03 16:06 ` Christoph Hellwig
2021-11-03 16:06 ` Christoph Hellwig
2021-11-03 12:21 ` [PATCH v2 06/13] nvdimm/pmem: cleanup the disk if pmem_release_disk() is yet assigned Luis Chamberlain
2021-11-03 12:21 ` Luis Chamberlain
2021-11-03 16:06 ` Christoph Hellwig
2021-11-03 16:06 ` Christoph Hellwig
2021-11-03 12:21 ` [PATCH v2 07/13] nvdimm/pmem: use add_disk() error handling Luis Chamberlain
2021-11-03 12:21 ` Luis Chamberlain
2021-11-03 16:06 ` Christoph Hellwig
2021-11-03 16:06 ` Christoph Hellwig
2021-11-03 12:21 ` [PATCH v2 08/13] z2ram: add error handling support for add_disk() Luis Chamberlain
2021-11-03 12:21 ` Luis Chamberlain
2021-11-03 16:07 ` Christoph Hellwig
2021-11-03 16:07 ` Christoph Hellwig
2021-11-03 12:21 ` [PATCH v2 09/13] block/sunvdc: " Luis Chamberlain
2021-11-03 12:21 ` Luis Chamberlain
2021-11-03 16:07 ` Christoph Hellwig [this message]
2021-11-03 16:07 ` Christoph Hellwig
2021-11-03 12:21 ` [PATCH v2 10/13] mtd/ubi/block: " Luis Chamberlain
2021-11-03 12:21 ` Luis Chamberlain
2021-11-03 16:07 ` Christoph Hellwig
2021-11-03 16:07 ` Christoph Hellwig
2021-11-03 12:21 ` [PATCH v2 11/13] ataflop: remove ataflop_probe_lock mutex Luis Chamberlain
2021-11-03 12:21 ` Luis Chamberlain
2021-11-03 12:21 ` [PATCH v2 12/13] block: make __register_blkdev() return an error Luis Chamberlain
2021-11-03 12:21 ` Luis Chamberlain
2021-11-03 16:09 ` Christoph Hellwig
2021-11-03 16:09 ` Christoph Hellwig
2021-11-03 16:44 ` Luis Chamberlain
2021-11-03 16:44 ` Luis Chamberlain
2021-11-03 17:00 ` Christoph Hellwig
2021-11-03 17:00 ` Christoph Hellwig
2021-11-03 17:03 ` Luis Chamberlain
2021-11-03 17:03 ` Luis Chamberlain
2021-11-03 12:21 ` [PATCH v2 13/13] block: add __must_check for *add_disk*() callers Luis Chamberlain
2021-11-03 12:21 ` Luis Chamberlain
2021-11-03 17:41 ` [PATCH v2 00/13] block: add_disk() error handling stragglers Luis Chamberlain
2021-11-03 17:41 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103160728.GI31562@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=efremov@linux.com \
--cc=hare@suse.de \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ming.lei@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=richard@nod.at \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=vigneshr@ti.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.