From: Borislav Petkov <bp@alien8.de> To: LKML <linux-kernel@vger.kernel.org> Cc: linux-arm-kernel@lists.infradead.org Subject: [PATCH v0 06/42] firmware: Check notifier registration return value Date: Mon, 8 Nov 2021 11:11:21 +0100 [thread overview] Message-ID: <20211108101157.15189-7-bp@alien8.de> (raw) In-Reply-To: <20211108101157.15189-1-bp@alien8.de> From: Borislav Petkov <bp@suse.de> Avoid homegrown notifier registration checks. No functional changes. Signed-off-by: Borislav Petkov <bp@suse.de> Cc: linux-arm-kernel@lists.infradead.org --- drivers/firmware/arm_scmi/notify.c | 3 ++- drivers/firmware/google/gsmi.c | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/arm_scmi/notify.c b/drivers/firmware/arm_scmi/notify.c index 0efd20cd9d69..f4c42ac00c63 100644 --- a/drivers/firmware/arm_scmi/notify.c +++ b/drivers/firmware/arm_scmi/notify.c @@ -1358,7 +1358,8 @@ static int scmi_notifier_register(const struct scmi_handle *handle, if (!hndl) return -EINVAL; - blocking_notifier_chain_register(&hndl->chain, nb); + if (blocking_notifier_chain_register(&hndl->chain, nb)) + pr_warn("SCMI notifier already registered\n"); /* Enable events for not pending handlers */ if (!IS_HNDL_PENDING(hndl)) { diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c index adaa492c3d2d..a658e7c106c3 100644 --- a/drivers/firmware/google/gsmi.c +++ b/drivers/firmware/google/gsmi.c @@ -1030,8 +1030,10 @@ static __init int gsmi_init(void) register_reboot_notifier(&gsmi_reboot_notifier); register_die_notifier(&gsmi_die_notifier); - atomic_notifier_chain_register(&panic_notifier_list, - &gsmi_panic_notifier); + + if (atomic_notifier_chain_register(&panic_notifier_list, + &gsmi_panic_notifier)) + pr_warn("gsmi panic notifier already registered\n"); printk(KERN_INFO "gsmi version " DRIVER_VERSION " loaded\n"); -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de> To: LKML <linux-kernel@vger.kernel.org> Cc: linux-arm-kernel@lists.infradead.org Subject: [PATCH v0 06/42] firmware: Check notifier registration return value Date: Mon, 8 Nov 2021 11:11:21 +0100 [thread overview] Message-ID: <20211108101157.15189-7-bp@alien8.de> (raw) In-Reply-To: <20211108101157.15189-1-bp@alien8.de> From: Borislav Petkov <bp@suse.de> Avoid homegrown notifier registration checks. No functional changes. Signed-off-by: Borislav Petkov <bp@suse.de> Cc: linux-arm-kernel@lists.infradead.org --- drivers/firmware/arm_scmi/notify.c | 3 ++- drivers/firmware/google/gsmi.c | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/arm_scmi/notify.c b/drivers/firmware/arm_scmi/notify.c index 0efd20cd9d69..f4c42ac00c63 100644 --- a/drivers/firmware/arm_scmi/notify.c +++ b/drivers/firmware/arm_scmi/notify.c @@ -1358,7 +1358,8 @@ static int scmi_notifier_register(const struct scmi_handle *handle, if (!hndl) return -EINVAL; - blocking_notifier_chain_register(&hndl->chain, nb); + if (blocking_notifier_chain_register(&hndl->chain, nb)) + pr_warn("SCMI notifier already registered\n"); /* Enable events for not pending handlers */ if (!IS_HNDL_PENDING(hndl)) { diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c index adaa492c3d2d..a658e7c106c3 100644 --- a/drivers/firmware/google/gsmi.c +++ b/drivers/firmware/google/gsmi.c @@ -1030,8 +1030,10 @@ static __init int gsmi_init(void) register_reboot_notifier(&gsmi_reboot_notifier); register_die_notifier(&gsmi_die_notifier); - atomic_notifier_chain_register(&panic_notifier_list, - &gsmi_panic_notifier); + + if (atomic_notifier_chain_register(&panic_notifier_list, + &gsmi_panic_notifier)) + pr_warn("gsmi panic notifier already registered\n"); printk(KERN_INFO "gsmi version " DRIVER_VERSION " loaded\n"); -- 2.29.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-08 10:13 UTC|newest] Thread overview: 151+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-08 10:11 [PATCH v0 00/42] notifiers: Return an error when callback is already registered Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 01/42] x86: Check notifier registration return value Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 02/42] xen/x86: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 03/42] impi: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 04/42] clk: renesas: " Borislav Petkov 2021-11-08 14:12 ` Geert Uytterhoeven 2021-11-08 10:11 ` [PATCH v0 05/42] dca: " Borislav Petkov 2021-11-08 10:11 ` Borislav Petkov [this message] 2021-11-08 10:11 ` [PATCH v0 06/42] firmware: " Borislav Petkov 2021-11-12 18:43 ` Cristian Marussi 2021-11-12 18:43 ` Cristian Marussi 2021-11-08 10:11 ` [PATCH v0 07/42] drm/i915: " Borislav Petkov 2021-11-08 10:11 ` [Intel-gfx] " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 08/42] Drivers: hv: vmbus: " Borislav Petkov 2021-11-08 11:16 ` Wei Liu 2021-11-08 11:39 ` Borislav Petkov 2021-11-08 11:45 ` Wei Liu 2021-11-08 12:08 ` Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 09/42] iio: proximity: cros_ec: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 10/42] leds: trigger: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 11/42] misc: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 12/42] ethernet: chelsio: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 13/42] power: reset: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 14/42] remoteproc: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 15/42] scsi: target: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 16/42] USB: " Borislav Petkov 2021-11-08 14:05 ` Alan Stern 2021-11-08 14:09 ` Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 17/42] drivers: video: " Borislav Petkov 2021-11-08 11:16 ` Wei Liu 2021-11-08 10:11 ` [PATCH v0 18/42] drivers/xen: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 19/42] kernel/hung_task: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 20/42] rcu: " Borislav Petkov 2021-11-08 16:53 ` Paul E. McKenney 2021-11-08 10:11 ` [PATCH v0 21/42] tracing: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 22/42] net: fib_notifier: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 23/42] ASoC: soc-jack: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 24/42] staging: olpc_dcon: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 25/42] arch/um: " Borislav Petkov 2021-11-08 10:11 ` Borislav Petkov 2021-11-08 10:23 ` Johannes Berg 2021-11-08 10:23 ` Johannes Berg 2021-11-08 10:48 ` Borislav Petkov 2021-11-08 10:48 ` Borislav Petkov 2021-11-08 10:56 ` Johannes Berg 2021-11-08 10:56 ` Johannes Berg 2021-11-08 10:11 ` [PATCH v0 26/42] alpha: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 27/42] bus: brcmstb_gisb: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 28/42] soc: bcm: brcmstb: pm: pm-arm: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 29/42] arm64: " Borislav Petkov 2021-11-08 10:11 ` Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 30/42] soc/tegra: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 31/42] parisc: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 32/42] macintosh/adb: " Borislav Petkov 2021-11-08 10:11 ` Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 33/42] mips: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 34/42] powerpc: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 35/42] sh: " Borislav Petkov 2021-11-08 13:31 ` Geert Uytterhoeven 2021-11-08 13:49 ` Borislav Petkov 2021-11-08 14:03 ` Geert Uytterhoeven 2021-11-08 14:48 ` Sergey Shtylyov 2021-11-08 10:11 ` [PATCH v0 36/42] s390: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 37/42] sparc: " Borislav Petkov 2021-11-08 19:59 ` David Miller 2021-11-08 10:11 ` [PATCH v0 38/42] xtensa: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 39/42] crypto: ccree - check " Borislav Petkov 2021-11-12 18:32 ` Cristian Marussi 2021-11-12 18:48 ` Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 40/42] EDAC/altera: Check " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 41/42] power: supply: ab8500: " Borislav Petkov 2021-11-08 10:11 ` [PATCH v0 42/42] notifier: Return an error when callback is already registered Borislav Petkov 2021-11-08 10:11 ` Borislav Petkov 2021-11-08 10:11 ` Borislav Petkov 2021-11-08 10:11 ` Borislav Petkov 2021-11-08 10:11 ` [Intel-gfx] " Borislav Petkov 2021-11-08 10:11 ` Borislav Petkov 2021-11-08 14:07 ` Geert Uytterhoeven 2021-11-08 14:07 ` Geert Uytterhoeven 2021-11-08 14:07 ` Geert Uytterhoeven 2021-11-08 14:07 ` [Intel-gfx] " Geert Uytterhoeven 2021-11-08 14:07 ` Geert Uytterhoeven 2021-11-08 14:21 ` Borislav Petkov 2021-11-08 14:21 ` Borislav Petkov 2021-11-08 14:21 ` Borislav Petkov 2021-11-08 14:21 ` [Intel-gfx] " Borislav Petkov 2021-11-08 14:21 ` Borislav Petkov 2021-11-08 15:25 ` Geert Uytterhoeven 2021-11-08 15:25 ` Geert Uytterhoeven 2021-11-08 15:25 ` Geert Uytterhoeven 2021-11-08 15:25 ` Geert Uytterhoeven 2021-11-08 15:25 ` [Intel-gfx] " Geert Uytterhoeven 2021-11-08 15:58 ` Borislav Petkov 2021-11-08 15:58 ` Borislav Petkov 2021-11-08 15:58 ` Borislav Petkov 2021-11-08 15:58 ` [Intel-gfx] " Borislav Petkov 2021-11-08 15:58 ` Borislav Petkov 2021-11-08 16:12 ` Geert Uytterhoeven 2021-11-08 16:12 ` Geert Uytterhoeven 2021-11-08 16:12 ` Geert Uytterhoeven 2021-11-08 16:12 ` [Intel-gfx] " Geert Uytterhoeven 2021-11-08 16:12 ` Geert Uytterhoeven 2021-11-08 16:21 ` Borislav Petkov 2021-11-08 16:21 ` Borislav Petkov 2021-11-08 16:21 ` Borislav Petkov 2021-11-08 16:21 ` Borislav Petkov 2021-11-08 16:21 ` [Intel-gfx] " Borislav Petkov 2021-11-08 20:59 ` Alan Stern 2021-11-08 20:59 ` Alan Stern 2021-11-08 20:59 ` Alan Stern 2021-11-08 20:59 ` Alan Stern 2021-11-08 20:59 ` [Intel-gfx] " Alan Stern 2021-11-08 20:59 ` Alan Stern 2021-11-08 21:18 ` [Intel-gfx] " Borislav Petkov 2021-11-08 21:18 ` Borislav Petkov 2021-11-08 21:18 ` Borislav Petkov 2021-11-08 21:18 ` Borislav Petkov 2021-11-08 21:18 ` Borislav Petkov 2021-11-08 10:19 ` [PATCH v0 00/42] notifiers: " Borislav Petkov 2021-11-08 10:19 ` Borislav Petkov 2021-11-08 10:19 ` Borislav Petkov 2021-11-08 10:19 ` Borislav Petkov 2021-11-08 10:19 ` Borislav Petkov 2021-11-08 10:19 ` [Intel-gfx] " Borislav Petkov 2021-11-08 14:17 ` Alan Stern 2021-11-08 14:17 ` Alan Stern 2021-11-08 14:17 ` Alan Stern 2021-11-08 14:17 ` Alan Stern 2021-11-08 14:17 ` [Intel-gfx] " Alan Stern 2021-11-08 14:17 ` Alan Stern 2021-11-08 14:24 ` Borislav Petkov 2021-11-08 14:24 ` Borislav Petkov 2021-11-08 14:24 ` Borislav Petkov 2021-11-08 14:24 ` Borislav Petkov 2021-11-08 14:24 ` [Intel-gfx] " Borislav Petkov 2021-11-08 14:24 ` Borislav Petkov 2021-11-08 14:35 ` Borislav Petkov 2021-11-08 14:35 ` Borislav Petkov 2021-11-08 14:35 ` Borislav Petkov 2021-11-08 14:35 ` [Intel-gfx] " Borislav Petkov 2021-11-08 14:35 ` Borislav Petkov 2021-11-08 16:23 ` Steven Rostedt 2021-11-08 16:23 ` Steven Rostedt 2021-11-08 16:23 ` Steven Rostedt 2021-11-08 16:23 ` [Intel-gfx] " Steven Rostedt 2021-11-08 16:23 ` Steven Rostedt 2021-11-08 16:29 ` Borislav Petkov 2021-11-08 16:29 ` Borislav Petkov 2021-11-08 16:29 ` Borislav Petkov 2021-11-08 16:29 ` [Intel-gfx] " Borislav Petkov 2021-11-08 16:29 ` Borislav Petkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211108101157.15189-7-bp@alien8.de \ --to=bp@alien8.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.