From: Peter Chen <peter.chen@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: bpf@vger.kernel.org, axboe@kernel.dk,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch,
jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, yuq825@gmail.com, robdclark@gmail.com,
sean@poorly.run, christian.koenig@amd.com, ray.huang@amd.com,
sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
hkelam@marvell.com, jingoohan1@gmail.com,
lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com,
bhelgaas@google.com, krzysztof.kozlowski@canonical.com,
mani@kernel.org, pawell@cadence.com, rogerq@kernel.org,
a-govindraju@ti.com, gregkh@linuxfoundation.org, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, sj@kernel.org, akpm@linux-foundation.org,
thomas.hellstrom@linux.intel.com, matthew.auld@intel.com,
colin.king@intel.com, geert@linux-m68k.org,
linux-block@vger.kernel.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, lima@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency
Date: Tue, 23 Nov 2021 20:51:08 +0800 [thread overview]
Message-ID: <20211123125108.GA4453@Peter> (raw)
In-Reply-To: <20211120072602.22f9e722@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 21-11-20 07:26:02, Jakub Kicinski wrote:
> On Sat, 20 Nov 2021 15:30:11 +0800 Peter Chen wrote:
> > > diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c
> > > index 84dadfa726aa..9643b905e2d8 100644
> > > --- a/drivers/usb/cdns3/host.c
> > > +++ b/drivers/usb/cdns3/host.c
> > > @@ -10,6 +10,7 @@
> > > */
> > >
> > > #include <linux/platform_device.h>
> > > +#include <linux/slab.h>
> >
> > Should be "#include <linux/module.h>"?
>
> Why? Different files are missing different includes, this one needs
> slab.h:
>
> ../drivers/usb/cdns3/host.c: In function ‘__cdns_host_init’:
> ../drivers/usb/cdns3/host.c:86:2: error: implicit declaration of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]
> kfree(cdns->xhci_plat_data);
> ^~~~~
> vfree
Oh, my fault.
Acked-by: Peter Chen <peter.chen@kernel.org>
--
Thanks,
Peter Chen
WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <peter.chen@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: kw@linux.com, songliubraving@fb.com, kafai@fb.com,
airlied@linux.ie, linux-pci@vger.kernel.org, ast@kernel.org,
dri-devel@lists.freedesktop.org, andrii@kernel.org,
a-govindraju@ti.com, ray.huang@amd.com, sbhatta@marvell.com,
lorenzo.pieralisi@arm.com, daniel@iogearbox.net,
krzysztof.kozlowski@canonical.com, john.fastabend@gmail.com,
geert@linux-m68k.org, matthew.auld@intel.com, yhs@fb.com,
sgoutham@marvell.com, thomas.hellstrom@linux.intel.com,
pawell@cadence.com, tzimmermann@suse.de, mani@kernel.org,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
kpsingh@kernel.org, rogerq@kernel.org,
linux-samsung-soc@vger.kernel.org, rodrigo.vivi@intel.com,
bhelgaas@google.com, sean@poorly.run, akpm@linux-foundation.org,
linux-arm-kernel@lists.infradead.org, axboe@kernel.dk,
linux-block@vger.kernel.org, sj@kernel.org,
lima@lists.freedesktop.org, linux-mm@kvack.org,
jingoohan1@gmail.com, linux-usb@vger.kernel.org,
christian.koenig@amd.com, hkelam@marvell.com, yuq825@gmail.com,
gregkh@linuxfoundation.org, bpf@vger.kernel.org,
colin.king@intel.com, freedreno@lists.freedesktop.org,
gakula@marvell.com
Subject: Re: [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency
Date: Tue, 23 Nov 2021 20:51:08 +0800 [thread overview]
Message-ID: <20211123125108.GA4453@Peter> (raw)
In-Reply-To: <20211120072602.22f9e722@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 21-11-20 07:26:02, Jakub Kicinski wrote:
> On Sat, 20 Nov 2021 15:30:11 +0800 Peter Chen wrote:
> > > diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c
> > > index 84dadfa726aa..9643b905e2d8 100644
> > > --- a/drivers/usb/cdns3/host.c
> > > +++ b/drivers/usb/cdns3/host.c
> > > @@ -10,6 +10,7 @@
> > > */
> > >
> > > #include <linux/platform_device.h>
> > > +#include <linux/slab.h>
> >
> > Should be "#include <linux/module.h>"?
>
> Why? Different files are missing different includes, this one needs
> slab.h:
>
> ../drivers/usb/cdns3/host.c: In function ‘__cdns_host_init’:
> ../drivers/usb/cdns3/host.c:86:2: error: implicit declaration of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]
> kfree(cdns->xhci_plat_data);
> ^~~~~
> vfree
Oh, my fault.
Acked-by: Peter Chen <peter.chen@kernel.org>
--
Thanks,
Peter Chen
WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <peter.chen@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: kw@linux.com, songliubraving@fb.com, kafai@fb.com,
airlied@linux.ie, linux-pci@vger.kernel.org, ast@kernel.org,
dri-devel@lists.freedesktop.org, andrii@kernel.org,
a-govindraju@ti.com, ray.huang@amd.com, sbhatta@marvell.com,
robh@kernel.org, lorenzo.pieralisi@arm.com, daniel@iogearbox.net,
krzysztof.kozlowski@canonical.com, john.fastabend@gmail.com,
geert@linux-m68k.org, matthew.auld@intel.com, yhs@fb.com,
sgoutham@marvell.com, thomas.hellstrom@linux.intel.com,
pawell@cadence.com, tzimmermann@suse.de, mani@kernel.org,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
mripard@kernel.org, kpsingh@kernel.org, rogerq@kernel.org,
linux-samsung-soc@vger.kernel.org, bhelgaas@google.com,
akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org,
axboe@kernel.dk, linux-block@vger.kernel.org, sj@kernel.org,
lima@lists.freedesktop.org, linux-mm@kvack.org,
jingoohan1@gmail.com, linux-usb@vger.kernel.org,
christian.koenig@amd.com, hkelam@marvell.com, yuq825@gmail.com,
gregkh@linuxfoundation.org, bpf@vger.kernel.org,
colin.king@intel.com, freedreno@lists.freedesktop.org,
gakula@marvell.com
Subject: Re: [Intel-gfx] [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency
Date: Tue, 23 Nov 2021 20:51:08 +0800 [thread overview]
Message-ID: <20211123125108.GA4453@Peter> (raw)
In-Reply-To: <20211120072602.22f9e722@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 21-11-20 07:26:02, Jakub Kicinski wrote:
> On Sat, 20 Nov 2021 15:30:11 +0800 Peter Chen wrote:
> > > diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c
> > > index 84dadfa726aa..9643b905e2d8 100644
> > > --- a/drivers/usb/cdns3/host.c
> > > +++ b/drivers/usb/cdns3/host.c
> > > @@ -10,6 +10,7 @@
> > > */
> > >
> > > #include <linux/platform_device.h>
> > > +#include <linux/slab.h>
> >
> > Should be "#include <linux/module.h>"?
>
> Why? Different files are missing different includes, this one needs
> slab.h:
>
> ../drivers/usb/cdns3/host.c: In function ‘__cdns_host_init’:
> ../drivers/usb/cdns3/host.c:86:2: error: implicit declaration of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]
> kfree(cdns->xhci_plat_data);
> ^~~~~
> vfree
Oh, my fault.
Acked-by: Peter Chen <peter.chen@kernel.org>
--
Thanks,
Peter Chen
next prev parent reply other threads:[~2021-11-23 12:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 3:52 [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency Jakub Kicinski
2021-11-20 3:52 ` [Intel-gfx] " Jakub Kicinski
2021-11-20 3:52 ` Jakub Kicinski
2021-11-20 4:47 ` Krzysztof Wilczyński
2021-11-20 4:47 ` [Intel-gfx] " Krzysztof Wilczyński
2021-11-20 4:47 ` Krzysztof Wilczyński
2021-11-20 7:01 ` kernel test robot
2021-11-20 7:01 ` kernel test robot
2021-11-20 16:40 ` Jakub Kicinski
2021-11-20 16:40 ` Jakub Kicinski
2021-11-20 7:30 ` Peter Chen
2021-11-20 7:30 ` [Intel-gfx] " Peter Chen
2021-11-20 7:30 ` Peter Chen
2021-11-20 15:26 ` Jakub Kicinski
2021-11-20 15:26 ` [Intel-gfx] " Jakub Kicinski
2021-11-20 15:26 ` Jakub Kicinski
2021-11-23 12:51 ` Peter Chen [this message]
2021-11-23 12:51 ` [Intel-gfx] " Peter Chen
2021-11-23 12:51 ` Peter Chen
2021-11-20 7:39 ` SeongJae Park
2021-11-20 7:39 ` [Intel-gfx] " SeongJae Park
2021-11-20 7:39 ` SeongJae Park
2021-11-20 8:55 ` kernel test robot
2021-11-20 8:55 ` kernel test robot
2021-11-20 15:34 ` Jakub Kicinski
2021-11-20 15:34 ` Jakub Kicinski
2021-12-06 2:21 ` [kbuild-all] " Rong Chen
2021-12-06 2:21 ` Rong Chen
2021-12-06 21:01 ` [kbuild-all] " Jakub Kicinski
2021-12-06 21:01 ` Jakub Kicinski
2021-11-22 9:29 ` Jani Nikula
2021-11-22 9:29 ` [Intel-gfx] " Jani Nikula
2021-11-22 9:29 ` Jani Nikula
2021-11-22 14:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2021-11-22 14:46 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211123125108.GA4453@Peter \
--to=peter.chen@kernel.org \
--cc=a-govindraju@ti.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=bpf@vger.kernel.org \
--cc=christian.koenig@amd.com \
--cc=colin.king@intel.com \
--cc=daniel@ffwll.ch \
--cc=daniel@iogearbox.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gakula@marvell.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hkelam@marvell.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jingoohan1@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kuba@kernel.org \
--cc=kw@linux.com \
--cc=lima@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mani@kernel.org \
--cc=matthew.auld@intel.com \
--cc=mripard@kernel.org \
--cc=pawell@cadence.com \
--cc=ray.huang@amd.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=rogerq@kernel.org \
--cc=sbhatta@marvell.com \
--cc=sean@poorly.run \
--cc=sgoutham@marvell.com \
--cc=sj@kernel.org \
--cc=songliubraving@fb.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=yhs@fb.com \
--cc=yuq825@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.