From: Maxime Ripard <maxime@cerno.tech>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: emma@anholt.net, airlied@linux.ie,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
kieran.bingham+renesas@ideasonboard.com,
laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 3/3] drm/cma-helper: Pass GEM CMA object in public interfaces
Date: Mon, 29 Nov 2021 10:57:28 +0100 [thread overview]
Message-ID: <20211129095728.doyt5xllwbvkawlk@houat> (raw)
In-Reply-To: <20211115120148.21766-4-tzimmermann@suse.de>
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On Mon, Nov 15, 2021 at 01:01:48PM +0100, Thomas Zimmermann wrote:
> Change all GEM CMA object functions that receive a GEM object
> of type struct drm_gem_object to expect an object of type
> struct drm_gem_cma_object instead.
>
> This change reduces the number of upcasts from struct drm_gem_object
> by moving them into callers. The C compiler can now verify that the
> GEM CMA functions are called with the correct type.
>
> For consistency, the patch also renames drm_gem_cma_free_object to
> drm_gem_cma_free. It further updates documentation for a number of
> functions.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: daniel@ffwll.ch, airlied@linux.ie,
maarten.lankhorst@linux.intel.com,
laurent.pinchart@ideasonboard.com,
kieran.bingham+renesas@ideasonboard.com, emma@anholt.net,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 3/3] drm/cma-helper: Pass GEM CMA object in public interfaces
Date: Mon, 29 Nov 2021 10:57:28 +0100 [thread overview]
Message-ID: <20211129095728.doyt5xllwbvkawlk@houat> (raw)
In-Reply-To: <20211115120148.21766-4-tzimmermann@suse.de>
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On Mon, Nov 15, 2021 at 01:01:48PM +0100, Thomas Zimmermann wrote:
> Change all GEM CMA object functions that receive a GEM object
> of type struct drm_gem_object to expect an object of type
> struct drm_gem_cma_object instead.
>
> This change reduces the number of upcasts from struct drm_gem_object
> by moving them into callers. The C compiler can now verify that the
> GEM CMA functions are called with the correct type.
>
> For consistency, the patch also renames drm_gem_cma_free_object to
> drm_gem_cma_free. It further updates documentation for a number of
> functions.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-11-29 9:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 12:01 [PATCH 0/3] drm/cma-helper: Clean up public interface Thomas Zimmermann
2021-11-15 12:01 ` Thomas Zimmermann
2021-11-15 12:01 ` [PATCH 1/3] drm/cma-helper: Move driver and file ops to the end of header Thomas Zimmermann
2021-11-15 12:01 ` Thomas Zimmermann
2021-11-15 13:40 ` Laurent Pinchart
2021-11-15 13:40 ` Laurent Pinchart
2021-11-16 8:59 ` Thomas Zimmermann
2021-11-16 8:59 ` Thomas Zimmermann
2021-11-29 9:58 ` Maxime Ripard
2021-11-29 9:58 ` Maxime Ripard
2021-11-15 12:01 ` [PATCH 2/3] drm/cma-helper: Export dedicated wrappers for GEM object functions Thomas Zimmermann
2021-11-15 12:01 ` Thomas Zimmermann
2021-11-29 9:56 ` Maxime Ripard
2021-11-29 9:56 ` Maxime Ripard
2021-11-15 12:01 ` [PATCH 3/3] drm/cma-helper: Pass GEM CMA object in public interfaces Thomas Zimmermann
2021-11-15 12:01 ` Thomas Zimmermann
2021-11-15 13:50 ` Laurent Pinchart
2021-11-15 13:50 ` Laurent Pinchart
2021-11-16 9:04 ` Thomas Zimmermann
2021-11-16 9:04 ` Thomas Zimmermann
2021-11-29 9:57 ` Maxime Ripard [this message]
2021-11-29 9:57 ` Maxime Ripard
2021-11-29 9:51 ` [PATCH 0/3] drm/cma-helper: Clean up public interface Thomas Zimmermann
2021-11-29 9:51 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211129095728.doyt5xllwbvkawlk@houat \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.