From: Shawn Guo <shawnguo@kernel.org> To: Alistair Francis <alistair@alistair23.me> Cc: benjamin.tissoires@redhat.com, s.hauer@pengutronix.de, dmitry.torokhov@gmail.com, Ping.Cheng@wacom.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, alistair23@gmail.com, tatsunosuke.tobita@wacom.com, linux-input@vger.kernel.org, Jason.Gerecke@wacom.com, linux-kernel@vger.kernel.org, jikos@kernel.org, martin.chen@wacom.com, devicetree@vger.kernel.org Subject: Re: [PATCH v15 3/3] ARM: dts: imx7d: remarkable2: add wacom digitizer device Date: Mon, 6 Dec 2021 11:03:46 +0800 [thread overview] Message-ID: <20211206030343.GA4216@dragon> (raw) In-Reply-To: <20211202115622.40153-4-alistair@alistair23.me> On Thu, Dec 02, 2021 at 09:56:22PM +1000, Alistair Francis wrote: > Signed-off-by: Alistair Francis <alistair@alistair23.me> Please write up some commit log. Shawn > --- > arch/arm/boot/dts/imx7d-remarkable2.dts | 59 +++++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts > index 89cbf13097a4..a2a91bfdd98e 100644 > --- a/arch/arm/boot/dts/imx7d-remarkable2.dts > +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts > @@ -34,6 +34,19 @@ reg_brcm: regulator-brcm { > startup-delay-us = <150>; > }; > > + reg_digitizer: regulator-digitizer { > + compatible = "regulator-fixed"; > + regulator-name = "VDD_3V3_DIGITIZER"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&pinctrl_digitizer_reg>; > + pinctrl-1 = <&pinctrl_digitizer_reg>; > + gpio = <&gpio1 6 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + startup-delay-us = <100000>; /* 100 ms */ > + }; > + > wifi_pwrseq: wifi_pwrseq { > compatible = "mmc-pwrseq-simple"; > pinctrl-names = "default"; > @@ -51,6 +64,26 @@ &clks { > assigned-clock-rates = <0>, <32768>; > }; > > +&i2c1 { > + clock-frequency = <400000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c1>; > + status = "okay"; > + > + wacom_digitizer: digitizer@9 { > + compatible = "hid-over-i2c"; > + reg = <0x09>; > + hid-descr-addr = <0x01>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wacom>; > + interrupt-parent = <&gpio1>; > + interrupts = <1 IRQ_TYPE_LEVEL_LOW>; > + touchscreen-inverted-x; > + touchscreen-inverted-y; > + vdd-supply = <®_digitizer>; > + }; > +}; > + > &snvs_pwrkey { > status = "okay"; > }; > @@ -117,6 +150,25 @@ &wdog1 { > fsl,ext-reset-output; > }; > > +&iomuxc_lpsr { > + pinctrl_digitizer_reg: digitizerreggrp { > + fsl,pins = < > + /* DIGITIZER_PWR_EN */ > + MX7D_PAD_LPSR_GPIO1_IO06__GPIO1_IO6 0x14 > + >; > + }; > + > + pinctrl_wacom: wacomgrp { > + fsl,pins = < > + /*MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5 0x00000014 FWE */ > + MX7D_PAD_LPSR_GPIO1_IO04__GPIO1_IO4 0x00000074 /* PDCTB */ > + MX7D_PAD_LPSR_GPIO1_IO01__GPIO1_IO1 0x00000034 /* WACOM INT */ > + /*MX7D_PAD_LPSR_GPIO1_IO06__GPIO1_IO6 0x00000014 WACOM PWR ENABLE */ > + /*MX7D_PAD_LPSR_GPIO1_IO00__GPIO1_IO0 0x00000074 WACOM RESET */ > + >; > + }; > +}; > + > &iomuxc { > pinctrl_brcm_reg: brcmreggrp { > fsl,pins = < > @@ -125,6 +177,13 @@ MX7D_PAD_SAI1_TX_BCLK__GPIO6_IO13 0x14 > >; > }; > > + pinctrl_i2c1: i2c1grp { > + fsl,pins = < > + MX7D_PAD_I2C1_SDA__I2C1_SDA 0x4000007f > + MX7D_PAD_I2C1_SCL__I2C1_SCL 0x4000007f > + >; > + }; > + > pinctrl_uart1: uart1grp { > fsl,pins = < > MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX 0x79 > -- > 2.31.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org> To: Alistair Francis <alistair@alistair23.me> Cc: benjamin.tissoires@redhat.com, s.hauer@pengutronix.de, dmitry.torokhov@gmail.com, Ping.Cheng@wacom.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, alistair23@gmail.com, tatsunosuke.tobita@wacom.com, linux-input@vger.kernel.org, Jason.Gerecke@wacom.com, linux-kernel@vger.kernel.org, jikos@kernel.org, martin.chen@wacom.com, devicetree@vger.kernel.org Subject: Re: [PATCH v15 3/3] ARM: dts: imx7d: remarkable2: add wacom digitizer device Date: Mon, 6 Dec 2021 11:03:46 +0800 [thread overview] Message-ID: <20211206030343.GA4216@dragon> (raw) In-Reply-To: <20211202115622.40153-4-alistair@alistair23.me> On Thu, Dec 02, 2021 at 09:56:22PM +1000, Alistair Francis wrote: > Signed-off-by: Alistair Francis <alistair@alistair23.me> Please write up some commit log. Shawn > --- > arch/arm/boot/dts/imx7d-remarkable2.dts | 59 +++++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts > index 89cbf13097a4..a2a91bfdd98e 100644 > --- a/arch/arm/boot/dts/imx7d-remarkable2.dts > +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts > @@ -34,6 +34,19 @@ reg_brcm: regulator-brcm { > startup-delay-us = <150>; > }; > > + reg_digitizer: regulator-digitizer { > + compatible = "regulator-fixed"; > + regulator-name = "VDD_3V3_DIGITIZER"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&pinctrl_digitizer_reg>; > + pinctrl-1 = <&pinctrl_digitizer_reg>; > + gpio = <&gpio1 6 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + startup-delay-us = <100000>; /* 100 ms */ > + }; > + > wifi_pwrseq: wifi_pwrseq { > compatible = "mmc-pwrseq-simple"; > pinctrl-names = "default"; > @@ -51,6 +64,26 @@ &clks { > assigned-clock-rates = <0>, <32768>; > }; > > +&i2c1 { > + clock-frequency = <400000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c1>; > + status = "okay"; > + > + wacom_digitizer: digitizer@9 { > + compatible = "hid-over-i2c"; > + reg = <0x09>; > + hid-descr-addr = <0x01>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wacom>; > + interrupt-parent = <&gpio1>; > + interrupts = <1 IRQ_TYPE_LEVEL_LOW>; > + touchscreen-inverted-x; > + touchscreen-inverted-y; > + vdd-supply = <®_digitizer>; > + }; > +}; > + > &snvs_pwrkey { > status = "okay"; > }; > @@ -117,6 +150,25 @@ &wdog1 { > fsl,ext-reset-output; > }; > > +&iomuxc_lpsr { > + pinctrl_digitizer_reg: digitizerreggrp { > + fsl,pins = < > + /* DIGITIZER_PWR_EN */ > + MX7D_PAD_LPSR_GPIO1_IO06__GPIO1_IO6 0x14 > + >; > + }; > + > + pinctrl_wacom: wacomgrp { > + fsl,pins = < > + /*MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5 0x00000014 FWE */ > + MX7D_PAD_LPSR_GPIO1_IO04__GPIO1_IO4 0x00000074 /* PDCTB */ > + MX7D_PAD_LPSR_GPIO1_IO01__GPIO1_IO1 0x00000034 /* WACOM INT */ > + /*MX7D_PAD_LPSR_GPIO1_IO06__GPIO1_IO6 0x00000014 WACOM PWR ENABLE */ > + /*MX7D_PAD_LPSR_GPIO1_IO00__GPIO1_IO0 0x00000074 WACOM RESET */ > + >; > + }; > +}; > + > &iomuxc { > pinctrl_brcm_reg: brcmreggrp { > fsl,pins = < > @@ -125,6 +177,13 @@ MX7D_PAD_SAI1_TX_BCLK__GPIO6_IO13 0x14 > >; > }; > > + pinctrl_i2c1: i2c1grp { > + fsl,pins = < > + MX7D_PAD_I2C1_SDA__I2C1_SDA 0x4000007f > + MX7D_PAD_I2C1_SCL__I2C1_SCL 0x4000007f > + >; > + }; > + > pinctrl_uart1: uart1grp { > fsl,pins = < > MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX 0x79 > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-06 3:03 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-02 11:56 [PATCH v15 0/3] Add Wacom I2C support to rM2 Alistair Francis 2021-12-02 11:56 ` Alistair Francis 2021-12-02 11:56 ` [PATCH v15 1/3] HID: quirks: Allow inverting the absolute X/Y values Alistair Francis 2021-12-02 11:56 ` Alistair Francis 2021-12-02 11:56 ` [PATCH v15 2/3] HID: i2c-hid-of: Expose the touchscreen-inverted properties Alistair Francis 2021-12-02 11:56 ` Alistair Francis 2021-12-02 11:56 ` [PATCH v15 3/3] ARM: dts: imx7d: remarkable2: add wacom digitizer device Alistair Francis 2021-12-02 11:56 ` Alistair Francis 2021-12-03 15:57 ` Benjamin Tissoires 2021-12-03 15:57 ` Benjamin Tissoires 2021-12-06 3:00 ` Shawn Guo 2021-12-06 3:00 ` Shawn Guo 2021-12-06 3:03 ` Shawn Guo [this message] 2021-12-06 3:03 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211206030343.GA4216@dragon \ --to=shawnguo@kernel.org \ --cc=Jason.Gerecke@wacom.com \ --cc=Ping.Cheng@wacom.com \ --cc=alistair23@gmail.com \ --cc=alistair@alistair23.me \ --cc=benjamin.tissoires@redhat.com \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=jikos@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=martin.chen@wacom.com \ --cc=s.hauer@pengutronix.de \ --cc=tatsunosuke.tobita@wacom.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.