From: Ameer Hamza <amhamza.mgc@gmail.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ASoC: test-component: fix null pointer dereference.
Date: Wed, 8 Dec 2021 17:05:26 +0500 [thread overview]
Message-ID: <20211208120526.GA12550@hamza-OptiPlex-7040> (raw)
In-Reply-To: <TYCPR01MB55814819F7AAAC654084615AD46F9@TYCPR01MB5581.jpnprd01.prod.outlook.com>
On Wed, Dec 08, 2021 at 12:05:46AM +0000, Kuninori Morimoto wrote:
>
> Hi Ameer
>
> Ah, you posted the patch :)
>
> > Subject: [PATCH v2] ASoC: test-component: fix null pointer dereference.
> >
> > Dereferncing of_id pointer will result in exception in current
> > implementation since of_match_device() will assign it to NULL.
> > Adding NULL check for protection.
>
> Previous your patch was already accepted,
> thus this is not v2 patch.
> git log should indicate is replace of_match_device() to of_device_get_match_data()
Thank you for your kind response and clarifying the process. Let me send
the updated patch. :)
Best Regards,
Ameer Hamza.
WARNING: multiple messages have this Message-ID (diff)
From: Ameer Hamza <amhamza.mgc@gmail.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH v2] ASoC: test-component: fix null pointer dereference.
Date: Wed, 8 Dec 2021 17:05:26 +0500 [thread overview]
Message-ID: <20211208120526.GA12550@hamza-OptiPlex-7040> (raw)
In-Reply-To: <TYCPR01MB55814819F7AAAC654084615AD46F9@TYCPR01MB5581.jpnprd01.prod.outlook.com>
On Wed, Dec 08, 2021 at 12:05:46AM +0000, Kuninori Morimoto wrote:
>
> Hi Ameer
>
> Ah, you posted the patch :)
>
> > Subject: [PATCH v2] ASoC: test-component: fix null pointer dereference.
> >
> > Dereferncing of_id pointer will result in exception in current
> > implementation since of_match_device() will assign it to NULL.
> > Adding NULL check for protection.
>
> Previous your patch was already accepted,
> thus this is not v2 patch.
> git log should indicate is replace of_match_device() to of_device_get_match_data()
Thank you for your kind response and clarifying the process. Let me send
the updated patch. :)
Best Regards,
Ameer Hamza.
next prev parent reply other threads:[~2021-12-08 12:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 20:42 [PATCH] ASoC: test-component: fix null pointer dereference Ameer Hamza
2021-12-05 20:42 ` Ameer Hamza
2021-12-05 22:40 ` Kuninori Morimoto
2021-12-06 9:29 ` Ameer Hamza
2021-12-06 9:29 ` Ameer Hamza
2021-12-06 23:19 ` Kuninori Morimoto
2021-12-06 23:19 ` Kuninori Morimoto
2021-12-07 8:15 ` Ameer Hamza
2021-12-07 8:15 ` Ameer Hamza
2021-12-07 12:51 ` Mark Brown
2021-12-07 12:51 ` Mark Brown
2021-12-07 14:23 ` [PATCH v2] " Ameer Hamza
2021-12-07 14:23 ` Ameer Hamza
2021-12-08 0:05 ` Kuninori Morimoto
2021-12-08 12:05 ` Ameer Hamza [this message]
2021-12-08 12:05 ` Ameer Hamza
2021-12-08 12:36 ` [PATCH] ASoC: test-component: replace of_match_device() to of_device_get_match_data() Ameer Hamza
2021-12-08 12:36 ` Ameer Hamza
2021-12-08 12:40 ` Ameer Hamza
2021-12-08 12:40 ` Ameer Hamza
2021-12-08 22:40 ` Kuninori Morimoto
2021-12-08 22:40 ` Kuninori Morimoto
2021-12-09 13:45 ` [PATCH v2] ASoC: test-component: fix null pointer dereference Mark Brown
2021-12-07 23:53 ` [PATCH] " Kuninori Morimoto
2021-12-07 23:53 ` Kuninori Morimoto
2021-12-06 18:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208120526.GA12550@hamza-OptiPlex-7040 \
--to=amhamza.mgc@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.