From: Eugen Hristev <eugen.hristev@microchip.com> To: <linux-media@vger.kernel.org>, <robh+dt@kernel.org>, <jacopo@jmondi.org>, <laurent.pinchart@ideasonboard.com>, <sakari.ailus@iki.fi> Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <nicolas.ferre@microchip.com>, "Eugen Hristev" <eugen.hristev@microchip.com> Subject: [PATCH v3 16/23] media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check Date: Mon, 13 Dec 2021 15:49:33 +0200 [thread overview] Message-ID: <20211213134940.324266-17-eugen.hristev@microchip.com> (raw) In-Reply-To: <20211213134940.324266-1-eugen.hristev@microchip.com> While this does not happen in production, this check should be done versus the mask, as checking with the YCYC value may not include some bits that may be set. Is it correct and safe to check the whole mask. Fixes: 123aaf816b95 ("media: atmel: atmel-sama5d2-isc: fix YUYV format") Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> --- drivers/media/platform/atmel/atmel-sama5d2-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c index a3e4c32a66c4..a8d4ba60d3ac 100644 --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c @@ -267,7 +267,7 @@ static void isc_sama5d2_config_rlp(struct isc_device *isc) * Thus, if the YCYC mode is selected, replace it with the * sama5d2-compliant mode which is YYCC . */ - if ((rlp_mode & ISC_RLP_CFG_MODE_YCYC) == ISC_RLP_CFG_MODE_YCYC) { + if ((rlp_mode & ISC_RLP_CFG_MODE_MASK) == ISC_RLP_CFG_MODE_YCYC) { rlp_mode &= ~ISC_RLP_CFG_MODE_MASK; rlp_mode |= ISC_RLP_CFG_MODE_YYCC; } -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Eugen Hristev <eugen.hristev@microchip.com> To: <linux-media@vger.kernel.org>, <robh+dt@kernel.org>, <jacopo@jmondi.org>, <laurent.pinchart@ideasonboard.com>, <sakari.ailus@iki.fi> Cc: devicetree@vger.kernel.org, Eugen Hristev <eugen.hristev@microchip.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 16/23] media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check Date: Mon, 13 Dec 2021 15:49:33 +0200 [thread overview] Message-ID: <20211213134940.324266-17-eugen.hristev@microchip.com> (raw) In-Reply-To: <20211213134940.324266-1-eugen.hristev@microchip.com> While this does not happen in production, this check should be done versus the mask, as checking with the YCYC value may not include some bits that may be set. Is it correct and safe to check the whole mask. Fixes: 123aaf816b95 ("media: atmel: atmel-sama5d2-isc: fix YUYV format") Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> --- drivers/media/platform/atmel/atmel-sama5d2-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c index a3e4c32a66c4..a8d4ba60d3ac 100644 --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c @@ -267,7 +267,7 @@ static void isc_sama5d2_config_rlp(struct isc_device *isc) * Thus, if the YCYC mode is selected, replace it with the * sama5d2-compliant mode which is YYCC . */ - if ((rlp_mode & ISC_RLP_CFG_MODE_YCYC) == ISC_RLP_CFG_MODE_YCYC) { + if ((rlp_mode & ISC_RLP_CFG_MODE_MASK) == ISC_RLP_CFG_MODE_YCYC) { rlp_mode &= ~ISC_RLP_CFG_MODE_MASK; rlp_mode |= ISC_RLP_CFG_MODE_YYCC; } -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-13 13:54 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-13 13:49 [PATCH v3 00/23] media: atmel: atmel-isc: implement media controller Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2021-12-13 13:49 ` [PATCH v3 01/23] MAINTAINERS: add microchip csi2dc Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2021-12-13 13:49 ` [PATCH v3 02/23] dt-bindings: media: atmel: csi2dc: add bindings for " Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2021-12-15 20:16 ` Rob Herring 2021-12-15 20:16 ` Rob Herring 2021-12-13 13:49 ` [PATCH v3 03/23] media: atmel: introduce microchip csi2dc driver Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2022-01-11 15:43 ` Jacopo Mondi 2022-01-11 15:43 ` Jacopo Mondi 2021-12-13 13:49 ` [PATCH v3 04/23] media: atmel: atmel-isc: split the clock code into separate source file Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2022-01-11 15:43 ` Jacopo Mondi 2022-01-11 15:43 ` Jacopo Mondi 2021-12-13 13:49 ` [PATCH v3 05/23] media: atmel: atmel-isc: replace video device name with module name Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2021-12-13 13:49 ` [PATCH v3 06/23] media: atmel: atmel-sama7g5-isc: fix ispck leftover Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2021-12-13 13:49 ` [PATCH v3 07/23] media: atmel: atmel-isc-base: use streaming status when queueing buffers Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2022-01-11 15:53 ` Hans Verkuil 2022-01-11 15:53 ` Hans Verkuil 2022-01-11 16:38 ` Eugen.Hristev 2022-01-11 16:38 ` Eugen.Hristev 2022-01-12 9:52 ` Hans Verkuil 2022-01-12 9:52 ` Hans Verkuil 2021-12-13 13:49 ` [PATCH v3 08/23] media: atmel: atmel-isc-base: remove frameintervals VIDIOC Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2021-12-13 13:49 ` [PATCH v3 09/23] media: atmel: atmel-isc-base: report frame sizes as full supported range Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2021-12-13 13:49 ` [PATCH v3 10/23] media: atmel: atmel-isc-base: implement mbus_code support in enumfmt Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2021-12-13 13:49 ` [PATCH v3 11/23] media: atmel: atmel-isc-base: fix bytesperline value for planar formats Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2021-12-13 13:49 ` [PATCH v3 12/23] media: atmel: atmel-isc: implement media controller Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2022-01-11 16:06 ` Jacopo Mondi 2022-01-11 16:06 ` Jacopo Mondi 2022-01-11 16:30 ` Eugen.Hristev 2022-01-11 16:30 ` Eugen.Hristev 2022-01-11 16:51 ` Jacopo Mondi 2022-01-11 16:51 ` Jacopo Mondi 2022-01-11 17:00 ` Eugen.Hristev 2022-01-11 17:00 ` Eugen.Hristev 2021-12-13 13:49 ` [PATCH v3 13/23] ARM: dts: at91: sama7g5: add nodes for video capture Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2021-12-13 13:49 ` [PATCH v3 14/23] ARM: configs: at91: sama7: add xisc and csi2dc Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2021-12-13 13:49 ` [PATCH v3 15/23] ARM: multi_v7_defconfig: add atmel video pipeline modules Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev [this message] 2021-12-13 13:49 ` [PATCH v3 16/23] media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check Eugen Hristev 2021-12-13 13:49 ` [PATCH v3 17/23] media: atmel: atmel-isc-base: use mutex to lock awb workqueue from streaming Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2022-01-12 8:58 ` Jacopo Mondi 2022-01-12 8:58 ` Jacopo Mondi 2022-01-19 15:40 ` Eugen.Hristev 2022-01-19 15:40 ` Eugen.Hristev 2021-12-13 13:49 ` [PATCH v3 18/23] media: atmel: atmel-isc-base: add wb debug messages Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2022-01-12 9:00 ` Jacopo Mondi 2022-01-12 9:00 ` Jacopo Mondi 2021-12-13 13:49 ` [PATCH v3 19/23] media: atmel: atmel-isc-base: clamp wb gain coefficients Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2022-01-12 9:04 ` Jacopo Mondi 2022-01-12 9:04 ` Jacopo Mondi 2021-12-13 13:49 ` [PATCH v3 20/23] media: atmel: atmel-sama7g5-isc: fix UYVY input format mbus_code typo Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2022-01-12 9:04 ` Jacopo Mondi 2022-01-12 9:04 ` Jacopo Mondi 2021-12-13 13:49 ` [PATCH v3 21/23] media: atmel: atmel-isc: add raw Bayer 8bit 10bit output formats Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2022-01-12 9:05 ` Jacopo Mondi 2022-01-12 9:05 ` Jacopo Mondi 2021-12-13 13:49 ` [PATCH v3 22/23] media: atmel: atmel-isc: compact the controller formats list Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2022-01-12 9:06 ` Jacopo Mondi 2022-01-12 9:06 ` Jacopo Mondi 2021-12-13 13:49 ` [PATCH v3 23/23] media: atmel: atmel-isc: change format propagation to subdev into only verification Eugen Hristev 2021-12-13 13:49 ` Eugen Hristev 2022-01-12 9:21 ` Jacopo Mondi 2022-01-12 9:21 ` Jacopo Mondi 2022-01-20 8:43 ` Eugen.Hristev 2022-01-20 8:43 ` Eugen.Hristev 2022-01-20 8:48 ` Eugen.Hristev 2022-01-20 8:48 ` Eugen.Hristev 2022-01-20 8:58 ` Jacopo Mondi 2022-01-20 8:58 ` Jacopo Mondi 2022-01-12 12:07 ` [PATCH v3 00/23] media: atmel: atmel-isc: implement media controller Hans Verkuil 2022-01-12 12:07 ` Hans Verkuil 2022-01-12 12:46 ` Eugen.Hristev 2022-01-12 12:46 ` Eugen.Hristev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211213134940.324266-17-eugen.hristev@microchip.com \ --to=eugen.hristev@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=jacopo@jmondi.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=nicolas.ferre@microchip.com \ --cc=robh+dt@kernel.org \ --cc=sakari.ailus@iki.fi \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.