From: kernel test robot <lkp@intel.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>,
linux-integrity@vger.kernel.org
Cc: kbuild-all@lists.01.org, zohar@linux.ibm.com, serge@hallyn.com,
christian.brauner@ubuntu.com, containers@lists.linux.dev,
dmitry.kasatkin@gmail.com, ebiederm@xmission.com,
krzysztof.struczynski@huawei.com, roberto.sassu@huawei.com,
mpeters@redhat.com
Subject: [RFC PATCH] securityfs: securityfs_dir_inode_operations can be static
Date: Sat, 18 Dec 2021 00:21:35 +0800 [thread overview]
Message-ID: <20211217162135.GA21682@93035147186e> (raw)
In-Reply-To: <20211216054323.1707384-11-stefanb@linux.vnet.ibm.com>
security/inode.c:43:31: warning: symbol 'securityfs_dir_inode_operations' was not declared. Should it be static?
security/inode.c:48:31: warning: symbol 'securityfs_file_inode_operations' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/security/inode.c b/security/inode.c
index a0d9f086e3d54..ff720c6bedb0a 100644
--- a/security/inode.c
+++ b/security/inode.c
@@ -40,12 +40,12 @@ static int securityfs_permission(struct user_namespace *mnt_userns,
return err;
}
-const struct inode_operations securityfs_dir_inode_operations = {
+static const struct inode_operations securityfs_dir_inode_operations = {
.permission = securityfs_permission,
.lookup = simple_lookup,
};
-const struct inode_operations securityfs_file_inode_operations = {
+static const struct inode_operations securityfs_file_inode_operations = {
.permission = securityfs_permission,
};
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [RFC PATCH] securityfs: securityfs_dir_inode_operations can be static
Date: Sat, 18 Dec 2021 00:21:35 +0800 [thread overview]
Message-ID: <20211217162135.GA21682@93035147186e> (raw)
In-Reply-To: <20211216054323.1707384-11-stefanb@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]
security/inode.c:43:31: warning: symbol 'securityfs_dir_inode_operations' was not declared. Should it be static?
security/inode.c:48:31: warning: symbol 'securityfs_file_inode_operations' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/security/inode.c b/security/inode.c
index a0d9f086e3d54..ff720c6bedb0a 100644
--- a/security/inode.c
+++ b/security/inode.c
@@ -40,12 +40,12 @@ static int securityfs_permission(struct user_namespace *mnt_userns,
return err;
}
-const struct inode_operations securityfs_dir_inode_operations = {
+static const struct inode_operations securityfs_dir_inode_operations = {
.permission = securityfs_permission,
.lookup = simple_lookup,
};
-const struct inode_operations securityfs_file_inode_operations = {
+static const struct inode_operations securityfs_file_inode_operations = {
.permission = securityfs_permission,
};
next prev parent reply other threads:[~2021-12-17 16:22 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 5:43 [PATCH v7 00/14] ima: Namespace IMA with audit support in IMA-ns Stefan Berger
2021-12-16 5:43 ` [PATCH v7 01/14] ima: Add IMA namespace support Stefan Berger
2021-12-16 14:08 ` Christian Brauner
2021-12-16 21:52 ` James Bottomley
2021-12-17 9:55 ` Christian Brauner
2021-12-16 5:43 ` [PATCH v7 02/14] ima: Define ns_status for storing namespaced iint data Stefan Berger
2021-12-16 5:43 ` [PATCH v7 03/14] ima: Namespace audit status flags Stefan Berger
2021-12-16 5:43 ` [PATCH v7 04/14] ima: Move policy related variables into ima_namespace Stefan Berger
2021-12-16 14:26 ` kernel test robot
2021-12-16 14:26 ` kernel test robot
2021-12-16 5:43 ` [PATCH v7 05/14] ima: Move ima_htable " Stefan Berger
2021-12-16 5:43 ` [PATCH v7 06/14] ima: Move measurement list related variables " Stefan Berger
2021-12-16 5:43 ` [PATCH v7 07/14] ima: Only accept AUDIT rules for IMA non-init_ima_ns namespaces for now Stefan Berger
2021-12-16 5:43 ` [PATCH v7 08/14] ima: Implement hierarchical processing of file accesses Stefan Berger
2021-12-16 5:43 ` [PATCH v7 09/14] securityfs: Only use simple_pin_fs/simple_release_fs for init_user_ns Stefan Berger
2021-12-16 5:43 ` [PATCH v7 10/14] securityfs: Extend securityfs with namespacing support Stefan Berger
2021-12-16 13:40 ` Christian Brauner
2021-12-16 16:28 ` Christian Brauner
2022-01-03 14:09 ` Stefan Berger
2021-12-17 16:21 ` kernel test robot [this message]
2021-12-17 16:21 ` [RFC PATCH] securityfs: securityfs_dir_inode_operations can be static kernel test robot
2021-12-17 16:29 ` [PATCH v7 10/14] securityfs: Extend securityfs with namespacing support kernel test robot
2021-12-17 16:29 ` kernel test robot
2021-12-16 5:43 ` [PATCH v7 11/14] ima: Move some IMA policy and filesystem related variables into ima_namespace Stefan Berger
2021-12-16 5:43 ` [PATCH v7 12/14] ima: Use mac_admin_ns_capable() to check corresponding capability Stefan Berger
2021-12-16 5:43 ` [PATCH v7 13/14] ima: Move dentry into ima_namespace and others onto stack Stefan Berger
2021-12-16 5:43 ` [PATCH v7 14/14] ima: Setup securityfs for IMA namespace Stefan Berger
2021-12-16 10:59 ` kernel test robot
2021-12-16 10:59 ` kernel test robot
2021-12-16 12:02 ` kernel test robot
2021-12-16 12:02 ` kernel test robot
2021-12-16 13:51 ` Christian Brauner
2021-12-16 21:38 ` Stefan Berger
2021-12-16 12:50 ` [PATCH v7 00/14] ima: Namespace IMA with audit support in IMA-ns Christian Brauner
2021-12-16 13:31 ` Christian Brauner
2021-12-16 21:27 ` Stefan Berger
2021-12-17 10:25 ` Christian Brauner
2021-12-18 2:38 ` Stefan Berger
2021-12-18 12:41 ` Christian Brauner
2021-12-16 21:00 ` Stefan Berger
2021-12-17 10:06 ` Christian Brauner
2021-12-27 17:29 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217162135.GA21682@93035147186e \
--to=lkp@intel.com \
--cc=christian.brauner@ubuntu.com \
--cc=containers@lists.linux.dev \
--cc=dmitry.kasatkin@gmail.com \
--cc=ebiederm@xmission.com \
--cc=kbuild-all@lists.01.org \
--cc=krzysztof.struczynski@huawei.com \
--cc=linux-integrity@vger.kernel.org \
--cc=mpeters@redhat.com \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=stefanb@linux.vnet.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.