From: Lu Baolu <baolu.lu@linux.intel.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Joerg Roedel <joro@8bytes.org>, Alex Williamson <alex.williamson@redhat.com>, Bjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@nvidia.com>, Christoph Hellwig <hch@infradead.org>, Kevin Tian <kevin.tian@intel.com>, Ashok Raj <ashok.raj@intel.com> Cc: Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Dan Williams <dan.j.williams@intel.com>, rafael@kernel.org, Diana Craciun <diana.craciun@oss.nxp.com>, Cornelia Huck <cohuck@redhat.com>, Eric Auger <eric.auger@redhat.com>, Liu Yi L <yi.l.liu@intel.com>, Jacob jun Pan <jacob.jun.pan@intel.com>, Chaitanya Kulkarni <kch@nvidia.com>, Stuart Yoder <stuyoder@gmail.com>, Laurentiu Tudor <laurentiu.tudor@nxp.com>, Thierry Reding <thierry.reding@gmail.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Jonathan Hunter <jonathanh@nvidia.com>, Li Yang <leoyang.li@nxp.com>, Dmitry Osipenko <digetx@gmail.com>, iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com> Subject: [PATCH v5 11/14] vfio: Remove use of vfio_group_viable() Date: Tue, 4 Jan 2022 09:56:41 +0800 [thread overview] Message-ID: <20220104015644.2294354-12-baolu.lu@linux.intel.com> (raw) In-Reply-To: <20220104015644.2294354-1-baolu.lu@linux.intel.com> As DMA USER ownership is claimed for the iommu group when a vfio group is added to a vfio container, the vfio group viability is guaranteed as long as group->container_users > 0. Remove those unnecessary group viability checks which are only hit when group->container_users is not zero. The only remaining reference is in GROUP_GET_STATUS, which could be called at any time when group fd is valid. Here we just replace the vfio_group_viable() by directly calling iommu core to get viability status. Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> --- drivers/vfio/vfio.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c index ef22fa312c2a..789861853676 100644 --- a/drivers/vfio/vfio.c +++ b/drivers/vfio/vfio.c @@ -1313,12 +1313,6 @@ static int vfio_group_set_container(struct vfio_group *group, int container_fd) return ret; } -static bool vfio_group_viable(struct vfio_group *group) -{ - return (iommu_group_for_each_dev(group->iommu_group, - group, vfio_dev_viable) == 0); -} - static int vfio_group_add_container_user(struct vfio_group *group) { if (!atomic_inc_not_zero(&group->container_users)) @@ -1328,7 +1322,7 @@ static int vfio_group_add_container_user(struct vfio_group *group) atomic_dec(&group->container_users); return -EPERM; } - if (!group->container->iommu_driver || !vfio_group_viable(group)) { + if (!group->container->iommu_driver) { atomic_dec(&group->container_users); return -EINVAL; } @@ -1346,7 +1340,7 @@ static int vfio_group_get_device_fd(struct vfio_group *group, char *buf) int ret = 0; if (0 == atomic_read(&group->container_users) || - !group->container->iommu_driver || !vfio_group_viable(group)) + !group->container->iommu_driver) return -EINVAL; if (group->type == VFIO_NO_IOMMU && !capable(CAP_SYS_RAWIO)) @@ -1438,11 +1432,11 @@ static long vfio_group_fops_unl_ioctl(struct file *filep, status.flags = 0; - if (vfio_group_viable(group)) - status.flags |= VFIO_GROUP_FLAGS_VIABLE; - if (group->container) - status.flags |= VFIO_GROUP_FLAGS_CONTAINER_SET; + status.flags |= VFIO_GROUP_FLAGS_CONTAINER_SET | + VFIO_GROUP_FLAGS_VIABLE; + else if (!iommu_group_dma_owner_claimed(group->iommu_group)) + status.flags |= VFIO_GROUP_FLAGS_VIABLE; if (copy_to_user((void __user *)arg, &status, minsz)) return -EFAULT; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Joerg Roedel <joro@8bytes.org>, Alex Williamson <alex.williamson@redhat.com>, Bjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@nvidia.com>, Christoph Hellwig <hch@infradead.org>, Kevin Tian <kevin.tian@intel.com>, Ashok Raj <ashok.raj@intel.com> Cc: kvm@vger.kernel.org, rafael@kernel.org, David Airlie <airlied@linux.ie>, linux-pci@vger.kernel.org, Thierry Reding <thierry.reding@gmail.com>, Diana Craciun <diana.craciun@oss.nxp.com>, Dmitry Osipenko <digetx@gmail.com>, Will Deacon <will@kernel.org>, Stuart Yoder <stuyoder@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Chaitanya Kulkarni <kch@nvidia.com>, Dan Williams <dan.j.williams@intel.com>, Cornelia Huck <cohuck@redhat.com>, linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>, iommu@lists.linux-foundation.org, Jacob jun Pan <jacob.jun.pan@intel.com>, Daniel Vetter <daniel@ffwll.ch>, Robin Murphy <robin.murphy@arm.com> Subject: [PATCH v5 11/14] vfio: Remove use of vfio_group_viable() Date: Tue, 4 Jan 2022 09:56:41 +0800 [thread overview] Message-ID: <20220104015644.2294354-12-baolu.lu@linux.intel.com> (raw) In-Reply-To: <20220104015644.2294354-1-baolu.lu@linux.intel.com> As DMA USER ownership is claimed for the iommu group when a vfio group is added to a vfio container, the vfio group viability is guaranteed as long as group->container_users > 0. Remove those unnecessary group viability checks which are only hit when group->container_users is not zero. The only remaining reference is in GROUP_GET_STATUS, which could be called at any time when group fd is valid. Here we just replace the vfio_group_viable() by directly calling iommu core to get viability status. Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> --- drivers/vfio/vfio.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c index ef22fa312c2a..789861853676 100644 --- a/drivers/vfio/vfio.c +++ b/drivers/vfio/vfio.c @@ -1313,12 +1313,6 @@ static int vfio_group_set_container(struct vfio_group *group, int container_fd) return ret; } -static bool vfio_group_viable(struct vfio_group *group) -{ - return (iommu_group_for_each_dev(group->iommu_group, - group, vfio_dev_viable) == 0); -} - static int vfio_group_add_container_user(struct vfio_group *group) { if (!atomic_inc_not_zero(&group->container_users)) @@ -1328,7 +1322,7 @@ static int vfio_group_add_container_user(struct vfio_group *group) atomic_dec(&group->container_users); return -EPERM; } - if (!group->container->iommu_driver || !vfio_group_viable(group)) { + if (!group->container->iommu_driver) { atomic_dec(&group->container_users); return -EINVAL; } @@ -1346,7 +1340,7 @@ static int vfio_group_get_device_fd(struct vfio_group *group, char *buf) int ret = 0; if (0 == atomic_read(&group->container_users) || - !group->container->iommu_driver || !vfio_group_viable(group)) + !group->container->iommu_driver) return -EINVAL; if (group->type == VFIO_NO_IOMMU && !capable(CAP_SYS_RAWIO)) @@ -1438,11 +1432,11 @@ static long vfio_group_fops_unl_ioctl(struct file *filep, status.flags = 0; - if (vfio_group_viable(group)) - status.flags |= VFIO_GROUP_FLAGS_VIABLE; - if (group->container) - status.flags |= VFIO_GROUP_FLAGS_CONTAINER_SET; + status.flags |= VFIO_GROUP_FLAGS_CONTAINER_SET | + VFIO_GROUP_FLAGS_VIABLE; + else if (!iommu_group_dma_owner_claimed(group->iommu_group)) + status.flags |= VFIO_GROUP_FLAGS_VIABLE; if (copy_to_user((void __user *)arg, &status, minsz)) return -EFAULT; -- 2.25.1 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-01-04 1:58 UTC|newest] Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-04 1:56 [PATCH v5 00/14] Fix BUG_ON in vfio_iommu_group_notifier() Lu Baolu 2022-01-04 1:56 ` Lu Baolu 2022-01-04 1:56 ` [PATCH v5 01/14] iommu: Add dma ownership management interfaces Lu Baolu 2022-01-04 1:56 ` Lu Baolu 2022-01-04 10:08 ` Christoph Hellwig 2022-01-04 10:08 ` Christoph Hellwig 2022-01-04 16:41 ` Bjorn Helgaas 2022-01-04 16:41 ` Bjorn Helgaas 2022-01-04 19:23 ` Jason Gunthorpe 2022-01-04 19:23 ` Jason Gunthorpe via iommu 2022-01-06 3:18 ` Lu Baolu 2022-01-06 3:18 ` Lu Baolu 2022-01-06 3:54 ` Lu Baolu 2022-01-06 3:54 ` Lu Baolu 2022-01-06 15:46 ` Jason Gunthorpe 2022-01-06 15:46 ` Jason Gunthorpe via iommu 2022-01-07 1:50 ` Lu Baolu 2022-01-07 1:50 ` Lu Baolu 2022-01-06 3:43 ` Lu Baolu 2022-01-06 3:43 ` Lu Baolu 2022-01-06 3:47 ` Lu Baolu 2022-01-06 3:47 ` Lu Baolu 2022-01-06 3:51 ` Lu Baolu 2022-01-06 3:51 ` Lu Baolu 2022-01-05 6:57 ` Lu Baolu 2022-01-05 6:57 ` Lu Baolu 2022-01-04 1:56 ` [PATCH v5 02/14] driver core: Add dma_cleanup callback in bus_type Lu Baolu 2022-01-04 1:56 ` Lu Baolu 2022-01-04 10:08 ` Christoph Hellwig 2022-01-04 10:08 ` Christoph Hellwig 2022-01-04 12:39 ` Jason Gunthorpe 2022-01-04 12:39 ` Jason Gunthorpe via iommu 2022-01-04 13:04 ` Greg Kroah-Hartman 2022-01-04 13:04 ` Greg Kroah-Hartman 2022-02-08 5:55 ` Lu Baolu 2022-02-08 5:55 ` Lu Baolu 2022-02-08 11:35 ` Greg Kroah-Hartman 2022-02-08 11:35 ` Greg Kroah-Hartman 2022-02-14 10:01 ` Greg Kroah-Hartman 2022-02-14 10:01 ` Greg Kroah-Hartman 2022-02-14 10:02 ` Greg Kroah-Hartman 2022-02-14 10:02 ` Greg Kroah-Hartman 2022-01-04 1:56 ` [PATCH v5 03/14] amba: Stop sharing platform_dma_configure() Lu Baolu 2022-01-04 1:56 ` Lu Baolu 2022-01-04 1:56 ` [PATCH v5 04/14] driver core: platform: Add driver dma ownership management Lu Baolu 2022-01-04 1:56 ` Lu Baolu 2022-02-14 9:59 ` Greg Kroah-Hartman 2022-02-14 9:59 ` Greg Kroah-Hartman 2022-02-14 13:18 ` Jason Gunthorpe 2022-02-14 13:18 ` Jason Gunthorpe via iommu 2022-02-14 13:37 ` Greg Kroah-Hartman 2022-02-14 13:37 ` Greg Kroah-Hartman 2022-02-14 13:43 ` Jason Gunthorpe 2022-02-14 13:43 ` Jason Gunthorpe via iommu 2022-01-04 1:56 ` [PATCH v5 05/14] amba: " Lu Baolu 2022-01-04 1:56 ` Lu Baolu 2022-01-04 1:56 ` [PATCH v5 06/14] bus: fsl-mc: " Lu Baolu 2022-01-04 1:56 ` Lu Baolu 2022-01-04 1:56 ` [PATCH v5 07/14] PCI: " Lu Baolu 2022-01-04 1:56 ` Lu Baolu 2022-02-14 10:03 ` Greg Kroah-Hartman 2022-02-14 10:03 ` Greg Kroah-Hartman 2022-02-14 12:38 ` Jason Gunthorpe 2022-02-14 12:38 ` Jason Gunthorpe via iommu 2022-02-14 12:51 ` Greg Kroah-Hartman 2022-02-14 12:51 ` Greg Kroah-Hartman 2022-02-14 13:11 ` Jason Gunthorpe 2022-02-14 13:11 ` Jason Gunthorpe via iommu 2022-02-14 13:39 ` Greg Kroah-Hartman 2022-02-14 13:39 ` Greg Kroah-Hartman 2022-02-14 13:43 ` Jason Gunthorpe 2022-02-14 13:43 ` Jason Gunthorpe via iommu 2022-02-15 3:06 ` Lu Baolu 2022-02-15 3:06 ` Lu Baolu 2022-02-23 18:00 ` Bjorn Helgaas 2022-02-23 18:00 ` Bjorn Helgaas 2022-02-23 18:07 ` Jason Gunthorpe 2022-02-23 18:07 ` Jason Gunthorpe via iommu 2022-01-04 1:56 ` [PATCH v5 08/14] PCI: pci_stub: Suppress kernel DMA ownership auto-claiming Lu Baolu 2022-01-04 1:56 ` Lu Baolu 2022-01-04 1:56 ` [PATCH v5 09/14] PCI: portdrv: " Lu Baolu 2022-01-04 1:56 ` Lu Baolu 2022-01-04 17:06 ` Bjorn Helgaas 2022-01-04 17:06 ` Bjorn Helgaas 2022-01-04 19:26 ` Jason Gunthorpe 2022-01-04 19:26 ` Jason Gunthorpe via iommu 2022-01-04 19:51 ` Bjorn Helgaas 2022-01-04 19:51 ` Bjorn Helgaas 2022-01-05 0:35 ` Jason Gunthorpe 2022-01-05 0:35 ` Jason Gunthorpe via iommu 2022-01-06 4:12 ` Lu Baolu 2022-01-06 4:12 ` Lu Baolu 2022-01-06 18:32 ` Bjorn Helgaas 2022-01-06 18:32 ` Bjorn Helgaas 2022-01-07 1:53 ` Lu Baolu 2022-01-07 1:53 ` Lu Baolu 2022-01-04 1:56 ` [PATCH v5 10/14] vfio: Set DMA ownership for VFIO devices Lu Baolu 2022-01-04 1:56 ` Lu Baolu 2022-01-04 1:56 ` Lu Baolu [this message] 2022-01-04 1:56 ` [PATCH v5 11/14] vfio: Remove use of vfio_group_viable() Lu Baolu 2022-01-04 1:56 ` [PATCH v5 12/14] vfio: Delete the unbound_list Lu Baolu 2022-01-04 1:56 ` Lu Baolu 2022-01-04 1:56 ` [PATCH v5 13/14] vfio: Remove iommu group notifier Lu Baolu 2022-01-04 1:56 ` Lu Baolu 2022-01-04 1:56 ` [PATCH v5 14/14] iommu: Remove iommu group changes notifier Lu Baolu 2022-01-04 1:56 ` Lu Baolu 2022-01-04 12:48 ` [PATCH v5 00/14] Fix BUG_ON in vfio_iommu_group_notifier() Jason Gunthorpe 2022-01-04 12:48 ` Jason Gunthorpe via iommu 2022-01-05 6:52 ` Lu Baolu 2022-01-05 6:52 ` Lu Baolu 2022-02-18 1:07 ` Lu Baolu 2022-02-18 1:07 ` Lu Baolu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220104015644.2294354-12-baolu.lu@linux.intel.com \ --to=baolu.lu@linux.intel.com \ --cc=airlied@linux.ie \ --cc=alex.williamson@redhat.com \ --cc=ashok.raj@intel.com \ --cc=bhelgaas@google.com \ --cc=cohuck@redhat.com \ --cc=dan.j.williams@intel.com \ --cc=daniel@ffwll.ch \ --cc=diana.craciun@oss.nxp.com \ --cc=digetx@gmail.com \ --cc=eric.auger@redhat.com \ --cc=gregkh@linuxfoundation.org \ --cc=hch@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@intel.com \ --cc=jgg@nvidia.com \ --cc=jonathanh@nvidia.com \ --cc=joro@8bytes.org \ --cc=kch@nvidia.com \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=laurentiu.tudor@nxp.com \ --cc=leoyang.li@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=rafael@kernel.org \ --cc=robin.murphy@arm.com \ --cc=stuyoder@gmail.com \ --cc=thierry.reding@gmail.com \ --cc=will@kernel.org \ --cc=yi.l.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.