From: Henning Schild <henning.schild@siemens.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Aaron Ma <aaron.ma@canonical.com>, <kuba@kernel.org>,
<linux-usb@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <davem@davemloft.net>,
<hayeswang@realtek.com>, <tiwai@suse.de>
Subject: Re: [PATCH 1/3 v3] net: usb: r8152: Check used MAC passthrough address
Date: Wed, 5 Jan 2022 18:40:10 +0100 [thread overview]
Message-ID: <20220105184010.058955dc@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <YdXVoNFB/Asq6bc/@lunn.ch>
Am Wed, 5 Jan 2022 18:30:08 +0100
schrieb Andrew Lunn <andrew@lunn.ch>:
> On Wed, Jan 05, 2022 at 11:14:25PM +0800, Aaron Ma wrote:
> > When plugin multiple r8152 ethernet dongles to Lenovo Docks
> > or USB hub, MAC passthrough address from BIOS should be
> > checked if it had been used to avoid using on other dongles.
> >
> > Currently builtin r8152 on Dock still can't be identified.
> > First detected r8152 will use the MAC passthrough address.
>
> I do have to wonder why you are doing this in the kernel, and not
> using a udev rule? This seems to be policy, and policy does not belong
> in the kernel.
Yes, the whole pass-thru story should not be a kernel feature in the
first place, i could not agree more, udev would be the way better place!
But it is part of the driver and Aaron did not introduce it but just
extend it.
Henning
> Andrew
next prev parent reply other threads:[~2022-01-05 17:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 15:14 [PATCH 1/3 v3] net: usb: r8152: Check used MAC passthrough address Aaron Ma
2022-01-05 15:14 ` [PATCH 2/3] net: usb: r8152: Set probe mode to sync Aaron Ma
2022-01-05 15:33 ` Greg KH
2022-01-05 15:14 ` [PATCH 3/3] net: usb: r8152: remove unused definition Aaron Ma
2022-01-05 15:34 ` Greg KH
2022-01-05 15:31 ` [PATCH 1/3 v3] net: usb: r8152: Check used MAC passthrough address Greg KH
2022-01-05 15:57 ` Henning Schild
2022-01-05 17:30 ` Andrew Lunn
2022-01-05 17:40 ` Henning Schild [this message]
2022-01-05 21:49 ` Oliver Neukum
2022-01-05 22:27 ` Andrew Lunn
2022-01-06 2:10 ` Kai-Heng Feng
2022-01-06 13:27 ` Andrew Lunn
2022-01-07 2:01 ` Kai-Heng Feng
2022-01-07 2:31 ` Jakub Kicinski
2022-01-10 3:32 ` Kai-Heng Feng
2022-01-10 16:51 ` Jakub Kicinski
2022-01-11 1:51 ` Kai-Heng Feng
2022-01-11 14:57 ` Limonciello, Mario
2022-01-11 16:26 ` Jakub Kicinski
2022-01-11 16:33 ` Limonciello, Mario
2022-01-11 16:43 ` Jakub Kicinski
2022-01-11 16:54 ` Limonciello, Mario
2022-01-11 17:06 ` Jakub Kicinski
2022-01-11 17:10 ` Limonciello, Mario
2022-01-12 19:21 ` Henning Schild
2022-01-12 19:27 ` Limonciello, Mario
2022-01-13 3:23 ` Aaron Ma
2022-01-27 2:51 ` Aaron Ma
2022-01-27 8:06 ` Hayes Wang
2022-01-27 8:13 ` Aaron Ma
2022-01-27 8:42 ` Hayes Wang
2022-01-27 12:53 ` Andrew Lunn
2022-01-07 13:32 ` Andrew Lunn
2022-01-10 3:39 ` Kai-Heng Feng
2022-01-10 11:39 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105184010.058955dc@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=aaron.ma@canonical.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.