RE: [PATCH 1/3 v3] net: usb: r8152: Check used MAC passthrough address

From: Hayes Wang <hayeswang@realtek.com>
To: Aaron Ma <aaron.ma@canonical.com>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>,
	Henning Schild <henning.schild@siemens.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Andrew Lunn <andrew@lunn.ch>, Oliver Neukum <oneukum@suse.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"tiwai@suse.de" <tiwai@suse.de>
Subject: RE: [PATCH 1/3 v3] net: usb: r8152: Check used MAC passthrough address
Date: Thu, 27 Jan 2022 08:06:20 +0000	[thread overview]
Message-ID: <5b94f064bd5c48589ea856f68ac0e930@realtek.com> (raw)
In-Reply-To: <edff6219-b1f7-dec5-22ea-0bde9a3e0efb@canonical.com>

Aaron Ma <aaron.ma@canonical.com>
> Sent: Thursday, January 27, 2022 10:52 AM
[...]
> Hi all,
> 
> Realtek 8153BL can be identified by the following code from Realtek Outbox
> driver:
> } else if (tp->version == RTL_VER_09 && (ocp_data & BL_MASK)) {
> 
> I will suggest Realtek to send out this change for review.

I don't think the feature of MAC passthrough address is maintained
by Realtek. Especially, there is no uniform way about it. The
different companies have to maintain their own ways by themselves.

Realtek could provide the method of finding out the specific device
for Lenovo. You could check USB OCP 0xD81F bit 3. For example,

	ocp_data = ocp_read_byte(tp, MCU_TYPE_USB, USB_MISC_1);
	if (tp->version == RTL_VER_09 && (ocp_data & BIT(3))) {
		/* This is the RTL8153B for Lenovo. */
	}

Best Regards,
Hayes